From: Simon Horman <horms@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, rmk+kernel@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: micrel: Fix lan8814_config_init
Date: Fri, 26 Sep 2025 11:07:16 +0100 [thread overview]
Message-ID: <aNZl1NxC3OAUPS7A@horms.kernel.org> (raw)
In-Reply-To: <20250925064702.3906950-1-horatiu.vultur@microchip.com>
On Thu, Sep 25, 2025 at 08:47:02AM +0200, Horatiu Vultur wrote:
> The blamed commit introduced the function lanphy_modify_page_reg which
> as name suggests it, it modifies the registers. In the same commit we
> have started to use this function inside the drivers. The problem is
> that in the function lan8814_config_init we passed the wrong page number
> when disabling the aneg towards host side. We passed extended page number
> 4(LAN8814_PAGE_COMMON_REGS) instead of extended page
> 5(LAN8814_PAGE_PORT_REGS)
>
> Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> ---
> this is targeting net-next and not net because the blamed commit doesn't
> exist on net
Thanks, I agree that the page was changed in the cited commit.
And it seems to me that it wasn't an intentional change.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-26 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 6:47 [PATCH net-next] net: phy: micrel: Fix lan8814_config_init Horatiu Vultur
2025-09-26 10:07 ` Simon Horman [this message]
2025-09-27 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNZl1NxC3OAUPS7A@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.