From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60AD8CAC5BC for ; Fri, 26 Sep 2025 14:03:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1CF3261C58; Fri, 26 Sep 2025 14:03:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id txpPBd3xcqna; Fri, 26 Sep 2025 14:03:10 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5CD8361C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1758895390; bh=Ty6eHxuL03xj/Jw+AmKcNGmU/GEnopMXr86I8u6r9wk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Yo5vMw6ust2QZV5pwUQZVYZDnyoHg+Mn9hMej/9FZUaNXHdRwFe1+tvz0WWuRZrpI qPwKi3Ge4euqQyuujyjfUo3iWdSWogIR4qWbpxNaVX2Ui6jJ5ZfvkFgGZ/7rZ4SL1A 9DbXNAlafd5aIEBEg53vGwCsiGopHymp++6ToGOtLaAZMo8p3Eh8Piwj8+zj6PQduj hu9ZoB1G7whMPmub4pom/4RPxwCjg6aGnjEKnZvenwEFt5WWsAQ8uQPc59DnBi3jQK 4zvaoXsu88tOQkNH6C5QuK6vplVFGgGTMCBrI+459WaqHraohofmOuTqwoUQcu6CHA HTJ6RPeiAjqOQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 5CD8361C53; Fri, 26 Sep 2025 14:03:10 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 29F8612D for ; Fri, 26 Sep 2025 14:03:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1087F4226D for ; Fri, 26 Sep 2025 14:03:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id icqSqXK5-diU for ; Fri, 26 Sep 2025 14:03:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7E91642064 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7E91642064 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7E91642064 for ; Fri, 26 Sep 2025 14:03:08 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B0BFC40B65; Fri, 26 Sep 2025 14:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DC41C116B1; Fri, 26 Sep 2025 14:03:04 +0000 (UTC) Date: Fri, 26 Sep 2025 15:03:03 +0100 From: Simon Horman To: Alok Tiwari Message-ID: References: <20250925180212.415093-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250925180212.415093-1-alok.a.tiwari@oracle.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758895387; bh=D3yE3RXNEe3cKems2Eep6LHdH9Tp4ND0Hi86D8+zqg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Emx37HY6kV5btgt/bVj4p0MF1pzRlLsLTN5KUiolsRdR5lWEp/TBjfaeHMirjddSP WERu8ARGLRf3HwTEPMPMFDF4i+qcLs2cQqhi2yc3ROA36X4QTb41hMXz7Kk6KLg0Pd wpzcNwZwZkBJFkMr2CiMVdQWllRPN+k4N8Defj0cP4/ht0lErovLE/gYOieUnH/Kvn RsCQbGSXU3bm8yDFoc8bwfUdr8iB0SR8GMh8wrY7mTswXlKikZX6Q9/uah2BD3eBr+ DpV10Dzr8R35ESzNQY5v6N24OWal6YjEoi3yHBzd3KdxPzuM59DTwBn+Zpn9CzZZgL p/0uFxG9wklGg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Emx37HY6 Subject: Re: [Intel-wired-lan] [PATCH net] idpf: fix mismatched free function for dma_alloc_coherent X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, aleksander.lobakin@intel.com, edumazet@google.com, anthony.l.nguyen@intel.com, alan.brady@intel.com, netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Sep 25, 2025 at 11:02:10AM -0700, Alok Tiwari wrote: > The mailbox receive path allocates coherent DMA memory with > dma_alloc_coherent(), but frees it with dmam_free_coherent(). > This is incorrect since dmam_free_coherent() is only valid for > buffers allocated with dmam_alloc_coherent(). > > Fix the mismatch by using dma_free_coherent() instead of > dmam_free_coherent > > Fixes: e54232da1238 ("idpf: refactor idpf_recv_mb_msg") > Signed-off-by: Alok Tiwari Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59532F6581 for ; Fri, 26 Sep 2025 14:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758895387; cv=none; b=tRqj2u2Kx7LYmhb9uTOd8n0BjP+QIUea3Au6q52MMkT/xRKxv6SeKC9eIJXm3remzwQasrDMbN21QDOAMf8qVJ9udQvfI1ZQvJSxWZFgwdwFKIOPLpkOr7cgRi48Gy1O0ogOZsVoGzcVckbccRLc52ucP3l87vm6RWvLYgn99Hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758895387; c=relaxed/simple; bh=D3yE3RXNEe3cKems2Eep6LHdH9Tp4ND0Hi86D8+zqg4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iuj/iihYfSOjX+MijTrZuCpSiCbDQZ+IxEmG7u0562HKP1npIODp+a9jXeM/N/8l3l3yASvZ5mrn5cygdJvrqxz9gGs0quk2HQjSpIqdo1gwXLd6X8q/Qqb1Eet+byXaHEBzaKJ2JfCvpIKSDk8Bn4K+2zRi4L5IFw9EYKBl7vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Emx37HY6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Emx37HY6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DC41C116B1; Fri, 26 Sep 2025 14:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758895387; bh=D3yE3RXNEe3cKems2Eep6LHdH9Tp4ND0Hi86D8+zqg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Emx37HY6kV5btgt/bVj4p0MF1pzRlLsLTN5KUiolsRdR5lWEp/TBjfaeHMirjddSP WERu8ARGLRf3HwTEPMPMFDF4i+qcLs2cQqhi2yc3ROA36X4QTb41hMXz7Kk6KLg0Pd wpzcNwZwZkBJFkMr2CiMVdQWllRPN+k4N8Defj0cP4/ht0lErovLE/gYOieUnH/Kvn RsCQbGSXU3bm8yDFoc8bwfUdr8iB0SR8GMh8wrY7mTswXlKikZX6Q9/uah2BD3eBr+ DpV10Dzr8R35ESzNQY5v6N24OWal6YjEoi3yHBzd3KdxPzuM59DTwBn+Zpn9CzZZgL p/0uFxG9wklGg== Date: Fri, 26 Sep 2025 15:03:03 +0100 From: Simon Horman To: Alok Tiwari Cc: krishneil.k.singh@intel.com, alan.brady@intel.com, aleksander.lobakin@intel.com, andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net] idpf: fix mismatched free function for dma_alloc_coherent Message-ID: References: <20250925180212.415093-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250925180212.415093-1-alok.a.tiwari@oracle.com> On Thu, Sep 25, 2025 at 11:02:10AM -0700, Alok Tiwari wrote: > The mailbox receive path allocates coherent DMA memory with > dma_alloc_coherent(), but frees it with dmam_free_coherent(). > This is incorrect since dmam_free_coherent() is only valid for > buffers allocated with dmam_alloc_coherent(). > > Fix the mismatch by using dma_free_coherent() instead of > dmam_free_coherent > > Fixes: e54232da1238 ("idpf: refactor idpf_recv_mb_msg") > Signed-off-by: Alok Tiwari Reviewed-by: Simon Horman