From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, Sebastian Ott <sebott@redhat.com>
Subject: Re: [PATCH] KVM: selftests: Track width of arm64's timer counter as "int", not "uint64_t"
Date: Fri, 26 Sep 2025 12:48:04 -0700 [thread overview]
Message-ID: <aNbt9NH2iVLPeIDX@linux.dev> (raw)
In-Reply-To: <20250926155838.2612205-1-seanjc@google.com>
On Fri, Sep 26, 2025 at 08:58:38AM -0700, Sean Christopherson wrote:
> Store the width of arm64's timer counter as an "int", not a "uint64_t".
> ilog2() returns an "int", and more importantly using what is an "unsigned
> long" under the hood makes clang unhappy due to a type mismatch when
> clamping the width to a sane value.
>
> arm64/arch_timer_edge_cases.c:1032:10: error: comparison of distinct pointer types
> ('typeof (width) *' (aka 'unsigned long *') and 'typeof (56) *' (aka 'int *'))
> [-Werror,-Wcompare-distinct-pointer-types]
> 1032 | width = clamp(width, 56, 64);
> | ^~~~~~~~~~~~~~~~~~~~
> tools/include/linux/kernel.h:47:45: note: expanded from macro 'clamp'
> 47 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi)
> | ^~~~~~~~~~~~
> tools/include/linux/kernel.h:33:17: note: expanded from macro 'max'
> 33 | (void) (&_max1 == &_max2); \
> | ~~~~~~ ^ ~~~~~~
> tools/include/linux/kernel.h:39:9: note: expanded from macro 'min'
> 39 | typeof(x) _min1 = (x); \
> | ^
>
> Fixes: fad4cf944839 ("KVM: arm64: selftests: Determine effective counter width in arch_timer_edge_cases")
> Cc: Sebastian Ott <sebott@redhat.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
In the absence of a __careless_clamp() :)
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
Thanks,
Oliver
next prev parent reply other threads:[~2025-09-26 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 15:58 [PATCH] KVM: selftests: Track width of arm64's timer counter as "int", not "uint64_t" Sean Christopherson
2025-09-26 19:48 ` Oliver Upton [this message]
2025-09-27 11:29 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNbt9NH2iVLPeIDX@linux.dev \
--to=oliver.upton@linux.dev \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=seanjc@google.com \
--cc=sebott@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.