From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90A328D8FD for ; Fri, 26 Sep 2025 22:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758927225; cv=none; b=EE4Nz+kE2zPnnjn6pvYMIWAzx7AJ28FFvCMerLVv8UJIRWNg4VPBp7vY9ubThNYyO0dolLfJOZf8bC/ZtfUozm7EGDOI2W/KPk2uR7p/A78bKrCyvAQTcIZ/mp77/o7YXPd/SswrCFBawz5X+sYb0szJmRAGl2E4M/yNGUjdXo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758927225; c=relaxed/simple; bh=fEomOeWR3k8vHaHxgyePZUTIkATiM1CSbm2n2U1m+B0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JAUWYZ24iyctIdUnh+qlC2yNbH9F73TyhwiF81Y/SFFy9VkYLwO/2wfuxnxhdnGh0o2Rd/vgrqnrfn3LfvJt+2qJEli6CvB5qjjfai50KDNxu/d9I5nQ2kQZoYgVFXfnoDa2HJz+XYeQeiKFS3+8Y/fxPcTCpfZulnJATRG4T1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PMmYyxbD; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PMmYyxbD" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-78100be28easo2037083b3a.1 for ; Fri, 26 Sep 2025 15:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758927223; x=1759532023; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L64jj/1bEf6Wb3tfKGPiM7Hcv1CIUMxOk206Ub6oLd8=; b=PMmYyxbD0YaFKI+2YT7DJGdSeDPhG94zrNIQx4VdrU3m8w4dwCKu7T6UeiitHXbmwT iuIIoUjSgLARZjpAsKyt23goMtb6FJ7D8QefdwvEASMoVzIxWtlkwBJkZIeFf5Y2Z6xi TaPIEqwdLRJ1itbKJ5g7tvzsktHFNXoyl6uitjM9QAKszWe4cRZQrnb3byl6Zlu3RfmH ngzeZxnFhyvmeNCR2NibUFS8CLYUg7tv8uUsnAbFi9pgzOs9mXdu8yk+h6YcGKQNI4w6 WaXMoger9qHLon6cZUKi6buVW9Yf882SfT2RngkVD4Zo92ZI1HLCGVlAH0AzA6s0BcGM lWPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758927223; x=1759532023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L64jj/1bEf6Wb3tfKGPiM7Hcv1CIUMxOk206Ub6oLd8=; b=XMtet3R2aX4DVfFYXUR3TeJ+kq7HbUlRI0F+xZxwkRfE8YqXehD3aWUivDENwZXfQP 6ZErp8bIgiaZxMjSRIxvsnJTD188POnOUqbCf0WIUgsaQXc4yKQyLYq2iv3WRf35CdnG mbF36RebEMMFViA9333KrUL53VL28R7rN/z9jjYMHBsIPqhB8XvZm2sTB9sOzmZlmyxf p2OAg/FRYcz30CvK9dfuzBq1ZfWETVL6YXJZBzjjRpN6hwF6cunkMcC3j99BBADl/oyx QnjWp3lNtTDQlcE2WXtaifk09sRxGFuMqRduShP9nai/NUEJM1Wtqy9yluZ3EJsnWGH3 rrCg== X-Forwarded-Encrypted: i=1; AJvYcCUl+pKYDS8GHtFmsRkwCej54vIE9/xJCoQAGfuL6RC6d9vnE734E4tN0H9SlsLstiWkIYY=@vger.kernel.org X-Gm-Message-State: AOJu0YzqDMxTjUsn7r3vtNjnt9ePLFmnjwhDrCYd1d3sWv+gb4ab+4Tu GhRkcbGbpVG8NcFB54DhyAGcrHc0h5QM5o8gn/Gi4eT1umGddomKc90= X-Gm-Gg: ASbGncsmtCE/aFvrBYfR2vDBQWbcm87ZQavdBJoNpf8mYQLjAXwV/EHS8FAFEG6rZME RPvY0AoWWxJjS5a7jyoIntJCXS81GHal/zUZONb1/5BWqtzmkj5cwNLc4DsTAmAhs+6/PUmJ7/8 bhwKFahsSqJvA9Qr6TBeG6gY4Odcb2fMk8C3IHip1nkDMPUYyQZTvt839KnEUXuA8w0R+JQtdGZ zcOrNikdlCWR9ykUF+oMozIkzGp6klbnnojKkls1KubyzH8Pg+D+ZZLoqsPuGPeA2yMPz/FoXby PN0jySff8hVY65NM5V4/MQYE5Qd8KZbwNtop4Ho8HqzBvZMB7P1BJHIsQidBic6iLW0hpLy7gtS xAMI3HR3loQL26O/lvCEosvxDyOMqxE4bhOzmWM/fa+kHcubWSPyk4wKFtbJC7cbnAGKZf5d4fc fQZN5qcBSRUpktFJ0bFpLMfcFhPJcyGXNmc+mLeA7XsKObWvc2hDVYEcTtKtF60gFmRtalMyWt4 nNv830otxM4ayU= X-Google-Smtp-Source: AGHT+IHzUVqGkwRKGx9oX64k2CwdiQYFO+LB2LrVkfcj7y3QFUFaw1ssnQ7tqKDzQxD8YBaWVCcYfg== X-Received: by 2002:a05:6a00:2345:b0:77f:2e62:1e32 with SMTP id d2e1a72fcca58-780fce1f177mr9884757b3a.2.1758927222725; Fri, 26 Sep 2025 15:53:42 -0700 (PDT) Received: from localhost (c-73-158-218-242.hsd1.ca.comcast.net. [73.158.218.242]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-78102b22f5fsm5418527b3a.53.2025.09.26.15.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 15:53:42 -0700 (PDT) Date: Fri, 26 Sep 2025 15:53:41 -0700 From: Stanislav Fomichev To: Jesper Dangaard Brouer Cc: Lorenzo Bianconi , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Alexander Lobakin , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Maciej Fijalkowski , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC bpf-next v2 1/5] netlink: specs: Add XDP RX checksum capability to XDP metadata specs Message-ID: References: <20250925-bpf-xdp-meta-rxcksum-v2-0-6b3fe987ce91@kernel.org> <20250925-bpf-xdp-meta-rxcksum-v2-1-6b3fe987ce91@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 09/26, Jesper Dangaard Brouer wrote: > > > On 26/09/2025 06.20, Stanislav Fomichev wrote: > > On 09/25, Lorenzo Bianconi wrote: > > > Introduce XDP RX checksum capability to XDP metadata specs. XDP RX > > > checksum will be use by devices capable of exposing receive checksum > > > result via bpf_xdp_metadata_rx_checksum(). > > > Moreover, introduce xmo_rx_checksum netdev callback in order allow the > > > eBPF program bounded to the device to retrieve the RX checksum result > > > computed by the hw NIC. > > > > > > Signed-off-by: Lorenzo Bianconi > > > --- > > > Documentation/netlink/specs/netdev.yaml | 5 +++++ > > > include/net/xdp.h | 14 ++++++++++++++ > > > net/core/xdp.c | 29 +++++++++++++++++++++++++++++ > > > 3 files changed, 48 insertions(+) > > > > > > diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml > > > index e00d3fa1c152d7165e9485d6d383a2cc9cef7cfd..00699bf4a7fdb67c6b9ee3548098b0c933fd39a4 100644 > > > --- a/Documentation/netlink/specs/netdev.yaml > > > +++ b/Documentation/netlink/specs/netdev.yaml > > > @@ -61,6 +61,11 @@ definitions: > > > doc: | > > > Device is capable of exposing receive packet VLAN tag via > > > bpf_xdp_metadata_rx_vlan_tag(). > > > + - > > > + name: checksum > > > + doc: | > > > + Device is capable of exposing receive checksum result via > > > + bpf_xdp_metadata_rx_checksum(). > > > - > > > type: flags > > > name: xsk-flags > > > diff --git a/include/net/xdp.h b/include/net/xdp.h > > > index aa742f413c358575396530879af4570dc3fc18de..9ab9ac10ae2074b70618a9d4f32544d8b9a30b63 100644 > > > --- a/include/net/xdp.h > > > +++ b/include/net/xdp.h > > > @@ -586,6 +586,10 @@ void xdp_attachment_setup(struct xdp_attachment_info *info, > > > NETDEV_XDP_RX_METADATA_VLAN_TAG, \ > > > bpf_xdp_metadata_rx_vlan_tag, \ > > > xmo_rx_vlan_tag) \ > > > + XDP_METADATA_KFUNC(XDP_METADATA_KFUNC_RX_CHECKSUM, \ > > > + NETDEV_XDP_RX_METADATA_CHECKSUM, \ > > > + bpf_xdp_metadata_rx_checksum, \ > > > + xmo_rx_checksum) > > > enum xdp_rx_metadata { > > > #define XDP_METADATA_KFUNC(name, _, __, ___) name, > > > @@ -643,12 +647,22 @@ enum xdp_rss_hash_type { > > > XDP_RSS_TYPE_L4_IPV6_SCTP_EX = XDP_RSS_TYPE_L4_IPV6_SCTP | XDP_RSS_L3_DYNHDR, > > > }; > > > +enum xdp_checksum { > > > + XDP_CHECKSUM_NONE = CHECKSUM_NONE, > > > + XDP_CHECKSUM_UNNECESSARY = CHECKSUM_UNNECESSARY, > > > + XDP_CHECKSUM_COMPLETE = CHECKSUM_COMPLETE, > > > + XDP_CHECKSUM_PARTIAL = CHECKSUM_PARTIAL, > > > +}; > > > > Btw, might be worth mentioning, awhile ago we had settled on a smaller set of > > exposed types: > > > > https://lore.kernel.org/netdev/20230811161509.19722-13-larysa.zaremba@intel.com/ > > > > Maybe go through the previous postings and check if the arguments are > > still relevant? (or explain why we want more checksum now) > > IHMO the linked proposal reduced the types too much. IIRC, PARTIAL was removed because it's mostly (or only) a TX feature? So no real need to expose it as an rx hint. And I think empty xdp_csum_status in that proposal might have indicated NONE? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 976E4CAC5BB for ; Fri, 26 Sep 2025 22:53:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 410AD42392; Fri, 26 Sep 2025 22:53:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3gUsxDnKn6S6; Fri, 26 Sep 2025 22:53:46 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7310C4239C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1758927226; bh=L64jj/1bEf6Wb3tfKGPiM7Hcv1CIUMxOk206Ub6oLd8=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XRPn7UmDYNbtnFkQm0pRX9u8QQATK+A5eG2yQH38Bj5Dxlg9lpsecCqwWKvW849gt Bfcjye6RaAmTKxxp+Vb7RlK0p+uOFQPMlKQ9N4WOb5AEm3YTt6fQaf0XfW29gSlZPL ZiLiYNwk0XILtKOLUwc/0KrruRq6Pbf/6IlMkBdeKhI2pQ4Izl7Ojrthh4Mev6eLEz H5AXYYuxahatnxOo3KMLof4kf4TSwnlyS8y7vbw31UluchgNIo0Rac1fVZ1zHcI9UT y0QgTp+hza5NGqjzqNQ1dyymWd8xcQmyQtr5tTDItxkeDtACnMejARnrwLRbofHngx Ydcuqf7UUavUg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 7310C4239C; Fri, 26 Sep 2025 22:53:46 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id CBB1C198 for ; Fri, 26 Sep 2025 22:53:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B1A5941F5D for ; Fri, 26 Sep 2025 22:53:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KHMWqcuZNRbS for ; Fri, 26 Sep 2025 22:53:43 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::432; helo=mail-pf1-x432.google.com; envelope-from=stfomichev@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org BC9AD41F4C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BC9AD41F4C Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by smtp2.osuosl.org (Postfix) with ESMTPS id BC9AD41F4C for ; Fri, 26 Sep 2025 22:53:43 +0000 (UTC) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-77f169d8153so2745100b3a.3 for ; Fri, 26 Sep 2025 15:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758927223; x=1759532023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L64jj/1bEf6Wb3tfKGPiM7Hcv1CIUMxOk206Ub6oLd8=; b=XOEzL83WoJBkbSFFXzHS9RmqhhJRXJIZCLkrp0zV0OnLZKj7Rxk3bMyM4FAUpwokko c3HqgESyDemdmnMCzKJ7WC5q7i+sf16S3BELappXK3AaZO9rJZSRdznaxnK+9cY/tWRW 2MGfBGjilhU04djf9ROZD3JTMU3+PPf1mSI4E6BfkRh5E2ITRvZa2dR7TIVmVrvxsEeY wRsCEFrL4rTyDIn+gkPbOwUjLYcVkuB63UAVUToJQp4UiAYDUWqS4x/M0XW2cZUNuA+P dQ/z5kBIMfgsfvneVG/CYopENkeR5BYyUamx1YbgBETwCIlPOkL8eAFOS+9jN+nCEcKb kvgQ== X-Forwarded-Encrypted: i=1; AJvYcCWZUkngpttb7yoLMgERuYikh8Y7G8lXJQXbbWYKxz4Er+eVxMSmCx2QjiQ7U75qc0MjvSPB5HV9qJeTuyKqemw=@lists.osuosl.org X-Gm-Message-State: AOJu0Yy51myM806KTMHCKa75aVqs6HVXDwrl1A32H6bYUWBjtstlwBAy DYJ4DD096FtJeueU/ZnS5pb/4AIb3RD6raY2s43+sMzwnOIUxLXpSmw= X-Gm-Gg: ASbGncsRV22S0Pra0xLFVc+CudicIeD5q0thBh48N162IHVRc8d9xg0CFJSk/nfQbpU zt9u2L5G86gL6yHe7Cu1J7IozBW1Kty4g8C7MaQS/CahVr0V8cfnccCQ13652ktSoTO8HLo5ibw 0Al8dFMpugbEBKN2zx03/EzDKJpoUKt9RNJLnBzoO58xJV642kk5O4eu7C9TJx/nFUtx7Nm+3ZR IngW9WEqg0DxOeGfegO8IYo1sWi42GnRxPmdTUNCFpdFvYrEqDKW0z+ktHsEcgJD6ojrVhXyuu3 uRkIQ5Z6DGblugnxBvhBDh6lFvrJnU0nhY6Vy/syVMvajRa8jW4SjYXIF+VnI/GM6RBc804A0Rg wR0SxELUbOx58ltt/6A3me2Q0N2RIbmsc2FZfZaSOb0tQvbxp1L3kEodm/Srh1vNOOxFRla8Y0g 2Hj6kAGW/XPXASa5QG2j1vNS/UTH6u1Cc+dGBygrdzIwYQh6WJdabSHiv+7UaCsFT1Ei7QMMo0/ MnfN/8DcfrIlJ0= X-Google-Smtp-Source: AGHT+IHzUVqGkwRKGx9oX64k2CwdiQYFO+LB2LrVkfcj7y3QFUFaw1ssnQ7tqKDzQxD8YBaWVCcYfg== X-Received: by 2002:a05:6a00:2345:b0:77f:2e62:1e32 with SMTP id d2e1a72fcca58-780fce1f177mr9884757b3a.2.1758927222725; Fri, 26 Sep 2025 15:53:42 -0700 (PDT) Received: from localhost (c-73-158-218-242.hsd1.ca.comcast.net. [73.158.218.242]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-78102b22f5fsm5418527b3a.53.2025.09.26.15.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 15:53:42 -0700 (PDT) Date: Fri, 26 Sep 2025 15:53:41 -0700 From: Stanislav Fomichev To: Jesper Dangaard Brouer Cc: Lorenzo Bianconi , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Alexander Lobakin , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Maciej Fijalkowski , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org Message-ID: References: <20250925-bpf-xdp-meta-rxcksum-v2-0-6b3fe987ce91@kernel.org> <20250925-bpf-xdp-meta-rxcksum-v2-1-6b3fe987ce91@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758927223; x=1759532023; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L64jj/1bEf6Wb3tfKGPiM7Hcv1CIUMxOk206Ub6oLd8=; b=jZiROuuAFjtIg0YNNqg1MwD7HeFWgdeeCLufcaD0vppJIEfM+K9Gi0acmWsCdouO0G nsswwP9CIg5LEmHbHgjvX9GNKZEpTpbejzyk7K+teapvElHJ0Wynh2hHvjWFsaBg7DEo qr6tZl8RUAHVxbEl9mkQnuRx+kx65DOH1cfZ47NPrepXNbOGmjdbRZQ10UY49dfgjsSa xXCbBWTuTrbwGUh0p7wdwmhTblz72tIYjNEJK51btRU+QoQhL2cExEtU2+jgVQ33EJuh N+igp7xQCr9nG0xmg00j69l6dwZnsh2dQlJ4rT4huUMFjhlEhQs/Kkuq5cAQtrqKs7x8 ltig== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jZiROuuA Subject: Re: [Intel-wired-lan] [PATCH RFC bpf-next v2 1/5] netlink: specs: Add XDP RX checksum capability to XDP metadata specs X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 09/26, Jesper Dangaard Brouer wrote: > > > On 26/09/2025 06.20, Stanislav Fomichev wrote: > > On 09/25, Lorenzo Bianconi wrote: > > > Introduce XDP RX checksum capability to XDP metadata specs. XDP RX > > > checksum will be use by devices capable of exposing receive checksum > > > result via bpf_xdp_metadata_rx_checksum(). > > > Moreover, introduce xmo_rx_checksum netdev callback in order allow the > > > eBPF program bounded to the device to retrieve the RX checksum result > > > computed by the hw NIC. > > > > > > Signed-off-by: Lorenzo Bianconi > > > --- > > > Documentation/netlink/specs/netdev.yaml | 5 +++++ > > > include/net/xdp.h | 14 ++++++++++++++ > > > net/core/xdp.c | 29 +++++++++++++++++++++++++++++ > > > 3 files changed, 48 insertions(+) > > > > > > diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml > > > index e00d3fa1c152d7165e9485d6d383a2cc9cef7cfd..00699bf4a7fdb67c6b9ee3548098b0c933fd39a4 100644 > > > --- a/Documentation/netlink/specs/netdev.yaml > > > +++ b/Documentation/netlink/specs/netdev.yaml > > > @@ -61,6 +61,11 @@ definitions: > > > doc: | > > > Device is capable of exposing receive packet VLAN tag via > > > bpf_xdp_metadata_rx_vlan_tag(). > > > + - > > > + name: checksum > > > + doc: | > > > + Device is capable of exposing receive checksum result via > > > + bpf_xdp_metadata_rx_checksum(). > > > - > > > type: flags > > > name: xsk-flags > > > diff --git a/include/net/xdp.h b/include/net/xdp.h > > > index aa742f413c358575396530879af4570dc3fc18de..9ab9ac10ae2074b70618a9d4f32544d8b9a30b63 100644 > > > --- a/include/net/xdp.h > > > +++ b/include/net/xdp.h > > > @@ -586,6 +586,10 @@ void xdp_attachment_setup(struct xdp_attachment_info *info, > > > NETDEV_XDP_RX_METADATA_VLAN_TAG, \ > > > bpf_xdp_metadata_rx_vlan_tag, \ > > > xmo_rx_vlan_tag) \ > > > + XDP_METADATA_KFUNC(XDP_METADATA_KFUNC_RX_CHECKSUM, \ > > > + NETDEV_XDP_RX_METADATA_CHECKSUM, \ > > > + bpf_xdp_metadata_rx_checksum, \ > > > + xmo_rx_checksum) > > > enum xdp_rx_metadata { > > > #define XDP_METADATA_KFUNC(name, _, __, ___) name, > > > @@ -643,12 +647,22 @@ enum xdp_rss_hash_type { > > > XDP_RSS_TYPE_L4_IPV6_SCTP_EX = XDP_RSS_TYPE_L4_IPV6_SCTP | XDP_RSS_L3_DYNHDR, > > > }; > > > +enum xdp_checksum { > > > + XDP_CHECKSUM_NONE = CHECKSUM_NONE, > > > + XDP_CHECKSUM_UNNECESSARY = CHECKSUM_UNNECESSARY, > > > + XDP_CHECKSUM_COMPLETE = CHECKSUM_COMPLETE, > > > + XDP_CHECKSUM_PARTIAL = CHECKSUM_PARTIAL, > > > +}; > > > > Btw, might be worth mentioning, awhile ago we had settled on a smaller set of > > exposed types: > > > > https://lore.kernel.org/netdev/20230811161509.19722-13-larysa.zaremba@intel.com/ > > > > Maybe go through the previous postings and check if the arguments are > > still relevant? (or explain why we want more checksum now) > > IHMO the linked proposal reduced the types too much. IIRC, PARTIAL was removed because it's mostly (or only) a TX feature? So no real need to expose it as an rx hint. And I think empty xdp_csum_status in that proposal might have indicated NONE?