From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FA1CAC5BB for ; Sun, 28 Sep 2025 19:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZTBpTbiPYx8x9iTdKBMqqY290J7Ji6nmNpJIHBDlIDA=; b=YdMvj0BZV5omRaGxRyWMg3h30p zMhz9RiW87SFSO6bci0vvJBJkxeAyRv/hfZhGRlhXn+ADfMN1Oy+rPOadlryjrYtmd9aseKQTTCZ+ iUb62R0tf9/+bVmmhlcwwRzbLewP5v1KY2nw4tCMi4s1y0/m1ikmmTRPsXZ4mMyMNCUI=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v2xXy-0006bM-AW; Sun, 28 Sep 2025 19:59:02 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v2xXw-0006b7-5F for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Sep 2025 19:59:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IvsXNpcgXrV7DDP8t04BMX6mIwewQRhlCvE2VhgDWNg=; b=Thtc/a3bAaB+T1EpsyvfyQ9O4b Ip7kRC4daQq+ylC6v4oEmPeCOFM7lTWyvALcc9w8FvRAHM4W7F5Z3JV6YmVRl5EHazLq7sjB9CY1U OZAbW3xrA/yrxxDXl4ea6apG750NSh1e8Yfv5VnM4n3tIi8Ufeoc8/od31iPfm2BzxGg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IvsXNpcgXrV7DDP8t04BMX6mIwewQRhlCvE2VhgDWNg=; b=cR4qzu04G/7JZGz6ozujlzQ80N qp7ujLXv673BSfflis+Uqy5l2qa6olxySEjqn/rVVR5efwKpWhDaEvPmDMPPdH+K7uN7qWsYu1bUx n5CTboCWrN9Bmgm6gNSLaSrGPgf6YFMI9RRzYCC/Hufe5xSG9+2JdhseNjGse1Rri2l4=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v2xXv-0007Kv-PZ for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Sep 2025 19:59:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 094FF621C9; Sun, 28 Sep 2025 19:58:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76430C4CEF0; Sun, 28 Sep 2025 19:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759089533; bh=BSaNDAJ2DXajilDe8utcY5o/kSH59Yaye0rmVkRFg58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qt48dHd73hR8qF0yh1mbzrZSmoewZpeuZPnrWBLTLsFCYQpZAbxRiDujDVqg9MEgQ LUobkOYPI9359vDSTv2L0OrwmaUFqzTQdFb6hC8/v4D/MOQBFXGfKgVxIiCZYfoqKB nmQWlvt1id9J+6D8snN3NprwoK6x7IGBoM9byxgFfPSDLEXgJz/3QvhwTwbuWayiCm yu/TsDq8UCoHhG9sczkk4INEHHfXyLI18CZjTbnQM8kzQMTamKsgs7+qGOHcckL+lz FIDr+OrLO+wF5u+hKvBGYKp6QNyA7EJTKluVP6hZLebBivWUuwcrnE1enVrR7NPVSL JTGHIA6vYUo5g== Date: Sun, 28 Sep 2025 19:58:51 +0000 To: Daeho Jeong Message-ID: References: <20250924185423.1305104-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250924185423.1305104-1-daeho43@gmail.com> X-Headers-End: 1v2xXv-0007Kv-PZ Subject: Re: [f2fs-dev] [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 09/24, Daeho Jeong wrote: > From: Daeho Jeong > > total_valid_blks_available is already a multiple of c.blks_per_seg. > So, we don't need an additional alignment adjustment. Can we add ASSERT? > > Signed-off-by: Daeho Jeong > --- > mkfs/f2fs_format.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > index b98976c..55a7505 100644 > --- a/mkfs/f2fs_format.c > +++ b/mkfs/f2fs_format.c > @@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void) > if (c.feature & F2FS_FEATURE_RO) > blocks_for_ssa = 0; > else > - blocks_for_ssa = total_valid_blks_available / > - c.blks_per_seg + 1; > + blocks_for_ssa = total_valid_blks_available / c.blks_per_seg; > > set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa)); > > -- > 2.51.0.536.g15c5d4f767-goog > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B24C34BA3B for ; Sun, 28 Sep 2025 19:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759089534; cv=none; b=I4mfRHx186oNqSZxetY7bIC+Laba7Eyct66H3zm08sTJzQ0q54z4mwq3Mm/X+fkf/faEYSz7WQzvpYKNGhro8Txz4doQcALgDmhj4B/54yc91xfF+vGYs6Bj7/3B5Fq/muxgF+c8ipcIHxeevCn64BdVHYIT8lWWRoGOHvP2oFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759089534; c=relaxed/simple; bh=BSaNDAJ2DXajilDe8utcY5o/kSH59Yaye0rmVkRFg58=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o+KY2MKquza5yyChXJNx54wy6aRVrUvidEyzhPxTpeqONie8NzOwbwtGIC3sdoYflssTY/jSTO4Fy7b9BlI+JGEwFVN21Awmscxaa1XZBr0Ld+cjt9OSnoOk8l66ZGn2w2gFoYLkVUknahVrHadL2ZQ0moHYHHOTT+KshRRPLH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qt48dHd7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qt48dHd7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76430C4CEF0; Sun, 28 Sep 2025 19:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759089533; bh=BSaNDAJ2DXajilDe8utcY5o/kSH59Yaye0rmVkRFg58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qt48dHd73hR8qF0yh1mbzrZSmoewZpeuZPnrWBLTLsFCYQpZAbxRiDujDVqg9MEgQ LUobkOYPI9359vDSTv2L0OrwmaUFqzTQdFb6hC8/v4D/MOQBFXGfKgVxIiCZYfoqKB nmQWlvt1id9J+6D8snN3NprwoK6x7IGBoM9byxgFfPSDLEXgJz/3QvhwTwbuWayiCm yu/TsDq8UCoHhG9sczkk4INEHHfXyLI18CZjTbnQM8kzQMTamKsgs7+qGOHcckL+lz FIDr+OrLO+wF5u+hKvBGYKp6QNyA7EJTKluVP6hZLebBivWUuwcrnE1enVrR7NPVSL JTGHIA6vYUo5g== Date: Sun, 28 Sep 2025 19:58:51 +0000 From: Jaegeuk Kim To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa Message-ID: References: <20250924185423.1305104-1-daeho43@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250924185423.1305104-1-daeho43@gmail.com> On 09/24, Daeho Jeong wrote: > From: Daeho Jeong > > total_valid_blks_available is already a multiple of c.blks_per_seg. > So, we don't need an additional alignment adjustment. Can we add ASSERT? > > Signed-off-by: Daeho Jeong > --- > mkfs/f2fs_format.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > index b98976c..55a7505 100644 > --- a/mkfs/f2fs_format.c > +++ b/mkfs/f2fs_format.c > @@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void) > if (c.feature & F2FS_FEATURE_RO) > blocks_for_ssa = 0; > else > - blocks_for_ssa = total_valid_blks_available / > - c.blks_per_seg + 1; > + blocks_for_ssa = total_valid_blks_available / c.blks_per_seg; > > set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa)); > > -- > 2.51.0.536.g15c5d4f767-goog >