From: Simon Horman <horms@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: Askar Safin <safinaskar@zohomail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
kexec@lists.infradead.org
Subject: Re: [PATCH v4 0/6] Fix printf string specifiers, otherwise kexec doesn't work on my laptop
Date: Mon, 29 Sep 2025 10:50:46 +0100 [thread overview]
Message-ID: <aNpWdp8jCMYaRYqh@horms.kernel.org> (raw)
In-Reply-To: <a28436ba-e040-42cf-82e5-52ff5cb144ce@arm.com>
On Fri, Sep 26, 2025 at 04:09:17PM -0500, Jeremy Linton wrote:
> Hi,
>
>
> First, thanks for fixing this!
>
> So, I've been trying to find a failure beyond the printouts being wrong for
> the past couple days, and largely failed to duplicate a functional issue.
>
> That said, this does fix a couple printouts I checked on 32-bit 686 debian
> 12. Generally I think the code is ok as well and have reviewed it but i'm
> going to withhold the review by tag because I still think the commit
> messages could use some cleanup.
>
>
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
Thanks, and sorry to everyone for the extended delay on this one.
I've applied these patches for inclusion in the next release.
- kexec/arch/arm64/crashdump-arm64.c: remove extra whitespace
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=2842172e1405
- kexec/arch/i386/kexec-x86-common.c: remove duplicate <stdio.h>
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=c343815e7e0a
- util_lib/elf_info.c: fix typo: prink -> printk
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=b7b2a13547a0
- kexec/arch/i386/x86-linux-setup.c: replace %d with %u
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=9c12e71d712a
- kexec/kexec-elf-exec.c: Replace %lux with %lx
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=c837f1971fab
- Fix printf string specifiers, otherwise kexec doesn't work on my laptop
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=288e352ed7c8
prev parent reply other threads:[~2025-09-29 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 21:30 [PATCH v4 0/6] Fix printf string specifiers, otherwise kexec doesn't work on my laptop Askar Safin
2025-08-19 21:30 ` [PATCH v4 1/6] " Askar Safin
2025-08-19 21:30 ` [PATCH v4 2/6] kexec/kexec-elf-exec.c: Replace %lux with %lx Askar Safin
2025-08-19 21:30 ` [PATCH v4 3/6] kexec/arch/i386/x86-linux-setup.c: replace %d with %u Askar Safin
2025-08-19 21:30 ` [PATCH v4 4/6] util_lib/elf_info.c: fix typo: prink -> printk Askar Safin
2025-08-19 21:30 ` [PATCH v4 5/6] kexec/arch/i386/kexec-x86-common.c: remove duplicate <stdio.h> Askar Safin
2025-08-19 21:30 ` [PATCH v4 6/6] kexec/arch/arm64/crashdump-arm64.c: remove extra whitespace Askar Safin
2025-09-22 18:31 ` [PATCH v4 0/6] Fix printf string specifiers, otherwise kexec doesn't work on my laptop Askar Safin
2025-09-23 2:15 ` Baoquan He
2025-09-23 13:56 ` Simon Horman
2025-09-26 21:09 ` Jeremy Linton
2025-09-29 9:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNpWdp8jCMYaRYqh@horms.kernel.org \
--to=horms@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=kexec@lists.infradead.org \
--cc=safinaskar@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.