Re: [PATCH 2/2] migration/vmstate: remove VMSTATE_BUFFER_POINTER_UNSAFE macro

[Peter Xu <peterx@redhat.com>]

On Sat, Aug 02, 2025 at 05:21:09PM +0300, Michael Tokarev wrote:
> The only user of this macro was VirtIONet.vlans, which has been
> converted to regular VMSTATE_BUFFER.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  include/migration/vmstate.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 1ff7bd9ac4..ec0946c2aa 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -702,15 +702,6 @@ extern const VMStateInfo vmstate_info_qlist;
>      .offset     = offsetof(_state, _field),                          \
>  }
>  
> -#define VMSTATE_BUFFER_POINTER_UNSAFE(_field, _state, _version, _size) { \
> -    .name       = (stringify(_field)),                               \
> -    .version_id = (_version),                                        \
> -    .size       = (_size),                                           \
> -    .info       = &vmstate_info_buffer,                              \
> -    .flags      = VMS_BUFFER|VMS_POINTER,                            \
> -    .offset     = offsetof(_state, _field),                          \
> -}
> -
>  /* Allocate a temporary of type 'tmp_type', set tmp->parent to _state
>   * and execute the vmsd on the temporary.  Note that we're working with
>   * the whole of _state here, not a field within it.
> -- 
> 2.47.2
> 

I'm scanning over lost patches on the list.  I suspect this is lost when
you sent v2 replying to v1.

Wanna repost with a full v2 to catch Michael's attention once more?  I also
always would suggest a cover letter..

Thanks,

-- 
Peter Xu