All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: "Zhou, Yun" <yun.zhou@windriver.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, dianders@chromium.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: fix slab-use-after-free when clk_core_populate_parent_map failed
Date: Tue, 30 Sep 2025 06:22:58 -0400	[thread overview]
Message-ID: <aNuvghjOrY7nSviZ@redhat.com> (raw)
In-Reply-To: <a77dc81a-e8fa-4f9e-8915-3b8f352c114c@windriver.com>

Hi Yun,

On Tue, Sep 30, 2025 at 12:59:14PM +0800, Zhou, Yun wrote:
> Hi Brian,
> 
> Thanks for your review.
> 
> This defect is caused by multiple reasons, but as you said, the fixes tag is
> not accurate enough.
> 
> I think it should be:
> 
> Fixes: fc0c209c1 ("clk: Allow parents to be specified without string names")
> 
> Do you think so?

Yes, that's what I would make it. With that fixed in a v2, you can add:

Reviewed-by: Brian Masney <bmasney@redhat.com>

Also, just a heads up to not top post, and to reply inline next time.

https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying

Brian


  reply	other threads:[~2025-09-30 10:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29  8:31 [PATCH] clk: fix slab-use-after-free when clk_core_populate_parent_map failed Yun Zhou
2025-09-29 19:54 ` Brian Masney
2025-09-30  4:59   ` Zhou, Yun
2025-09-30 10:22     ` Brian Masney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-25  5:23 Yun Zhou
2025-05-14  1:34 ` Yun Zhou
2025-06-17  2:11 ` Yun Zhou
2025-04-09  8:32 Yun Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNuvghjOrY7nSviZ@redhat.com \
    --to=bmasney@redhat.com \
    --cc=dianders@chromium.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=yun.zhou@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.