From: Peter Xu <peterx@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: Steven Sistare <steven.sistare@oracle.com>,
qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH V4 5/8] migration: cpr-exec save and load
Date: Tue, 30 Sep 2025 12:19:38 -0400 [thread overview]
Message-ID: <aNwDGpxZMFWj-ELW@x1.local> (raw)
In-Reply-To: <6d5b95e4-1d50-4b70-8d40-9031f3735d56@redhat.com>
On Thu, Sep 25, 2025 at 09:11:33AM +0200, Cédric Le Goater wrote:
> > > That's a short term hack right ? it's not even documented.
> >
> > It is an implementation detail, known only to the matched saving
> > and loading functions inside qemu. No one else needs to know, so
> > no documentation.
>
> ok. Fair enough.
IMHO Cedric's ask is fair. At least when people reading the doc may get
confused of why cpr channel isn't needed for the exec mode in its API.
Could we still add one liner into the doc to describe it? Something that
would mention a temp memfd and passing it over using environment vars would
help.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2025-09-30 16:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 13:49 [PATCH V4 0/8] Live update: cpr-exec Steve Sistare
2025-09-22 13:49 ` [PATCH V4 1/8] migration: multi-mode notifier Steve Sistare
2025-09-22 15:18 ` Cédric Le Goater
2025-09-24 18:15 ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 2/8] migration: add cpr_walk_fd Steve Sistare
2025-09-22 13:49 ` [PATCH V4 3/8] oslib: qemu_clear_cloexec Steve Sistare
2025-09-22 13:49 ` [PATCH V4 4/8] migration: cpr-exec-command parameter Steve Sistare
2025-09-22 13:49 ` [PATCH V4 5/8] migration: cpr-exec save and load Steve Sistare
2025-09-22 16:00 ` Cédric Le Goater
2025-09-24 18:16 ` Steven Sistare
2025-09-25 7:11 ` Cédric Le Goater
2025-09-25 20:38 ` Steven Sistare
2025-09-30 16:19 ` Peter Xu [this message]
2025-09-30 16:39 ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 6/8] migration: cpr-exec mode Steve Sistare
2025-09-22 15:28 ` Cédric Le Goater
2025-09-24 18:16 ` Steven Sistare
2025-09-25 7:12 ` Cédric Le Goater
2025-09-30 16:39 ` Peter Xu
2025-09-30 17:18 ` Steven Sistare
2025-09-30 18:20 ` Peter Xu
2025-09-30 18:29 ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 7/8] migration: cpr-exec docs Steve Sistare
2025-09-22 13:49 ` [PATCH V4 8/8] vfio: cpr-exec mode Steve Sistare
2025-09-22 15:28 ` Cédric Le Goater
2025-09-30 15:28 ` [PATCH V4 0/8] Live update: cpr-exec Steven Sistare
2025-09-30 16:42 ` Peter Xu
2025-09-30 16:52 ` Steven Sistare
2025-09-30 19:49 ` Steven Sistare
2025-09-30 20:40 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNwDGpxZMFWj-ELW@x1.local \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=clg@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.