[Alexey Gladkov <legion@kernel.org>]

Bcc: 
Subject: Re: Patch "s390: vmlinux.lds.S: Reorder sections" has been added to
 the 6.17-stable tree
Reply-To: 
In-Reply-To: <20251015114101.1339594-1-sashal@kernel.org>

On Wed, Oct 15, 2025 at 07:41:01AM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     s390: vmlinux.lds.S: Reorder sections
> 
> to the 6.17-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      s390-vmlinux.lds.s-reorder-sections.patch
> and it can be found in the queue-6.17 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 

If you take this commit, then I think this commit is also needed:

https://lore.kernel.org/all/20251008-kbuild-fix-modinfo-regressions-v1-3-9fc776c5887c@kernel.org/

> 
> commit 106cf24aac7413e5fb6aa632707ff81451a202c1
> Author: Alexey Gladkov <legion@kernel.org>
> Date:   Thu Sep 18 10:05:45 2025 +0200
> 
>     s390: vmlinux.lds.S: Reorder sections
>     
>     [ Upstream commit 8d18ef04f940a8d336fe7915b5ea419c3eb0c0a6 ]
>     
>     In the upcoming changes, the ELF_DETAILS macro will be extended with
>     the ".modinfo" section, which will cause an error:
>     
>     >> s390x-linux-ld: .tmp_vmlinux1: warning: allocated section `.modinfo' not in segment
>     >> s390x-linux-ld: .tmp_vmlinux2: warning: allocated section `.modinfo' not in segment
>     >> s390x-linux-ld: vmlinux.unstripped: warning: allocated section `.modinfo' not in segment
>     
>     This happens because the .vmlinux.info use :NONE to override the default
>     segment and tell the linker to not put the section in any segment at all.
>     
>     To avoid this, we need to change the sections order that will be placed
>     in the default segment.
>     
>     Cc: Heiko Carstens <hca@linux.ibm.com>
>     Cc: Vasily Gorbik <gor@linux.ibm.com>
>     Cc: Alexander Gordeev <agordeev@linux.ibm.com>
>     Cc: linux-s390@vger.kernel.org
>     Reported-by: kernel test robot <lkp@intel.com>
>     Closes: https://lore.kernel.org/oe-kbuild-all/202506062053.zbkFBEnJ-lkp@intel.com/
>     Signed-off-by: Alexey Gladkov <legion@kernel.org>
>     Acked-by: Heiko Carstens <hca@linux.ibm.com>
>     Link: https://patch.msgid.link/20d40a7a3a053ba06a54155e777dcde7fdada1db.1758182101.git.legion@kernel.org
>     Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>     Stable-dep-of: 9338d660b79a ("s390/vmlinux.lds.S: Move .vmlinux.info to end of allocatable sections")
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
> index 1c606dfa595d8..feecf1a6ddb44 100644
> --- a/arch/s390/kernel/vmlinux.lds.S
> +++ b/arch/s390/kernel/vmlinux.lds.S
> @@ -209,6 +209,11 @@ SECTIONS
>  	. = ALIGN(PAGE_SIZE);
>  	_end = . ;
>  
> +	/* Debugging sections.	*/
> +	STABS_DEBUG
> +	DWARF_DEBUG
> +	ELF_DETAILS
> +
>  	/*
>  	 * uncompressed image info used by the decompressor
>  	 * it should match struct vmlinux_info
> @@ -239,11 +244,6 @@ SECTIONS
>  #endif
>  	} :NONE
>  
> -	/* Debugging sections.	*/
> -	STABS_DEBUG
> -	DWARF_DEBUG
> -	ELF_DETAILS
> -
>  	/*
>  	 * Make sure that the .got.plt is either completely empty or it
>  	 * contains only the three reserved double words.
> 

-- 
Rgrds, legion