From: Keith Busch <kbusch@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Leon Romanovsky <leonro@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 3/4] block-dma: properly take MMIO path
Date: Mon, 13 Oct 2025 13:01:18 -0600 [thread overview]
Message-ID: <aO1MfsuWeteOsBve@kbusch-mbp> (raw)
In-Reply-To: <cf4f6dfee380351e68932d4d114422364097dda5.1760369219.git.leon@kernel.org>
On Mon, Oct 13, 2025 at 06:34:11PM +0300, Leon Romanovsky wrote:
> static bool blk_dma_map_direct(struct request *req, struct device *dma_dev,
> struct blk_dma_iter *iter, struct phys_vec *vec)
> {
> + unsigned int attrs = 0;
> +
> + if (req->cmd_flags & REQ_MMIO)
> + attrs |= DMA_ATTR_MMIO;
Since data and integrity paylods use these same functions and may point
to different kinds of memory, I think you'd have to pass the 'attrs'
from the caller since it knows which flags to check for MMIO dma.
next prev parent reply other threads:[~2025-10-13 19:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 15:34 [PATCH 0/4] Properly take MMIO path Leon Romanovsky
2025-10-13 15:34 ` [PATCH 1/4] blk-mq-dma: migrate to dma_map_phys instead of map_page Leon Romanovsky
2025-10-15 4:16 ` Christoph Hellwig
2025-10-13 15:34 ` [PATCH 2/4] blk-mq-dma: unify DMA unmap routine Leon Romanovsky
2025-10-13 18:53 ` Keith Busch
2025-10-13 19:35 ` Leon Romanovsky
2025-10-13 15:34 ` [PATCH 3/4] block-dma: properly take MMIO path Leon Romanovsky
2025-10-13 19:01 ` Keith Busch [this message]
2025-10-13 19:29 ` Leon Romanovsky
2025-10-13 19:34 ` Keith Busch
2025-10-15 4:18 ` Christoph Hellwig
2025-10-13 15:34 ` [PATCH 4/4] nvme-pci: unmap MMIO pages with appropriate interface Leon Romanovsky
2025-10-15 4:20 ` Christoph Hellwig
2025-10-15 6:44 ` Leon Romanovsky
2025-10-14 11:26 ` [PATCH 0/4] Properly take MMIO path shinichiro.kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO1MfsuWeteOsBve@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.