Re: [PATCH 2/2] monitor: generalize query-mshv/"info mshv" to query-accelerators/"info accelerators"

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Oct 13, 2025 at 01:26:50PM +0200, Paolo Bonzini wrote:
> The recently-introduced query-mshv command is a duplicate of query-kvm,
> and neither provides a full view of which accelerators are supported
> by a particular binary of QEMU and which is in use.
> 
> KVM was the first accelerator added to QEMU, predating QOM and TYPE_ACCEL,
> so it got a pass.  But now, instead of adding a badly designed copy, solve
> the problem completely for all accelerators with a command that provides
> the whole picture:
> 
>     >> {"execute": "query-accelerators"}
>     << {"return": {"enabled": "tcg", "present": ["kvm", "mshv", "qtest", "tcg", "xen"]}}
> 
> Cc: Praveen K Paladugu <prapal@microsoft.com>
> Cc: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
>  fixup a0df118f73f # fff
> ---
>  qapi/accelerator.json      | 47 +++++++++++++++++++++++++++++---------
>  include/monitor/hmp.h      |  2 +-
>  hw/core/machine-hmp-cmds.c | 21 +++++++++--------
>  hw/core/machine-qmp-cmds.c | 20 ++++++++++++----
>  hmp-commands-info.hx       | 15 ++++++++----
>  5 files changed, 74 insertions(+), 31 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|