From: Simon Horman <horms@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
kernel@pengutronix.de,
Dent Project <dentproject@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: pse-pd: pd692x0: Preserve PSE configuration across reboots
Date: Tue, 14 Oct 2025 09:58:56 +0100 [thread overview]
Message-ID: <aO4Q0HIZ_72fwRI2@horms.kernel.org> (raw)
In-Reply-To: <20251013-feature_pd692x0_reboot_keep_conf-v2-3-68ab082a93dd@bootlin.com>
On Mon, Oct 13, 2025 at 04:05:33PM +0200, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
> Detect when PSE hardware is already configured (user byte == 42) and
> skip hardware initialization to prevent power interruption to connected
> devices during system reboots.
>
> Previously, the driver would always reconfigure the PSE hardware on
> probe, causing a port matrix reflash that resulted in temporary power
> loss to all connected devices. This change maintains power continuity
> by preserving existing configuration when the PSE has been previously
> initialized.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Hi Kory,
Perhaps I'm over thinking things here. But I'm wondering
what provision there is for a situation whereby:
1. The driver configures the device
2. A reboot occurs
2. The (updated) driver wants to (re)configure the device
with a different configuration, say because it turns
out there was a bug in or enhancement to the procedure at 1.
...
next prev parent reply other threads:[~2025-10-14 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 14:05 [PATCH net-next v2 0/3] Preserve PSE PD692x0 configuration across reboots Kory Maincent
2025-10-13 14:05 ` [PATCH net-next v2 1/3] net: pse-pd: pd692x0: Replace __free macro with explicit kfree calls Kory Maincent
2025-10-14 9:01 ` Simon Horman
2025-10-13 14:05 ` [PATCH net-next v2 2/3] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Kory Maincent
2025-10-14 9:02 ` Simon Horman
2025-10-13 14:05 ` [PATCH net-next v2 3/3] net: pse-pd: pd692x0: Preserve PSE configuration across reboots Kory Maincent
2025-10-14 8:58 ` Simon Horman [this message]
2025-10-14 9:56 ` Kory Maincent
2025-10-14 14:06 ` Simon Horman
2025-10-16 1:00 ` [PATCH net-next v2 0/3] Preserve PSE PD692x0 " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO4Q0HIZ_72fwRI2@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.