From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47B27CCD187 for ; Tue, 14 Oct 2025 09:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XzuGP1YdFyCm6SkVxpassnV1eKAfR0T64PyP/H6gc3M=; b=Hq5f17f0/lATGL ZTpMLpAIAg5n4m/nq0YqKngw4JLZTQoMLEyxsOpYyWU4sGeLPYtBedjyR0uOdgZLlwIkBDw96O1cR oZ1pWRJpJyItv0VyNhuiY5sPvdMPfHnD+k9vp+2ASsuTiBbQ8ilgYBXG0S3F45OHtPPimHT8gRi0i ap79nnqI3uV39cZAewmlBnppnXzHnpiCaRwn2/J0cwFms7lbpokZy6s/3GOOtpa/xRBrOmvIt0y10 +knT0zpsHtYEgRpTQiG9aaidPX0vp7lbs8J2gM/LyqkXQCPMSSAQogNWie1p/rRtFlKnAsB336nW8 L4+YPjVf/w/k+JIAnNzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8bew-0000000Foxq-1X59; Tue, 14 Oct 2025 09:49:34 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8bes-0000000Fowi-3qcz for linux-riscv@lists.infradead.org; Tue, 14 Oct 2025 09:49:32 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D255B260A3; Tue, 14 Oct 2025 11:49:27 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uovdA5KCQ9Xb; Tue, 14 Oct 2025 11:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1760435367; bh=8ZOdtFHoqv/rQpLoY48GmoTDS5BQalfi24BFCB1h7e4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IoHj+x5WYyeUqFeY+0WSwUtV5j8UHcGZo6LEs5W+hwoGC8uuZhp3dqgnQs2N23dSR vAtVe/CXt9eIFI/iXJPEcUr8gc3vKjAe6+rDfM1cozhLQJoQ4njt0rikI8x6zLGtkc svTX++7yslNag10zmvUIAhuwOcfl/zx39XP+sjOz77BxufupbSqSOllbkYksU3/t/7 sXTz1yZMcGXOR3oTHAX4YDLL7eaPdJezuq/TfvZklX6i7Sy6R9rmlK5SGIu62ZXTv/ 3gHGdJzzGAgPo8AhbEzKMmyGE+xnpmjCY2b+sOrKVTyyeDAK811upWwuYn+maSxbb3 c3hWa5dzGRQPQ== Date: Tue, 14 Oct 2025 09:49:07 +0000 From: Yao Zi To: Drew Fustini Cc: Rob Herring , Conor Dooley , Albert Ou , Michal Wilczynski , Alexandre Ghiti , devicetree@vger.kernel.org, Han Gao , Han Gao , linux-kernel@vger.kernel.org, Guo Ren , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Fu Wei Subject: Re: [PATCH v2 2/5] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Message-ID: References: <20250915095331.53350-1-ziyao@disroot.org> <20250915095331.53350-3-ziyao@disroot.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251014_024931_546415_05692A5A X-CRM114-Status: GOOD ( 30.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBPY3QgMDQsIDIwMjUgYXQgMDM6MTU6NDVQTSAtMDcwMCwgRHJldyBGdXN0aW5pIHdy b3RlOgo+IE9uIFNhdCwgT2N0IDA0LCAyMDI1IGF0IDAyOjIxOjQzQU0gKzAwMDAsIFlhbyBaaSB3 cm90ZToKPiA+IE9uIEZyaSwgT2N0IDAzLCAyMDI1IGF0IDAzOjQ2OjE3UE0gLTA3MDAsIERyZXcg RnVzdGluaSB3cm90ZToKPiA+ID4gT24gTW9uLCBTZXAgMTUsIDIwMjUgYXQgMDk6NTM6MjhBTSAr MDAwMCwgWWFvIFppIHdyb3RlOgo+ID4gPiA+IFRIMTUyMCBTb0MgaXMgZGl2aWRlZCBpbnRvIHNl dmVyYWwgc3Vic3lzdGVtcywgbW9zdCBvZiB0aGVtIGhhdmUKPiA+ID4gPiBkaXN0aW5jdCByZXNl dCBjb250cm9sbGVycy4gTGV0J3MgZG9jdW1lbnQgcmVzZXQgY29udHJvbGxlcnMgb3RoZXIgdGhh bgo+ID4gPiA+IHRoZSBvbmUgZm9yIFZPIHN1YnN5c3RlbSBhbmQgSURzIGZvciB0aGVpciByZXNl dCBzaWduYWxzLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFlhbyBaaSA8eml5YW9A ZGlzcm9vdC5vcmc+Cj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIHNlbmRpbmcgdGhlc2UgcGF0Y2hl cy4KPiA+ID4gCj4gPiA+ID4gLS0tCj4gPiA+ID4gIC4uLi9iaW5kaW5ncy9yZXNldC90aGVhZCx0 aDE1MjAtcmVzZXQueWFtbCAgICB8ICAgOCArLQo+ID4gPiA+ICAuLi4vZHQtYmluZGluZ3MvcmVz ZXQvdGhlYWQsdGgxNTIwLXJlc2V0LmggICAgfCAyMTYgKysrKysrKysrKysrKysrKysrCj4gPiA+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgMjIzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ ID4gPiAKPiA+ID4gW3NuaXBdCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHQtYmluZGlu Z3MvcmVzZXQvdGhlYWQsdGgxNTIwLXJlc2V0LmggYi9pbmNsdWRlL2R0LWJpbmRpbmdzL3Jlc2V0 L3RoZWFkLHRoMTUyMC1yZXNldC5oCj4gPiA+ID4gaW5kZXggZTUxZDYzMTRkMTMxLi42OGFjNTJl ZDY5ZGUgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvaW5jbHVkZS9kdC1iaW5kaW5ncy9yZXNldC90aGVh ZCx0aDE1MjAtcmVzZXQuaAo+ID4gPiA+ICsrKyBiL2luY2x1ZGUvZHQtYmluZGluZ3MvcmVzZXQv dGhlYWQsdGgxNTIwLXJlc2V0LmgKPiA+ID4gPiBAQCAtNyw2ICs3LDIwMCBAQAo+ID4gPiA+ICAj aWZuZGVmIF9EVF9CSU5ESU5HU19USDE1MjBfUkVTRVRfSAo+ID4gPiA+ICAjZGVmaW5lIF9EVF9C SU5ESU5HU19USDE1MjBfUkVTRVRfSAo+ID4gPiBbc25pcF0KPiA+ID4gPiArLyogRFNQIFN1YnN5 c3RlbSAqLwo+ID4gPiA+ICsjZGVmaW5lIFRIMTUyMF9SRVNFVF9JRF9YMlhfRFNQMQkwCj4gPiA+ ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lEX1gyWF9EU1AwCTEKPiA+ID4gPiArI2RlZmluZSBU SDE1MjBfUkVTRVRfSURfWDJYX1NMQVZFX0RTUDEJMgo+ID4gPiA+ICsjZGVmaW5lIFRIMTUyMF9S RVNFVF9JRF9YMlhfU0xBVkVfRFNQMAkzCj4gPiA+ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lE X0RTUDBfQ09SRQk0Cj4gPiA+ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lEX0RTUDBfREVCVUcJ NQo+ID4gPiA+ICsjZGVmaW5lIFRIMTUyMF9SRVNFVF9JRF9EU1AwX0FQQgk2Cj4gPiA+ID4gKyNk ZWZpbmUgVEgxNTIwX1JFU0VUX0lEX0RTUDFfQ09SRQk0Cj4gPiA+ID4gKyNkZWZpbmUgVEgxNTIw X1JFU0VUX0lEX0RTUDFfREVCVUcJNQo+ID4gPiA+ICsjZGVmaW5lIFRIMTUyMF9SRVNFVF9JRF9E U1AxX0FQQgk2Cj4gPiA+ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lEX0RTUFNZU19BUEIJNwo+ ID4gPiA+ICsjZGVmaW5lIFRIMTUyMF9SRVNFVF9JRF9BWEk0X0RTUFNZU19TTFYJOAo+ID4gPiA+ ICsjZGVmaW5lIFRIMTUyMF9SRVNFVF9JRF9BWEk0X0RTUFNZUwk5Cj4gPiA+ID4gKyNkZWZpbmUg VEgxNTIwX1JFU0VUX0lEX0FYSTRfRFNQX1JTCTEwCj4gPiA+IAo+ID4gPiBUaGlzIGRvZXNuJ3Qg c2VlbSByaWdodC4gVGhlIG51bWJlcnMgZm9yIGVhY2ggc3Vic3lzdGVtIHNob3VsZCBub3QKPiA+ ID4gcmVwZWF0LiBIZXJlIHRoZSBEU1AwIGFuZCBEU1AxIGl0ZW1zIGhhdmUgdGhlIHNhbWUgbnVt YmVyczogNCwgNSwgNi4KPiA+ID4gCj4gPiA+IFRoaXMgY2F1c2VzIGJvdGggY2xhbmcgYW5kIHNw YXJzZSB0byBjb21wbGFpbi4gSSB0aGluayB5b3UgY2FuIGp1c3QKPiA+ID4gY2hhbmdlIHRoaXMg c28gdGhhdCBUSDE1MjBfUkVTRVRfSURfRFNQMV9DT1JFIGlzIDcgYW5kIHNvIG9uLiBUaGUKPiA+ ID4gaW5kZXhlcyBkb24ndCByZWFsbHkgaGF2ZSBhbnkgY29uY3JldGUgbWVhbmluZyBvdGhlciB0 aGFuIGhvdyB0aGV5IGFyZQo+ID4gPiB1c2VkIGFzIHVuaXF1ZSBrZXlzLgo+ID4gCj4gPiBZb3Un cmUgY29ycmVjdCwgaXQncyBhIGNvcHktcGFzdGUgZXJyb3IsIGp1c3QgbGlrZSB0aGUgb25lIHNw b3R0ZWQgaW4gdjEKPiA+IG9mIHRoZSBzZXJpZXMuLi4KPiA+IAo+ID4gSSdtIG5vdCBzdXJlIHdo eSBlaXRoZXIgbXkgR0NDIG9yIHNwYXJzZSB5aWVsZGVkIG5vIHdhcm5pbmcgYWJvdXQgdGhlbS4K PiA+IFdpbGwgZmlndXJlIGl0IG91dCBhbmQgc2VuZCB2MyB3aXRoIHRoaXMgZml4ZWQuIE11Y2gg c29ycnkgZm9yIHRoZXNlCj4gPiBzdHVwaWQgbWlzdGFrZXMuCj4gPiAKPiA+IEJlc3QgcmVnYXJk cywKPiA+IFlhbyBaaQo+IAo+IEhhdmUgeW91IHRyaWVkIHVzaW5nIFc9MT8KPiAKPiBJIGRvIHNl ZSB0aGUgd2FybmluZyBpbiBnY2Mgd2l0aCB0aGF0Ogo+IAo+IHBkcDdAdGhlbGlvOn4vbGludXgk IHJtIGRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLm8KPiBwZHA3QHRoZWxpbzp+L2xpbnV4JCBt YWtlIFc9MSBDUk9TU19DT01QSUxFPXJpc2N2NjQtbGludXgtZ251LSBBUkNIPXJpc2N2IEM9MSAt ajE2Cj4gICBDQUxMICAgIHNjcmlwdHMvY2hlY2tzeXNjYWxscy5zaAo+IERvY3VtZW50YXRpb24v LnJlbmFtZXMudHh0OiB3YXJuaW5nOiBpZ25vcmVkIGJ5IG9uZSBvZiB0aGUgLmdpdGlnbm9yZSBm aWxlcwo+ICAgQ0MgICAgICBkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUyMC5vCj4gZHJpdmVycy9y ZXNldC9yZXNldC10aDE1MjAuYzo2NTU6Mzk6IHdhcm5pbmc6IGluaXRpYWxpemVkIGZpZWxkIG92 ZXJ3cml0dGVuIFstV292ZXJyaWRlLWluaXRdCj4gICA2NTUgfCAgICAgICAgIFtUSDE1MjBfUkVT RVRfSURfRFNQMV9DT1JFXSA9IHsKPiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXgo+IGRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmM6NjU1OjM5OiBub3Rl OiAobmVhciBpbml0aWFsaXphdGlvbiBmb3Ig4oCYdGgxNTIwX2RzcF9yZXNldHNbNF3igJkpCj4g ZHJpdmVycy9yZXNldC9yZXNldC10aDE1MjAuYzo2NTk6NDA6IHdhcm5pbmc6IGluaXRpYWxpemVk IGZpZWxkIG92ZXJ3cml0dGVuIFstV292ZXJyaWRlLWluaXRdCj4gICA2NTkgfCAgICAgICAgIFtU SDE1MjBfUkVTRVRfSURfRFNQMV9ERUJVR10gPSB7Cj4gICAgICAgfCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeCj4gZHJpdmVycy9yZXNldC9yZXNldC10aDE1MjAuYzo2 NTk6NDA6IG5vdGU6IChuZWFyIGluaXRpYWxpemF0aW9uIGZvciDigJh0aDE1MjBfZHNwX3Jlc2V0 c1s1XeKAmSkKPiBkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUyMC5jOjY2MzozODogd2FybmluZzog aW5pdGlhbGl6ZWQgZmllbGQgb3ZlcndyaXR0ZW4gWy1Xb3ZlcnJpZGUtaW5pdF0KPiAgIDY2MyB8 ICAgICAgICAgW1RIMTUyMF9SRVNFVF9JRF9EU1AxX0FQQl0gPSB7Cj4gICAgICAgfCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+IGRyaXZlcnMvcmVzZXQvcmVzZXQtdGgx NTIwLmM6NjYzOjM4OiBub3RlOiAobmVhciBpbml0aWFsaXphdGlvbiBmb3Ig4oCYdGgxNTIwX2Rz cF9yZXNldHNbNl3igJkpCj4gICBDSEVDSyAgIGRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmMK PiBkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUyMC5jOjY0MzoxMDogd2FybmluZzogSW5pdGlhbGl6 ZXIgZW50cnkgZGVmaW5lZCB0d2ljZQo+IGRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmM6NjU1 OjEwOiAgIGFsc28gZGVmaW5lZCBoZXJlCgpUaGFua3MsIGJ1aWxkaW5nIHdpdGggVz0xIGRvZXMg c3BvdCB0aGUgaXNzdWUuIFNvbWVob3cgbXkgbG9jYWwgc2V0dXAgb2YKc3BhcnNlIGNhbm5vdCBm aW5kIHRoZSBkdXBsaWNhdGVkIElEcyBmb3IgZWl0aGVyIHYxIG9yIHYyIG9mIHRoaXMKc2VyaWVz LCBidXQgR0NDIHdpdGggVz0xIGNvdWxkLgoKV2lsbCBzZW5kIHYzIG9mIHRoZSBzZXJpZXMgd2l0 aCB0aGVzZSBkdXBsaWNhdGVkIElEcyBmaXhlZC4gUmVhbGx5CnRoYW5rcyBmb3IgZmluZGluZyB0 aGUgaXNzdWUuCgpCZXN0IHJlZ2FyZHMKWWFvIFppCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlz Y3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B67A42E2EF8; Tue, 14 Oct 2025 09:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760435379; cv=none; b=WTBb7pdaQ6MXNtl7moAibc0buz/+V2SId0w1d87T9d3wL6cGWEoD9ZpVfQEtGgPo0gtuEYmKL5/nMoA7/CVXB5rAycthSEdBKJyi8ErTz2UhjMXTTVqIknWuBaLQwdnqDnn2+Tpz+4iWqESmAn3L/oEOi9wNqqGOMUGzMRhiX/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760435379; c=relaxed/simple; bh=8ZOdtFHoqv/rQpLoY48GmoTDS5BQalfi24BFCB1h7e4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gLeThKLmsaqXDEVPtSChhGI7uCmo0BX/I4InD7YG/BrtqHgYs55T2Xa67QzhPQittW2rQXPZjRBkjQHulc32+LPYDB4jRc2aavqr89G9OGUeQyZITQyCHbTKXS+dfXil/srhb95eS/Gl8NUWiiSxXF7aKe1K+wyT2I1jduWwj1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=IoHj+x5W; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="IoHj+x5W" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D255B260A3; Tue, 14 Oct 2025 11:49:27 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uovdA5KCQ9Xb; Tue, 14 Oct 2025 11:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1760435367; bh=8ZOdtFHoqv/rQpLoY48GmoTDS5BQalfi24BFCB1h7e4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IoHj+x5WYyeUqFeY+0WSwUtV5j8UHcGZo6LEs5W+hwoGC8uuZhp3dqgnQs2N23dSR vAtVe/CXt9eIFI/iXJPEcUr8gc3vKjAe6+rDfM1cozhLQJoQ4njt0rikI8x6zLGtkc svTX++7yslNag10zmvUIAhuwOcfl/zx39XP+sjOz77BxufupbSqSOllbkYksU3/t/7 sXTz1yZMcGXOR3oTHAX4YDLL7eaPdJezuq/TfvZklX6i7Sy6R9rmlK5SGIu62ZXTv/ 3gHGdJzzGAgPo8AhbEzKMmyGE+xnpmjCY2b+sOrKVTyyeDAK811upWwuYn+maSxbb3 c3hWa5dzGRQPQ== Date: Tue, 14 Oct 2025 09:49:07 +0000 From: Yao Zi To: Drew Fustini Cc: Rob Herring , Conor Dooley , Albert Ou , Michal Wilczynski , Alexandre Ghiti , devicetree@vger.kernel.org, Han Gao , Han Gao , linux-kernel@vger.kernel.org, Guo Ren , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Fu Wei Subject: Re: [PATCH v2 2/5] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Message-ID: References: <20250915095331.53350-1-ziyao@disroot.org> <20250915095331.53350-3-ziyao@disroot.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Oct 04, 2025 at 03:15:45PM -0700, Drew Fustini wrote: > On Sat, Oct 04, 2025 at 02:21:43AM +0000, Yao Zi wrote: > > On Fri, Oct 03, 2025 at 03:46:17PM -0700, Drew Fustini wrote: > > > On Mon, Sep 15, 2025 at 09:53:28AM +0000, Yao Zi wrote: > > > > TH1520 SoC is divided into several subsystems, most of them have > > > > distinct reset controllers. Let's document reset controllers other than > > > > the one for VO subsystem and IDs for their reset signals. > > > > > > > > Signed-off-by: Yao Zi > > > > > > Thanks for sending these patches. > > > > > > > --- > > > > .../bindings/reset/thead,th1520-reset.yaml | 8 +- > > > > .../dt-bindings/reset/thead,th1520-reset.h | 216 ++++++++++++++++++ > > > > 2 files changed, 223 insertions(+), 1 deletion(-) > > > > > > > [snip] > > > > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h > > > > index e51d6314d131..68ac52ed69de 100644 > > > > --- a/include/dt-bindings/reset/thead,th1520-reset.h > > > > +++ b/include/dt-bindings/reset/thead,th1520-reset.h > > > > @@ -7,6 +7,200 @@ > > > > #ifndef _DT_BINDINGS_TH1520_RESET_H > > > > #define _DT_BINDINGS_TH1520_RESET_H > > > [snip] > > > > +/* DSP Subsystem */ > > > > +#define TH1520_RESET_ID_X2X_DSP1 0 > > > > +#define TH1520_RESET_ID_X2X_DSP0 1 > > > > +#define TH1520_RESET_ID_X2X_SLAVE_DSP1 2 > > > > +#define TH1520_RESET_ID_X2X_SLAVE_DSP0 3 > > > > +#define TH1520_RESET_ID_DSP0_CORE 4 > > > > +#define TH1520_RESET_ID_DSP0_DEBUG 5 > > > > +#define TH1520_RESET_ID_DSP0_APB 6 > > > > +#define TH1520_RESET_ID_DSP1_CORE 4 > > > > +#define TH1520_RESET_ID_DSP1_DEBUG 5 > > > > +#define TH1520_RESET_ID_DSP1_APB 6 > > > > +#define TH1520_RESET_ID_DSPSYS_APB 7 > > > > +#define TH1520_RESET_ID_AXI4_DSPSYS_SLV 8 > > > > +#define TH1520_RESET_ID_AXI4_DSPSYS 9 > > > > +#define TH1520_RESET_ID_AXI4_DSP_RS 10 > > > > > > This doesn't seem right. The numbers for each subsystem should not > > > repeat. Here the DSP0 and DSP1 items have the same numbers: 4, 5, 6. > > > > > > This causes both clang and sparse to complain. I think you can just > > > change this so that TH1520_RESET_ID_DSP1_CORE is 7 and so on. The > > > indexes don't really have any concrete meaning other than how they are > > > used as unique keys. > > > > You're correct, it's a copy-paste error, just like the one spotted in v1 > > of the series... > > > > I'm not sure why either my GCC or sparse yielded no warning about them. > > Will figure it out and send v3 with this fixed. Much sorry for these > > stupid mistakes. > > > > Best regards, > > Yao Zi > > Have you tried using W=1? > > I do see the warning in gcc with that: > > pdp7@thelio:~/linux$ rm drivers/reset/reset-th1520.o > pdp7@thelio:~/linux$ make W=1 CROSS_COMPILE=riscv64-linux-gnu- ARCH=riscv C=1 -j16 > CALL scripts/checksyscalls.sh > Documentation/.renames.txt: warning: ignored by one of the .gitignore files > CC drivers/reset/reset-th1520.o > drivers/reset/reset-th1520.c:655:39: warning: initialized field overwritten [-Woverride-init] > 655 | [TH1520_RESET_ID_DSP1_CORE] = { > | ^ > drivers/reset/reset-th1520.c:655:39: note: (near initialization for ‘th1520_dsp_resets[4]’) > drivers/reset/reset-th1520.c:659:40: warning: initialized field overwritten [-Woverride-init] > 659 | [TH1520_RESET_ID_DSP1_DEBUG] = { > | ^ > drivers/reset/reset-th1520.c:659:40: note: (near initialization for ‘th1520_dsp_resets[5]’) > drivers/reset/reset-th1520.c:663:38: warning: initialized field overwritten [-Woverride-init] > 663 | [TH1520_RESET_ID_DSP1_APB] = { > | ^ > drivers/reset/reset-th1520.c:663:38: note: (near initialization for ‘th1520_dsp_resets[6]’) > CHECK drivers/reset/reset-th1520.c > drivers/reset/reset-th1520.c:643:10: warning: Initializer entry defined twice > drivers/reset/reset-th1520.c:655:10: also defined here Thanks, building with W=1 does spot the issue. Somehow my local setup of sparse cannot find the duplicated IDs for either v1 or v2 of this series, but GCC with W=1 could. Will send v3 of the series with these duplicated IDs fixed. Really thanks for finding the issue. Best regards Yao Zi