From: Alice Ryhl <aliceryhl@google.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Burak Emir" <bqe@google.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH] rust: bitmap: clean Rust 1.92.0 `unused_unsafe` warning
Date: Tue, 14 Oct 2025 16:21:51 +0000 [thread overview]
Message-ID: <aO54nxGil6a5hLQN@google.com> (raw)
In-Reply-To: <aO51pV5WSmqnT4rL@yury>
On Tue, Oct 14, 2025 at 12:09:09PM -0400, Yury Norov wrote:
> On Mon, Oct 13, 2025 at 09:20:15AM +0000, Alice Ryhl wrote:
> > On Mon, Oct 13, 2025 at 02:14:22AM +0200, Miguel Ojeda wrote:
> > > Starting with Rust 1.92.0 (expected 2025-12-11), Rust allows to safely
> > > take the address of a union field [1][2]:
> > >
> > > CLIPPY L rust/kernel.o
> > > error: unnecessary `unsafe` block
> > > --> rust/kernel/bitmap.rs:169:13
> > > |
> > > 169 | unsafe { core::ptr::addr_of!(self.repr.bitmap) }
> > > | ^^^^^^ unnecessary `unsafe` block
> > > |
> > > = note: `-D unused-unsafe` implied by `-D warnings`
> > > = help: to override `-D warnings` add `#[allow(unused_unsafe)]`
> > >
> > > error: unnecessary `unsafe` block
> > > --> rust/kernel/bitmap.rs:185:13
> > > |
> > > 185 | unsafe { core::ptr::addr_of_mut!(self.repr.bitmap) }
> > > | ^^^^^^ unnecessary `unsafe` block
> > >
> > > Thus allow both instances to clean the warning in newer compilers.
> > >
> > > Link: https://github.com/rust-lang/rust/issues/141264 [1]
> > > Link: https://github.com/rust-lang/rust/pull/141469 [2]
> > > Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> >
> > Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>
> Added in bitmap-for-next.
Is there any possibility of landing this for an -rc of 6.18 instead of
for 6.19-rc1? That way, the warning won't be present when compiling 6.18
with rustc 1.92.0 and newer.
Alice
next prev parent reply other threads:[~2025-10-14 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 0:14 [PATCH] rust: bitmap: clean Rust 1.92.0 `unused_unsafe` warning Miguel Ojeda
2025-10-13 9:20 ` Alice Ryhl
2025-10-14 16:09 ` Yury Norov
2025-10-14 16:21 ` Alice Ryhl [this message]
2025-10-14 16:23 ` Yury Norov
2025-10-14 16:42 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO54nxGil6a5hLQN@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bqe@google.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.