From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6FE30594D for ; Tue, 14 Oct 2025 12:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760445893; cv=none; b=lThqE/AKA9iOaktjhSM7rBCanED3qV9kxkVwYoFmwraKIDXV7d0nua5QSbIkqDnzkTi7pVUlnBzpodRu6UBDaf2nuvmESNL/uZ98FQq1oJYRkyMYwLj0mt/ADv5uuRE7OtSKEtEsYNIbi3PMqfUFcVtqt2H7ye1LJWHT/vTicA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760445893; c=relaxed/simple; bh=dneaycE8iKApW+fwsjcx5c8D+x9zckwhip7LcpS9qA4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RT8MBE2MTDgphdOCTTj0g9zPcgJx7u9E/UeyxbwuPieKaiOenv1TklQ1hCID0chJkA62bPKy1dhxJb9YmDoseRfoF0kr5xIJnWAq8O5y83O1RiiV/Xb7fDLBsxnmMtQ7TjXCYVvk2sekxcWAmJpMSTsjNWu11r9LY6XP9pPt46s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G167CHZP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G167CHZP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE400C4CEE7; Tue, 14 Oct 2025 12:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760445893; bh=dneaycE8iKApW+fwsjcx5c8D+x9zckwhip7LcpS9qA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G167CHZPA49hlPl/LwFcZEWjqVqi43EA9dMdxhE7YTesjSvVQAX1EjVYMNz48IGDR NKH5976ZU7dM+XRTiu99QzzSDDc6hakm1vmCTU5YVz1ZomfuuBpV8WFe69nrV/8w6h nEc5mRk9EG9GrpiHhOAd2W2erwzbmqXCkBskuw3D6+Axwq5kXIMpPOanpO/XiYH7m6 0tB+vajgs8sDZ4KFS4dncw3YsHnqMl75Gn3NfpBhPnho/vD7/8NjDFfA/z4TdnTajN 6wkuXgm9Bkz07oFulVniD8Acff2heF5ka8t7dr6m6UuWatIKu1+N8+y27KDEDq2E51 oMdbqBEF9/i9A== Date: Tue, 14 Oct 2025 13:44:49 +0100 From: Simon Horman To: Dimitri Daskalakis Cc: "David S . Miller" , Jakub Kicinski , Alexander Duyck , netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K Message-ID: References: <20251013211449.1377054-1-dimitri.daskalakis1@gmail.com> <20251013211449.1377054-2-dimitri.daskalakis1@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251013211449.1377054-2-dimitri.daskalakis1@gmail.com> On Mon, Oct 13, 2025 at 02:14:48PM -0700, Dimitri Daskalakis wrote: > The HW always works on a 4K page size. When the OS supports larger > pages, we fragment them across multiple BDQ descriptors. > We were not properly incrementing the descriptor, which resulted in us > specifying the last chunks id/addr and then 15 zero descriptors. This > would cause packet loss and driver crashes. This is not a fix since the > Kconfig prevents use outside of x86. > > Signed-off-by: Dimitri Daskalakis > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman