Re: [PATCH] rust/qemu-macros: Convert bit value to u8 within #[property]

[Zhao Liu <zhao1.liu@intel.com>]

On Tue, Oct 14, 2025 at 05:09:34PM +0200, Paolo Bonzini wrote:
> Date: Tue, 14 Oct 2025 17:09:34 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH] rust/qemu-macros: Convert bit value to u8 within
>  #[property]
> 
> On 10/14/25 17:02, Zhao Liu wrote:
> > diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs
> > index 3e21b67b4719..2a7454da2416 100644
> > --- a/rust/qemu-macros/src/lib.rs
> > +++ b/rust/qemu-macros/src/lib.rs
> > @@ -271,7 +271,10 @@ macro_rules! str_to_c_str {
> >                   name: ::std::ffi::CStr::as_ptr(#prop_name),
> >                   info: #qdev_prop,
> >                   offset: ::core::mem::offset_of!(#name, #field_name) as isize,
> > -                bitnr: #bitnr,
> > +                bitnr: {
> > +                    const { assert!(#bitnr >= 0 && #bitnr <= u8::MAX as _, "bit exceeds u8 range"); }
> 
> The check for the upper limit must be "#bitnr < $field_ty::BITS as _", for
> example rejecting 32 for an u32 field.

Yes, good point, MAX is not enough.

> Also, the tests need to be updated.

Will do.

Regards,
Zhao