From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 709B0CCD18E for ; Wed, 15 Oct 2025 08:18:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8who-0007js-5G; Wed, 15 Oct 2025 04:17:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8whi-0007cA-Vk for qemu-devel@nongnu.org; Wed, 15 Oct 2025 04:17:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8whd-00087a-39 for qemu-devel@nongnu.org; Wed, 15 Oct 2025 04:17:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760516260; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=v+79s1CEhybkFOpKu7NRVxQmyGJ4j+1Hgvhd45++RqA=; b=QsZphynLO2+jE9+j7ro7GplyWfaJIqD4tzj0IRTxjiWwfiBS53QN/806oUPYQzjU4TD5fb X1+ckD9MWNbydxQzS5NyiZuWaQesgz9xNRbtoRwOzgoE12/O/O8kFXW4eA9NJevUTtEGwS JnEakDBGM0uTXZY7MkXsy/C/maGY/tQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-l-TfK8LwOtOs1dZz_DrmmA-1; Wed, 15 Oct 2025 04:17:27 -0400 X-MC-Unique: l-TfK8LwOtOs1dZz_DrmmA-1 X-Mimecast-MFC-AGG-ID: l-TfK8LwOtOs1dZz_DrmmA_1760516240 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4B981954203; Wed, 15 Oct 2025 08:17:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.51]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 954F330001A1; Wed, 15 Oct 2025 08:17:15 +0000 (UTC) Date: Wed, 15 Oct 2025 09:17:11 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: Gerd Hoffmann , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Yanan Wang , Paolo Bonzini , Fabiano Rosas , Eric Blake , Eduardo Habkost , "Dr. David Alan Gilbert" , Laurent Vivier , Zhao Liu Subject: Re: [PATCH v4 1/2] hw/uefi: add "info firmware-log" + "query-firmware-log" monitor commands Message-ID: References: <20251013104954.250166-1-kraxel@redhat.com> <20251013104954.250166-2-kraxel@redhat.com> <87sefkfw84.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87sefkfw84.fsf@pond.sub.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 15, 2025 at 09:41:15AM +0200, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> > +static void handle_ovmf_log_range(GString *out, > >> > + dma_addr_t start, > >> > + dma_addr_t end, > >> > + Error **errp) > >> > +{ > >> > + g_autofree char *buf = NULL; > >> > >> Left-over variable - unfortunately gcc doens't warn about unused > >> vars when g_autofree is present :-( > > > > Fixed. > > > >> > +{ 'struct': 'FirmwareLog', > >> > + 'data': { '*version': 'str', > >> > + '*log': 'str' } } > >> > >> Having version be optional makes sense, but what is the semantics for > >> 'log' being optional. If the log is unavailable, wouldn't we be better > >> raising an error ? > > > > That is what the current implementation actually does. I change it. > > Drawback: when some Firmware provides version, but not log, the command > can't give us the version, because it fails. Do we care? This command is literally called 'query-firmware-log' though. From this I consider the log to be the important deliverable. If not available then I would expect an error from such a named command. If we want to provide non-log related info about the firmware when no log is available, then we should rename the command to "query-firmware-info" instead. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|