From: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Waiman Long" <longman@redhat.com>, "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Andrea Righi" <righi.andrea@gmail.com>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Joseph Salisbury" <joseph.salisbury@oracle.com>
Subject: Re: [PATCH] sched: cgroup: Move task_can_attach() to cpuset.c
Date: Fri, 3 Oct 2025 14:11:11 -0300 [thread overview]
Message-ID: <aOADr3PABpCs142e@uudg.org> (raw)
In-Reply-To: <20251003121421.0cf4372d@gandalf.local.home>
On Fri, Oct 03, 2025 at 12:14:21PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> At our monthly stable meeting, we were talking about documenting non
> static functions and randomly picked a function to look at. That was
> task_can_attach(). It was then noticed that it's only used by
> cgroup/cpuset.c and nothing else. It's a simple function that doesn't
> reference anything unique to sched/core.c, hence there's no reason that
> function should be there.
>
> Move it to cgroup/cpuset.c as that's the only place it is used. Also make
> it a static inline as it is so small.
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> include/linux/sched.h | 1 -
> kernel/cgroup/cpuset.c | 19 +++++++++++++++++++
> kernel/sched/core.c | 19 -------------------
> 3 files changed, 19 insertions(+), 20 deletions(-)
That was a fun exercise. :)
Tested-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com>
next prev parent reply other threads:[~2025-10-03 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 16:14 [PATCH] sched: cgroup: Move task_can_attach() to cpuset.c Steven Rostedt
2025-10-03 16:36 ` Andrea Righi
2025-10-03 16:43 ` Steven Rostedt
2025-10-03 16:53 ` Andrea Righi
2025-10-03 16:39 ` Waiman Long
2025-10-03 17:11 ` Luis Claudio R. Goncalves [this message]
2025-10-03 19:56 ` [External] : " Joseph Salisbury
2025-10-03 21:38 ` Tejun Heo
2025-10-06 18:31 ` Peter Zijlstra
2025-10-06 18:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOADr3PABpCs142e@uudg.org \
--to=lgoncalv@redhat.com \
--cc=Julia.Lawall@inria.fr \
--cc=hannes@cmpxchg.org \
--cc=joseph.salisbury@oracle.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=righi.andrea@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.