From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E6E3CAC5BB for ; Sat, 4 Oct 2025 22:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tEK9ShAm5GoARwAHGyjcwzq44Jf+6YkeOVGvKDV2SEw=; b=2sFXA5PJcTqGgi 8XKO2JT8t6vHqNi020HdTCKyXTto9307fnxW8JAtJWJQI3UiJDgmORKVb4ar1r+FTeIIeBs7FPqHw fXzSChT+zl9NYFVEVHHNS9QHesYZjsqtn7NJGALUeeD3guPK9VsNp4pSWgCsV6vs7EoP8Avhha1wc L5ajyoo6cX7qVNRFplJqPcf2qj+dPpuVbj64qplfYsvP9W/oYSk/xV90hydXeRxBBiKNbJhL4u2il i3dvIX+pwaGhHUQw+MYaMD0CuLLcRtLbXQ3/2ydFSlkHClniO8jVB+agwGgc+nmi6QYk8SE6wXB9K S5Kd9uusAyi4vLichyHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5AXg-0000000E2bc-1Mrk; Sat, 04 Oct 2025 22:15:52 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5AXe-0000000E2bN-201I for linux-riscv@lists.infradead.org; Sat, 04 Oct 2025 22:15:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F28A260097; Sat, 4 Oct 2025 22:15:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BCC7C4CEF1; Sat, 4 Oct 2025 22:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759616147; bh=qaOCsP4oe6v4+XQagMpOX+PTxSAsjOjOnpdwZh4rx/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p83xI5xSqfFgq5p3pEEevSuazrmM93RK0RNbgDvLAx3gI3wCk3LkZr7ILrgRb53dJ CNMN5NiH8QhbF8b4q0kDAZe60e+Ymgk4b+iD0+lazopL1EXKwQXrJfaFWRJngiu/PO QXQW63PAHlL/dttQgRzOGyy+jMcMCb5CnYIuibAQOgtcdg6mLu2eGAhD+5/xo2Lu3j 4GicMNKx2NnV0XYWhJVvGnmzia/xCXTC+HvJO/dPA7gnt7dB50KKpTC8WLz9RRk2W+ zEwwunlLzfboURxW/ij3fZ7jkyTdI0kTomAtN/QOejhkGRyEkmaWB0yEZRAswOzTnW 1Q1ugVFXDPbbg== Date: Sat, 4 Oct 2025 15:15:45 -0700 From: Drew Fustini To: Yao Zi Cc: Rob Herring , Conor Dooley , Albert Ou , Michal Wilczynski , Alexandre Ghiti , devicetree@vger.kernel.org, Han Gao , Han Gao , linux-kernel@vger.kernel.org, Guo Ren , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Fu Wei Subject: Re: [PATCH v2 2/5] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Message-ID: References: <20250915095331.53350-1-ziyao@disroot.org> <20250915095331.53350-3-ziyao@disroot.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBPY3QgMDQsIDIwMjUgYXQgMDI6MjE6NDNBTSArMDAwMCwgWWFvIFppIHdyb3RlOgo+ IE9uIEZyaSwgT2N0IDAzLCAyMDI1IGF0IDAzOjQ2OjE3UE0gLTA3MDAsIERyZXcgRnVzdGluaSB3 cm90ZToKPiA+IE9uIE1vbiwgU2VwIDE1LCAyMDI1IGF0IDA5OjUzOjI4QU0gKzAwMDAsIFlhbyBa aSB3cm90ZToKPiA+ID4gVEgxNTIwIFNvQyBpcyBkaXZpZGVkIGludG8gc2V2ZXJhbCBzdWJzeXN0 ZW1zLCBtb3N0IG9mIHRoZW0gaGF2ZQo+ID4gPiBkaXN0aW5jdCByZXNldCBjb250cm9sbGVycy4g TGV0J3MgZG9jdW1lbnQgcmVzZXQgY29udHJvbGxlcnMgb3RoZXIgdGhhbgo+ID4gPiB0aGUgb25l IGZvciBWTyBzdWJzeXN0ZW0gYW5kIElEcyBmb3IgdGhlaXIgcmVzZXQgc2lnbmFscy4KPiA+ID4g Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFlhbyBaaSA8eml5YW9AZGlzcm9vdC5vcmc+Cj4gPiAKPiA+ IFRoYW5rcyBmb3Igc2VuZGluZyB0aGVzZSBwYXRjaGVzLgo+ID4gCj4gPiA+IC0tLQo+ID4gPiAg Li4uL2JpbmRpbmdzL3Jlc2V0L3RoZWFkLHRoMTUyMC1yZXNldC55YW1sICAgIHwgICA4ICstCj4g PiA+ICAuLi4vZHQtYmluZGluZ3MvcmVzZXQvdGhlYWQsdGgxNTIwLXJlc2V0LmggICAgfCAyMTYg KysrKysrKysrKysrKysrKysrCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIyMyBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4gW3NuaXBdCj4gPiA+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2R0LWJpbmRpbmdzL3Jlc2V0L3RoZWFkLHRoMTUyMC1yZXNldC5oIGIvaW5jbHVkZS9k dC1iaW5kaW5ncy9yZXNldC90aGVhZCx0aDE1MjAtcmVzZXQuaAo+ID4gPiBpbmRleCBlNTFkNjMx NGQxMzEuLjY4YWM1MmVkNjlkZSAxMDA2NDQKPiA+ID4gLS0tIGEvaW5jbHVkZS9kdC1iaW5kaW5n cy9yZXNldC90aGVhZCx0aDE1MjAtcmVzZXQuaAo+ID4gPiArKysgYi9pbmNsdWRlL2R0LWJpbmRp bmdzL3Jlc2V0L3RoZWFkLHRoMTUyMC1yZXNldC5oCj4gPiA+IEBAIC03LDYgKzcsMjAwIEBACj4g PiA+ICAjaWZuZGVmIF9EVF9CSU5ESU5HU19USDE1MjBfUkVTRVRfSAo+ID4gPiAgI2RlZmluZSBf RFRfQklORElOR1NfVEgxNTIwX1JFU0VUX0gKPiA+IFtzbmlwXQo+ID4gPiArLyogRFNQIFN1YnN5 c3RlbSAqLwo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURfWDJYX0RTUDEJMAo+ID4gPiAr I2RlZmluZSBUSDE1MjBfUkVTRVRfSURfWDJYX0RTUDAJMQo+ID4gPiArI2RlZmluZSBUSDE1MjBf UkVTRVRfSURfWDJYX1NMQVZFX0RTUDEJMgo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURf WDJYX1NMQVZFX0RTUDAJMwo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURfRFNQMF9DT1JF CTQKPiA+ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lEX0RTUDBfREVCVUcJNQo+ID4gPiArI2Rl ZmluZSBUSDE1MjBfUkVTRVRfSURfRFNQMF9BUEIJNgo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVT RVRfSURfRFNQMV9DT1JFCTQKPiA+ID4gKyNkZWZpbmUgVEgxNTIwX1JFU0VUX0lEX0RTUDFfREVC VUcJNQo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURfRFNQMV9BUEIJNgo+ID4gPiArI2Rl ZmluZSBUSDE1MjBfUkVTRVRfSURfRFNQU1lTX0FQQgk3Cj4gPiA+ICsjZGVmaW5lIFRIMTUyMF9S RVNFVF9JRF9BWEk0X0RTUFNZU19TTFYJOAo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURf QVhJNF9EU1BTWVMJOQo+ID4gPiArI2RlZmluZSBUSDE1MjBfUkVTRVRfSURfQVhJNF9EU1BfUlMJ MTAKPiA+IAo+ID4gVGhpcyBkb2Vzbid0IHNlZW0gcmlnaHQuIFRoZSBudW1iZXJzIGZvciBlYWNo IHN1YnN5c3RlbSBzaG91bGQgbm90Cj4gPiByZXBlYXQuIEhlcmUgdGhlIERTUDAgYW5kIERTUDEg aXRlbXMgaGF2ZSB0aGUgc2FtZSBudW1iZXJzOiA0LCA1LCA2Lgo+ID4gCj4gPiBUaGlzIGNhdXNl cyBib3RoIGNsYW5nIGFuZCBzcGFyc2UgdG8gY29tcGxhaW4uIEkgdGhpbmsgeW91IGNhbiBqdXN0 Cj4gPiBjaGFuZ2UgdGhpcyBzbyB0aGF0IFRIMTUyMF9SRVNFVF9JRF9EU1AxX0NPUkUgaXMgNyBh bmQgc28gb24uIFRoZQo+ID4gaW5kZXhlcyBkb24ndCByZWFsbHkgaGF2ZSBhbnkgY29uY3JldGUg bWVhbmluZyBvdGhlciB0aGFuIGhvdyB0aGV5IGFyZQo+ID4gdXNlZCBhcyB1bmlxdWUga2V5cy4K PiAKPiBZb3UncmUgY29ycmVjdCwgaXQncyBhIGNvcHktcGFzdGUgZXJyb3IsIGp1c3QgbGlrZSB0 aGUgb25lIHNwb3R0ZWQgaW4gdjEKPiBvZiB0aGUgc2VyaWVzLi4uCj4gCj4gSSdtIG5vdCBzdXJl IHdoeSBlaXRoZXIgbXkgR0NDIG9yIHNwYXJzZSB5aWVsZGVkIG5vIHdhcm5pbmcgYWJvdXQgdGhl bS4KPiBXaWxsIGZpZ3VyZSBpdCBvdXQgYW5kIHNlbmQgdjMgd2l0aCB0aGlzIGZpeGVkLiBNdWNo IHNvcnJ5IGZvciB0aGVzZQo+IHN0dXBpZCBtaXN0YWtlcy4KPiAKPiBCZXN0IHJlZ2FyZHMsCj4g WWFvIFppCgpIYXZlIHlvdSB0cmllZCB1c2luZyBXPTE/CgpJIGRvIHNlZSB0aGUgd2FybmluZyBp biBnY2Mgd2l0aCB0aGF0OgoKcGRwN0B0aGVsaW86fi9saW51eCQgcm0gZHJpdmVycy9yZXNldC9y ZXNldC10aDE1MjAubwpwZHA3QHRoZWxpbzp+L2xpbnV4JCBtYWtlIFc9MSBDUk9TU19DT01QSUxF PXJpc2N2NjQtbGludXgtZ251LSBBUkNIPXJpc2N2IEM9MSAtajE2CiAgQ0FMTCAgICBzY3JpcHRz L2NoZWNrc3lzY2FsbHMuc2gKRG9jdW1lbnRhdGlvbi8ucmVuYW1lcy50eHQ6IHdhcm5pbmc6IGln bm9yZWQgYnkgb25lIG9mIHRoZSAuZ2l0aWdub3JlIGZpbGVzCiAgQ0MgICAgICBkcml2ZXJzL3Jl c2V0L3Jlc2V0LXRoMTUyMC5vCmRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmM6NjU1OjM5OiB3 YXJuaW5nOiBpbml0aWFsaXplZCBmaWVsZCBvdmVyd3JpdHRlbiBbLVdvdmVycmlkZS1pbml0XQog IDY1NSB8ICAgICAgICAgW1RIMTUyMF9SRVNFVF9JRF9EU1AxX0NPUkVdID0gewogICAgICB8ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgpkcml2ZXJzL3Jlc2V0L3Jlc2V0 LXRoMTUyMC5jOjY1NTozOTogbm90ZTogKG5lYXIgaW5pdGlhbGl6YXRpb24gZm9yIOKAmHRoMTUy MF9kc3BfcmVzZXRzWzRd4oCZKQpkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUyMC5jOjY1OTo0MDog d2FybmluZzogaW5pdGlhbGl6ZWQgZmllbGQgb3ZlcndyaXR0ZW4gWy1Xb3ZlcnJpZGUtaW5pdF0K ICA2NTkgfCAgICAgICAgIFtUSDE1MjBfUkVTRVRfSURfRFNQMV9ERUJVR10gPSB7CiAgICAgIHwg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgpkcml2ZXJzL3Jlc2V0L3Jl c2V0LXRoMTUyMC5jOjY1OTo0MDogbm90ZTogKG5lYXIgaW5pdGlhbGl6YXRpb24gZm9yIOKAmHRo MTUyMF9kc3BfcmVzZXRzWzVd4oCZKQpkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUyMC5jOjY2Mzoz ODogd2FybmluZzogaW5pdGlhbGl6ZWQgZmllbGQgb3ZlcndyaXR0ZW4gWy1Xb3ZlcnJpZGUtaW5p dF0KICA2NjMgfCAgICAgICAgIFtUSDE1MjBfUkVTRVRfSURfRFNQMV9BUEJdID0gewogICAgICB8 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCmRyaXZlcnMvcmVzZXQvcmVz ZXQtdGgxNTIwLmM6NjYzOjM4OiBub3RlOiAobmVhciBpbml0aWFsaXphdGlvbiBmb3Ig4oCYdGgx NTIwX2RzcF9yZXNldHNbNl3igJkpCiAgQ0hFQ0sgICBkcml2ZXJzL3Jlc2V0L3Jlc2V0LXRoMTUy MC5jCmRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmM6NjQzOjEwOiB3YXJuaW5nOiBJbml0aWFs aXplciBlbnRyeSBkZWZpbmVkIHR3aWNlCmRyaXZlcnMvcmVzZXQvcmVzZXQtdGgxNTIwLmM6NjU1 OjEwOiAgIGFsc28gZGVmaW5lZCBoZXJlCiAgQVIgICAgICBkcml2ZXJzL3Jlc2V0L2J1aWx0LWlu LmEKICBBUiAgICAgIGRyaXZlcnMvYnVpbHQtaW4uYQogIEFSICAgICAgYnVpbHQtaW4uYQogIEFS ICAgICAgdm1saW51eC5hCiAgTEQgICAgICB2bWxpbnV4Lm8KICBNT0RQT1NUIE1vZHVsZS5zeW12 ZXJzCiAgVVBEICAgICBpbmNsdWRlL2dlbmVyYXRlZC91dHN2ZXJzaW9uLmgKICBDQyAgICAgIGlu aXQvdmVyc2lvbi10aW1lc3RhbXAubwogIENIRUNLICAgaW5pdC92ZXJzaW9uLXRpbWVzdGFtcC5j CiAgS1NZTVMgICAudG1wX3ZtbGludXgwLmthbGxzeW1zLlMKICBBUyAgICAgIC50bXBfdm1saW51 eDAua2FsbHN5bXMubwogIExEICAgICAgLnRtcF92bWxpbnV4MQogIE5NICAgICAgLnRtcF92bWxp bnV4MS5zeW1zCiAgS1NZTVMgICAudG1wX3ZtbGludXgxLmthbGxzeW1zLlMKICBBUyAgICAgIC50 bXBfdm1saW51eDEua2FsbHN5bXMubwogIExEICAgICAgLnRtcF92bWxpbnV4MgogIE5NICAgICAg LnRtcF92bWxpbnV4Mi5zeW1zCiAgS1NZTVMgICAudG1wX3ZtbGludXgyLmthbGxzeW1zLlMKICBB UyAgICAgIC50bXBfdm1saW51eDIua2FsbHN5bXMubwogIExEICAgICAgdm1saW51eC51bnN0cmlw cGVkCiAgTk0gICAgICBTeXN0ZW0ubWFwCiAgU09SVFRBQiB2bWxpbnV4LnVuc3RyaXBwZWQKICBP QkpDT1BZIHZtbGludXgKICBPQkpDT1BZIG1vZHVsZXMuYnVpbHRpbi5tb2RpbmZvCiAgR0VOICAg ICBtb2R1bGVzLmJ1aWx0aW4KICBPQkpDT1BZIGFyY2gvcmlzY3YvYm9vdC9JbWFnZQogIEtlcm5l bDogYXJjaC9yaXNjdi9ib290L0ltYWdlIGlzIHJlYWR5CiAgR1pJUCAgICBhcmNoL3Jpc2N2L2Jv b3QvSW1hZ2UuZ3oKICBLZXJuZWw6IGFyY2gvcmlzY3YvYm9vdC9JbWFnZS5neiBpcyByZWFkeQpw ZHA3QHRoZWxpbzp+L2xpbnV4JCBoZWFkIC5jb25maWcKIwojIEF1dG9tYXRpY2FsbHkgZ2VuZXJh dGVkIGZpbGU7IERPIE5PVCBFRElULgojIExpbnV4L3Jpc2N2IDYuMTcuMCBLZXJuZWwgQ29uZmln dXJhdGlvbgojCkNPTkZJR19DQ19WRVJTSU9OX1RFWFQ9InJpc2N2NjQtbGludXgtZ251LWdjYyAo VWJ1bnR1IDEzLjMuMC02dWJ1bnR1Mn4yNC4wNCkgMTMuMy4wIgpDT05GSUdfQ0NfSVNfR0NDPXkK Q09ORklHX0dDQ19WRVJTSU9OPTEzMDMwMApDT05GSUdfQ0xBTkdfVkVSU0lPTj0wCkNPTkZJR19B U19JU19HTlU9eQpDT05GSUdfQVNfVkVSU0lPTj0yNDIwMAoKClRoYW5rcywKRHJldwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EEF2154BF5; Sat, 4 Oct 2025 22:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759616148; cv=none; b=iPcv6QbCyELatvCXnQAFGO8kuka4KQ1NZnj9X3oj33rR89o9G6wjyWxiiFAJLx3i3lG+S+69nakagymlk0cPmMvRlm7ESTx02VxZc9fvR2Bppdu5dlyhtEvVbui185XFzVCUzKhMXwfbS+Xc9EzkKzlhP+OI+7RsNUlcCuyCkIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759616148; c=relaxed/simple; bh=qaOCsP4oe6v4+XQagMpOX+PTxSAsjOjOnpdwZh4rx/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EhpK/JN7p0XEZCXFIomftW4Si0Pumx0s0pifUkpYfxAMezNriH96Gra01IOhkJiw98lnQPjK2uvYujf03lXVkIFJZJ7FeD9yujKEjERH6Y4rhfThIxcCDcP0/pYXIMRj2LYzcnWwvcwRien1Sr8JNDgSvnOvEcEuEq4TCeoW49A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p83xI5xS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p83xI5xS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BCC7C4CEF1; Sat, 4 Oct 2025 22:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759616147; bh=qaOCsP4oe6v4+XQagMpOX+PTxSAsjOjOnpdwZh4rx/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p83xI5xSqfFgq5p3pEEevSuazrmM93RK0RNbgDvLAx3gI3wCk3LkZr7ILrgRb53dJ CNMN5NiH8QhbF8b4q0kDAZe60e+Ymgk4b+iD0+lazopL1EXKwQXrJfaFWRJngiu/PO QXQW63PAHlL/dttQgRzOGyy+jMcMCb5CnYIuibAQOgtcdg6mLu2eGAhD+5/xo2Lu3j 4GicMNKx2NnV0XYWhJVvGnmzia/xCXTC+HvJO/dPA7gnt7dB50KKpTC8WLz9RRk2W+ zEwwunlLzfboURxW/ij3fZ7jkyTdI0kTomAtN/QOejhkGRyEkmaWB0yEZRAswOzTnW 1Q1ugVFXDPbbg== Date: Sat, 4 Oct 2025 15:15:45 -0700 From: Drew Fustini To: Yao Zi Cc: Rob Herring , Conor Dooley , Albert Ou , Michal Wilczynski , Alexandre Ghiti , devicetree@vger.kernel.org, Han Gao , Han Gao , linux-kernel@vger.kernel.org, Guo Ren , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Fu Wei Subject: Re: [PATCH v2 2/5] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Message-ID: References: <20250915095331.53350-1-ziyao@disroot.org> <20250915095331.53350-3-ziyao@disroot.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Oct 04, 2025 at 02:21:43AM +0000, Yao Zi wrote: > On Fri, Oct 03, 2025 at 03:46:17PM -0700, Drew Fustini wrote: > > On Mon, Sep 15, 2025 at 09:53:28AM +0000, Yao Zi wrote: > > > TH1520 SoC is divided into several subsystems, most of them have > > > distinct reset controllers. Let's document reset controllers other than > > > the one for VO subsystem and IDs for their reset signals. > > > > > > Signed-off-by: Yao Zi > > > > Thanks for sending these patches. > > > > > --- > > > .../bindings/reset/thead,th1520-reset.yaml | 8 +- > > > .../dt-bindings/reset/thead,th1520-reset.h | 216 ++++++++++++++++++ > > > 2 files changed, 223 insertions(+), 1 deletion(-) > > > > > [snip] > > > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h > > > index e51d6314d131..68ac52ed69de 100644 > > > --- a/include/dt-bindings/reset/thead,th1520-reset.h > > > +++ b/include/dt-bindings/reset/thead,th1520-reset.h > > > @@ -7,6 +7,200 @@ > > > #ifndef _DT_BINDINGS_TH1520_RESET_H > > > #define _DT_BINDINGS_TH1520_RESET_H > > [snip] > > > +/* DSP Subsystem */ > > > +#define TH1520_RESET_ID_X2X_DSP1 0 > > > +#define TH1520_RESET_ID_X2X_DSP0 1 > > > +#define TH1520_RESET_ID_X2X_SLAVE_DSP1 2 > > > +#define TH1520_RESET_ID_X2X_SLAVE_DSP0 3 > > > +#define TH1520_RESET_ID_DSP0_CORE 4 > > > +#define TH1520_RESET_ID_DSP0_DEBUG 5 > > > +#define TH1520_RESET_ID_DSP0_APB 6 > > > +#define TH1520_RESET_ID_DSP1_CORE 4 > > > +#define TH1520_RESET_ID_DSP1_DEBUG 5 > > > +#define TH1520_RESET_ID_DSP1_APB 6 > > > +#define TH1520_RESET_ID_DSPSYS_APB 7 > > > +#define TH1520_RESET_ID_AXI4_DSPSYS_SLV 8 > > > +#define TH1520_RESET_ID_AXI4_DSPSYS 9 > > > +#define TH1520_RESET_ID_AXI4_DSP_RS 10 > > > > This doesn't seem right. The numbers for each subsystem should not > > repeat. Here the DSP0 and DSP1 items have the same numbers: 4, 5, 6. > > > > This causes both clang and sparse to complain. I think you can just > > change this so that TH1520_RESET_ID_DSP1_CORE is 7 and so on. The > > indexes don't really have any concrete meaning other than how they are > > used as unique keys. > > You're correct, it's a copy-paste error, just like the one spotted in v1 > of the series... > > I'm not sure why either my GCC or sparse yielded no warning about them. > Will figure it out and send v3 with this fixed. Much sorry for these > stupid mistakes. > > Best regards, > Yao Zi Have you tried using W=1? I do see the warning in gcc with that: pdp7@thelio:~/linux$ rm drivers/reset/reset-th1520.o pdp7@thelio:~/linux$ make W=1 CROSS_COMPILE=riscv64-linux-gnu- ARCH=riscv C=1 -j16 CALL scripts/checksyscalls.sh Documentation/.renames.txt: warning: ignored by one of the .gitignore files CC drivers/reset/reset-th1520.o drivers/reset/reset-th1520.c:655:39: warning: initialized field overwritten [-Woverride-init] 655 | [TH1520_RESET_ID_DSP1_CORE] = { | ^ drivers/reset/reset-th1520.c:655:39: note: (near initialization for ‘th1520_dsp_resets[4]’) drivers/reset/reset-th1520.c:659:40: warning: initialized field overwritten [-Woverride-init] 659 | [TH1520_RESET_ID_DSP1_DEBUG] = { | ^ drivers/reset/reset-th1520.c:659:40: note: (near initialization for ‘th1520_dsp_resets[5]’) drivers/reset/reset-th1520.c:663:38: warning: initialized field overwritten [-Woverride-init] 663 | [TH1520_RESET_ID_DSP1_APB] = { | ^ drivers/reset/reset-th1520.c:663:38: note: (near initialization for ‘th1520_dsp_resets[6]’) CHECK drivers/reset/reset-th1520.c drivers/reset/reset-th1520.c:643:10: warning: Initializer entry defined twice drivers/reset/reset-th1520.c:655:10: also defined here AR drivers/reset/built-in.a AR drivers/built-in.a AR built-in.a AR vmlinux.a LD vmlinux.o MODPOST Module.symvers UPD include/generated/utsversion.h CC init/version-timestamp.o CHECK init/version-timestamp.c KSYMS .tmp_vmlinux0.kallsyms.S AS .tmp_vmlinux0.kallsyms.o LD .tmp_vmlinux1 NM .tmp_vmlinux1.syms KSYMS .tmp_vmlinux1.kallsyms.S AS .tmp_vmlinux1.kallsyms.o LD .tmp_vmlinux2 NM .tmp_vmlinux2.syms KSYMS .tmp_vmlinux2.kallsyms.S AS .tmp_vmlinux2.kallsyms.o LD vmlinux.unstripped NM System.map SORTTAB vmlinux.unstripped OBJCOPY vmlinux OBJCOPY modules.builtin.modinfo GEN modules.builtin OBJCOPY arch/riscv/boot/Image Kernel: arch/riscv/boot/Image is ready GZIP arch/riscv/boot/Image.gz Kernel: arch/riscv/boot/Image.gz is ready pdp7@thelio:~/linux$ head .config # # Automatically generated file; DO NOT EDIT. # Linux/riscv 6.17.0 Kernel Configuration # CONFIG_CC_VERSION_TEXT="riscv64-linux-gnu-gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=130300 CONFIG_CLANG_VERSION=0 CONFIG_AS_IS_GNU=y CONFIG_AS_VERSION=24200 Thanks, Drew