All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Rohan Tripathi <trohan2000@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: rtl8723bs: split long comments in rtw_ap.c
Date: Mon, 6 Oct 2025 10:30:09 +0300	[thread overview]
Message-ID: <aONwAXk2EcV9Bgrv@stanley.mountain> (raw)
In-Reply-To: <20251005155920.381334-3-trohan2000@gmail.com>

On Sun, Oct 05, 2025 at 11:59:18AM -0400, Rohan Tripathi wrote:
> This patch splits overly long comments that exceeded 100 characters
> into multiple shorter lines, following kernel coding style guidelines.
> 
> This is a coding style cleanup only. No functional changes.
> 
> Signed-off-by: Rohan Tripathi <trohan2000@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 93ab0015ca89..2c906c1137bf 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -391,7 +391,9 @@ void update_bmc_sta(struct adapter *padapter)
>  
>  		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
>  
> -		/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */
> +		/* psta->dot118021XPrivacy = _NO_PRIVACY_;
> +		 * remove it, because it has been set before this.
> +		 */
>  
>  		/* prepare for add_RATid */
>  		supportRateNum = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
> @@ -655,7 +657,10 @@ void start_bss_network(struct adapter *padapter)
>  	cur_ch_offset = HAL_PRIME_CHNL_OFFSET_DONT_CARE;
>  
>  	/* check if there is wps ie, */
> -	/* if there is wpsie in beacon, the hostapd will update beacon twice when stating hostapd, */
> +	/* if there is wpsie in beacon,
> +	 *the hostapd will update beacon
> +	 *twice when stating hostapd,

Missing space after the asterisk.

regards,
dan carpenter


  reply	other threads:[~2025-10-06  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-05 15:59 [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' in rtw_ap.c Rohan Tripathi
2025-10-05 15:59 ` [PATCH] staging: rtl8723bs: clean up style " Rohan Tripathi
2025-10-06  7:29   ` Dan Carpenter
2025-10-05 15:59 ` [PATCH 2/4] staging: rtl8723bs: split long comments " Rohan Tripathi
2025-10-06  7:30   ` Dan Carpenter [this message]
2025-10-05 15:59 ` [PATCH 3/4] staging: rtl8723bs: remove unnecessary blank lines " Rohan Tripathi
2025-10-06  7:30   ` Dan Carpenter
2025-10-05 15:59 ` [PATCH 4/4] staging: rtl8723bs: fix operator spacing " Rohan Tripathi
2025-10-06  7:26 ` [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aONwAXk2EcV9Bgrv@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=trohan2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.