Re: [PATCH] drm/xe: Fix copyright and function naming in xe_ttm_vram_mgr

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Oct 06, 2025 at 01:03:32PM -0400, Lin, Shuicheng wrote:
> On Mon, Oct 6, 2025 9:48 AM Rodrigo Vivi wrote:
> > On Mon, Oct 06, 2025 at 09:19:59AM +0000, Gote, Nitin R wrote:
> > > > -----Original Message-----
> > > > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> > > > Shuicheng Lin
> > > > Sent: Saturday, October 4, 2025 5:34 AM
> > > > To: intel-xe@lists.freedesktop.org
> > > > Cc: Lin, Shuicheng <shuicheng.lin@intel.com>
> > > > Subject: [PATCH] drm/xe: Fix copyright and function naming in
> > > > xe_ttm_vram_mgr
> > > >
> > > > - Correct copyright year from "2002" to "2022".
> > 
> > patch pushed to drm-xe-next. Thanks
> > 
> > apparently we still have 2 more occurrences:
> > 
> > drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c: * Copyright (C) 2021-2002 Red
> > Hat
> > drivers/gpu/drm/xe/xe_ttm_sys_mgr.c: * Copyright (C) 2021-2002 Red Hat
> > 
> 
> Thanks Rodrigo.
> Will you take care of it, or would you like me to handle it as well? Thanks.

I would appreciate if you take care of that as a follow up.

Thank you

> 
> Shuicheng
> 
> > > > - Rename ttm_vram_mgr_fini() to xe_ttm_vram_mgr_fini() to avoid
> > > >   confusion with generic TTM helpers.
> > > >
> > > > No functional changes intended.
> > > >
> > > > Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> > > > ---
> > > >  drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > > > b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > > > index 9175b4a2214b..9f70802fce92 100644
> > > > --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > > > +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > > > @@ -1,7 +1,7 @@
> > > >  // SPDX-License-Identifier: MIT
> > > >  /*
> > > >   * Copyright (c) 2021-2022 Intel Corporation
> > > > - * Copyright (C) 2021-2002 Red Hat
> > > > + * Copyright (C) 2021-2022 Red Hat
> > > >   */
> > > >
> > > >  #include <drm/drm_managed.h>
> > > > @@ -284,7 +284,7 @@ static const struct ttm_resource_manager_func
> > > > xe_ttm_vram_mgr_func = {
> > > >  	.debug	= xe_ttm_vram_mgr_debug
> > > >  };
> > > >
> > > > -static void ttm_vram_mgr_fini(struct drm_device *dev, void *arg)
> > > > +static void xe_ttm_vram_mgr_fini(struct drm_device *dev, void *arg)
> > > >  {
> > > >  	struct xe_device *xe = to_xe_device(dev);
> > > >  	struct xe_ttm_vram_mgr *mgr = arg; @@ -335,7 +335,7 @@ int
> > > > __xe_ttm_vram_mgr_init(struct xe_device *xe, struct xe_ttm_vram_mgr
> > > > *mgr,
> > > >  	ttm_set_driver_manager(&xe->ttm, mem_type, &mgr->manager);
> > > >  	ttm_resource_manager_set_used(&mgr->manager, true);
> > > >
> > > > -	return drmm_add_action_or_reset(&xe->drm, ttm_vram_mgr_fini,
> > mgr);
> > > > +	return drmm_add_action_or_reset(&xe->drm, xe_ttm_vram_mgr_fini,
> > > > mgr);
> > >
> > > LGTM,
> > > Reviewed-by: Nitin Gote <nitin.r.gote@intel.com>
> > >
> > > Nitin
> > > >  }
> > > >
> > > >  /**
> > > > --
> > > > 2.49.0
> > >