From: Niklas Cassel <cassel@kernel.org>
To: Markus Probst <markus.probst@posteo.de>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Power on ata ports defined in ACPI before probing ports
Date: Mon, 6 Oct 2025 17:07:26 +0200 [thread overview]
Message-ID: <aOPbLlvbfFadVQsV@ryzen> (raw)
In-Reply-To: <20251005190559.1472308-2-markus.probst@posteo.de>
On Sun, Oct 05, 2025 at 07:06:07PM +0000, Markus Probst wrote:
> some devices (for example every synology nas with "deep sleep" support)
Some devices?
I assume you mean the HBA and not the devices connected to the HBA.
> have the ability to power on and off each ata port individually. This
> turns the specific port on, if power manageable in acpi, before probing
> it.
>
> This can later be extended to power down the ata ports (removing power
> from a disk) while the disk is spin down.
Spun down?
Overall this commit message needs some serious improvement.
I have no idea what Synology NAS with "deep sleep" support is.
We don't add support for vendor specific features.
Please reference the proper ATA ACS / AHCI / SATA / ACPI specification,
including the version of said specification and which section in that
specification.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-10-06 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 19:05 [PATCH 0/2] Support power resources in ata ports Markus Probst
2025-10-05 19:06 ` [PATCH 1/2] Add manage_restart device attribute to scsi_disk Markus Probst
2025-10-05 19:06 ` [PATCH 2/2] Power on ata ports defined in ACPI before probing ports Markus Probst
2025-10-06 1:09 ` Damien Le Moal
2025-10-09 11:07 ` Markus Probst
2025-10-06 15:07 ` Niklas Cassel [this message]
2025-10-06 15:50 ` Markus Probst
2025-10-09 11:41 ` Niklas Cassel
2025-10-06 0:58 ` [PATCH 1/2] Add manage_restart device attribute to scsi_disk Damien Le Moal
2025-10-06 12:11 ` Markus Probst
2025-10-09 11:24 ` [PATCH v2 0/2] Support power resources defined in acpi on ata Markus Probst
2025-10-09 11:24 ` [PATCH v2 2/2] ata: Use ACPI methods to power on ata ports Markus Probst
2025-10-09 11:59 ` Niklas Cassel
2025-10-09 12:03 ` Niklas Cassel
2025-10-09 13:48 ` Markus Probst
2025-10-10 15:52 ` kernel test robot
2025-10-09 11:24 ` [PATCH v2 1/2] scsi: sd: Add manage_restart device attribute to scsi_disk Markus Probst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOPbLlvbfFadVQsV@ryzen \
--to=cassel@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.