All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 2/5] test: nfs: don't require a locking daemon
Date: Mon, 6 Oct 2025 12:11:19 -0400	[thread overview]
Message-ID: <aOPqJz+icWdvp0s2@oracle.com> (raw)
In-Reply-To: <20251006152829.239100-2-nick.alcock@oracle.com>

On Mon, Oct 06, 2025 at 04:28:25PM +0100, Nick Alcock wrote:
> On modern (NFSv4) systems, there is no guarantee that statd is running,
> and indeed it has probably been explicitly turned off (unless writable
> NFSv3 exports exist).  This causes mount-time warnings that trigger test
> failures unless we disable locking.
> 
> No DTrace NFS tests need locking, so disable it.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  test/triggers/io-mount-nfs.sh | 2 +-
>  test/unittest/io/tst.nfs2.sh  | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/triggers/io-mount-nfs.sh b/test/triggers/io-mount-nfs.sh
> index 338443eb72240..71c83103075b8 100755
> --- a/test/triggers/io-mount-nfs.sh
> +++ b/test/triggers/io-mount-nfs.sh
> @@ -18,4 +18,4 @@ fi
>  mountdir=$1
>  serverpath=$2
>  
> -mount -t nfs -o nfsvers=3 127.0.0.1:$serverpath $mountdir
> +mount -t nfs -o nfsvers=3,nolock 127.0.0.1:$serverpath $mountdir
> diff --git a/test/unittest/io/tst.nfs2.sh b/test/unittest/io/tst.nfs2.sh
> index 41a7a465868f9..87452d3a3be10 100755
> --- a/test/unittest/io/tst.nfs2.sh
> +++ b/test/unittest/io/tst.nfs2.sh
> @@ -31,13 +31,13 @@ systemctl enable --now nfs-server > /dev/null 2>&1
>  mkdir $exdir
>    exportfs -i -v -o "rw,sync,no_root_squash,insecure,fsid=8434437288" 127.0.0.1:$exdir > /dev/null
>      mkdir $iodir
> -        mount -t nfs -o nfsvers=3 127.0.0.1:$exdir $iodir
> +        mount -t nfs -o nolock,nfsvers=3 127.0.0.1:$exdir $iodir
>              $rundt "dd if=/dev/urandom of=$tempfile count=$filesize bs=1 status=none" -o log.write
>              myinode=`stat $tempfile  | gawk '/	Inode: / {print $4}'`
>          umount $iodir
>          # flush caches and remount to force IO
>  	echo 3 > /proc/sys/vm/drop_caches
> -        mount -t nfs -o nfsvers=3 127.0.0.1:$exdir $iodir
> +        mount -t nfs -o nolock,nfsvers=3 127.0.0.1:$exdir $iodir
>              $rundt "sum $tempfile"                                                    -o log.read
>              rm -f $tempfile
>          umount $iodir
> -- 
> 2.51.0.284.g117bcb8de7
> 

  reply	other threads:[~2025-10-06 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 15:28 [PATCH 1/5] test: fbt return0: work on quiet systems Nick Alcock
2025-10-06 15:28 ` [PATCH 2/5] test: nfs: don't require a locking daemon Nick Alcock
2025-10-06 16:11   ` Kris Van Hees [this message]
2025-10-06 15:28 ` [PATCH 3/5] test: preprocessor: work on GCC 16 Nick Alcock
2025-10-07 15:08   ` Kris Van Hees
2025-10-06 15:28 ` [PATCH 4/5] test: tid_pid: don't assume the type of pthread_t Nick Alcock
2025-10-06 16:13   ` Kris Van Hees
2025-10-06 15:28 ` [PATCH 5/5] test: dupstruct: fix extra duplicate identifier case Nick Alcock
2025-10-06 16:14   ` Kris Van Hees
2025-10-06 16:09 ` [PATCH 1/5] test: fbt return0: work on quiet systems Kris Van Hees
2025-10-07 15:36   ` Nick Alcock
2025-10-08 11:16   ` [PATCH v2 " Nick Alcock
2025-10-08 16:15     ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOPqJz+icWdvp0s2@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.