From: Christoph Hellwig <hch@infradead.org>
To: David Disseldorp <ddiss@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
dima@arista.com, Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Schier <nsc@kernel.org>
Subject: Re: [PATCH RFC] gen_init_cpio: Do fsync() only on regular files
Date: Mon, 6 Oct 2025 23:28:41 -0700 [thread overview]
Message-ID: <aOSzGf7OFn2Gkkbe@infradead.org> (raw)
In-Reply-To: <20251007172556.3e57b0c8.ddiss@suse.de>
On Tue, Oct 07, 2025 at 05:25:56PM +1100, David Disseldorp wrote:
> On Mon, 6 Oct 2025 23:03:57 -0700, Christoph Hellwig wrote:
>
> > On Tue, Oct 07, 2025 at 04:57:32PM +1100, David Disseldorp wrote:
> > > I should have explained why in the commit, sorry. The intention was to
> > > catch any FS I/O errors during output archive writeback. fsync() is
> > > called only once as the final I/O.
> >
> > I don't parse this. What does 'as the final I/O' mean?
>
> fsync() is called once after all buffered writes and copy_file_range()
> calls for the initramfs archive have completed.
>
> > If you want
> > to catch writeback errors, a single syncfs should be enough.
>
> gen_init_cpio should only be concerned that the output archive file is
> flushed to storage, rather than the entire filesystem. Why would syncfs
> be more suitable?
Oh, it is called on the generated archive. Yes, that makes sense.
Sorry for the noise.
prev parent reply other threads:[~2025-10-07 6:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 23:55 [PATCH RFC] gen_init_cpio: Do fsync() only on regular files Dmitry Safonov
2025-10-06 23:55 ` Dmitry Safonov via B4 Relay
2025-10-07 0:07 ` Dmitry Safonov
2025-10-07 1:17 ` David Disseldorp
2025-10-07 3:09 ` Dmitry Safonov
2025-10-07 4:40 ` Christoph Hellwig
2025-10-07 5:57 ` David Disseldorp
2025-10-07 6:03 ` Christoph Hellwig
2025-10-07 6:25 ` David Disseldorp
2025-10-07 6:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOSzGf7OFn2Gkkbe@infradead.org \
--to=hch@infradead.org \
--cc=ddiss@suse.de \
--cc=dima@arista.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.