All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 01/20] Fix comment since pkt_addr is not NULL
Date: Tue, 7 Oct 2025 11:23:35 -0400	[thread overview]
Message-ID: <aOUwd/crK6g6StWl@oracle.com> (raw)
In-Reply-To: <20250926190557.8485-1-eugene.loh@oracle.com>

On Fri, Sep 26, 2025 at 03:05:38PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  dlibs/aarch64/5.11/net.d | 1 -
>  dlibs/aarch64/5.12/net.d | 1 -
>  dlibs/aarch64/5.14/net.d | 1 -
>  dlibs/aarch64/5.16/net.d | 1 -
>  dlibs/aarch64/5.2/net.d  | 1 -
>  dlibs/aarch64/5.6/net.d  | 1 -
>  dlibs/aarch64/6.1/net.d  | 1 -
>  dlibs/aarch64/6.10/net.d | 1 -
>  dlibs/x86_64/5.11/net.d  | 1 -
>  dlibs/x86_64/5.12/net.d  | 1 -
>  dlibs/x86_64/5.14/net.d  | 1 -
>  dlibs/x86_64/5.16/net.d  | 1 -
>  dlibs/x86_64/5.2/net.d   | 1 -
>  dlibs/x86_64/5.6/net.d   | 1 -
>  dlibs/x86_64/6.1/net.d   | 1 -
>  dlibs/x86_64/6.10/net.d  | 1 -
>  libdtrace/net.d          | 1 -
>  17 files changed, 17 deletions(-)
> 
> diff --git a/dlibs/aarch64/5.11/net.d b/dlibs/aarch64/5.11/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.11/net.d
> +++ b/dlibs/aarch64/5.11/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/5.12/net.d b/dlibs/aarch64/5.12/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.12/net.d
> +++ b/dlibs/aarch64/5.12/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/5.14/net.d b/dlibs/aarch64/5.14/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.14/net.d
> +++ b/dlibs/aarch64/5.14/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/5.16/net.d b/dlibs/aarch64/5.16/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.16/net.d
> +++ b/dlibs/aarch64/5.16/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/5.2/net.d b/dlibs/aarch64/5.2/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.2/net.d
> +++ b/dlibs/aarch64/5.2/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/5.6/net.d b/dlibs/aarch64/5.6/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/5.6/net.d
> +++ b/dlibs/aarch64/5.6/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/6.1/net.d b/dlibs/aarch64/6.1/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/6.1/net.d
> +++ b/dlibs/aarch64/6.1/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/aarch64/6.10/net.d b/dlibs/aarch64/6.10/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/aarch64/6.10/net.d
> +++ b/dlibs/aarch64/6.10/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.11/net.d b/dlibs/x86_64/5.11/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.11/net.d
> +++ b/dlibs/x86_64/5.11/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.12/net.d b/dlibs/x86_64/5.12/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.12/net.d
> +++ b/dlibs/x86_64/5.12/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.14/net.d b/dlibs/x86_64/5.14/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.14/net.d
> +++ b/dlibs/x86_64/5.14/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.16/net.d b/dlibs/x86_64/5.16/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.16/net.d
> +++ b/dlibs/x86_64/5.16/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.2/net.d b/dlibs/x86_64/5.2/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.2/net.d
> +++ b/dlibs/x86_64/5.2/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/5.6/net.d b/dlibs/x86_64/5.6/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/5.6/net.d
> +++ b/dlibs/x86_64/5.6/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/6.1/net.d b/dlibs/x86_64/6.1/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/6.1/net.d
> +++ b/dlibs/x86_64/6.1/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/dlibs/x86_64/6.10/net.d b/dlibs/x86_64/6.10/net.d
> index a81fdf087..f14013b9f 100644
> --- a/dlibs/x86_64/6.10/net.d
> +++ b/dlibs/x86_64/6.10/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> diff --git a/libdtrace/net.d b/libdtrace/net.d
> index a81fdf087..f14013b9f 100644
> --- a/libdtrace/net.d
> +++ b/libdtrace/net.d
> @@ -36,7 +36,6 @@ typedef struct in6_addr	in6_addr_t;
>  /*
>   * pktinfo is where packet ID info can be made available for deeper analysis if
>   * packet IDs become supported by the kernel in the future.
> - * The pkt_addr member is currently always NULL.
>   */
>  typedef struct pktinfo {
>  	uintptr_t	pkt_addr;
> -- 
> 2.47.3
> 

      parent reply	other threads:[~2025-10-07 15:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 19:05 [PATCH 01/20] Fix comment since pkt_addr is not NULL eugene.loh
2025-09-26 19:05 ` [PATCH 02/20] doc: Add a space eugene.loh
2025-10-23 19:50   ` [DTrace-devel] " Elena Zannoni
2025-09-26 19:05 ` [PATCH 03/20] doc: Add separator lines to cpc Markdown tables eugene.loh
2025-10-23 19:51   ` [DTrace-devel] " Elena Zannoni
2025-09-26 19:05 ` [PATCH 04/20] doc: Convert stability attribute tables to Markdown for readability eugene.loh
2025-10-23 19:52   ` [DTrace-devel] " Elena Zannoni
2025-09-26 19:05 ` [PATCH 05/20] doc: Remove duplicate id eugene.loh
2025-09-26 19:05 ` [PATCH 06/20] doc: Clean up dangling anchor links eugene.loh
2025-09-26 19:05 ` [PATCH 07/20] doc: Remove internal ID definition at top of file eugene.loh
2025-10-22  3:03   ` Eugene Loh
2025-09-26 19:05 ` [PATCH 08/20] doc: Fix anchor links for built-in variables eugene.loh
2025-09-26 19:05 ` [PATCH 09/20] doc: Fix anchor links for providers eugene.loh
2025-09-26 19:05 ` [PATCH 10/20] doc: Fix anchor links for explanation/ eugene.loh
2025-09-26 19:05 ` [PATCH 11/20] doc: Fix anchor links for how-to/ eugene.loh
2025-09-26 19:05 ` [PATCH 12/20] doc: Fix anchor links for reference/ eugene.loh
2025-09-26 19:05 ` [PATCH 13/20] doc: Clean up the table for string relational operators eugene.loh
2025-09-26 19:05 ` [PATCH 14/20] doc: Link to "Character Escape Sequences" table eugene.loh
2025-09-26 19:05 ` [PATCH 15/20] doc: Clean up profile unit table eugene.loh
2025-09-26 19:05 ` [PATCH 16/20] doc: Clean up undefined anchor links eugene.loh
2025-09-26 19:05 ` [PATCH v2 17/20] doc: Add IP provider documentation eugene.loh
2025-10-09 17:03   ` Kris Van Hees
2025-10-09 21:00     ` Eugene Loh
2025-10-09 21:45       ` Kris Van Hees
2025-10-09 22:28         ` Eugene Loh
2025-09-26 19:05 ` [PATCH 18/20] doc: Add TCP " eugene.loh
2025-10-24  8:24   ` Alan Maguire
2025-09-26 19:05 ` [PATCH 19/20] doc: Add UDP " eugene.loh
2025-10-24  8:18   ` Alan Maguire
2025-09-26 19:05 ` [PATCH 20/20] doc: Add rawfbt " eugene.loh
2025-10-07 15:23 ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOUwd/crK6g6StWl@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.