Re: [PATCH 4/4] drm/i915/opregion: Flush asle_work during runtime suspend

[Imre Deak <imre.deak@intel.com>]

On Tue, Jul 08, 2025 at 07:03:20PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> For good measure make sure asle_work has finished whatever it
> was doing before we runtime suspend the device.
> 
> This probably isn't really necessary as long asle_work only
> pokes at the mailbox as it should remain accessible even if
> the device has been suspended. But seems better to play it
> safe in case there is ever any need to do more stuff in
> asle_work.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
> index e99616ea2ae6..08d36411668d 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -1294,6 +1294,8 @@ void intel_opregion_runtime_suspend(struct intel_display *display)
>  		 */
>  		intel_opregion_notify_adapter(display, PCI_D1);
>  	}
> +
> +	flush_work(&opregion->asle_work);

asle_work() -> asle_set_backlight() takes connection_mutex and
runtime_pm references can be taken with connection_mutex held, isn't
that a problem?

>  }
>  
>  void intel_opregion_unregister(struct intel_display *display)
> -- 
> 2.49.0
>