Re: [PATCH 1/6] tracetool: rename variable with conflicting types

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Oct 08, 2025 at 08:35:40AM +0200, Paolo Bonzini wrote:
> "backend" is used as both a string and a backend.Wrapper.  In preparation
> for adding type annotations, use different names.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/tracetool/__init__.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 74062d21a7c..85527c08c98 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -566,9 +566,9 @@ def generate(events, group, format, backends,
>  
>      if len(backends) == 0:
>          raise TracetoolError("no backends specified")
> -    for backend in backends:
> -        if not tracetool.backend.exists(backend):
> -            raise TracetoolError("unknown backend: %s" % backend)
> +    for backend_name in backends:
> +        if not tracetool.backend.exists(backend_name):
> +            raise TracetoolError("unknown backend: %s" % backend_name)

IMHO it suffices to shorten the name  'for name in backends',
but either way

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


>      backend = tracetool.backend.Wrapper(backends, format)
>  
>      import tracetool.backend.dtrace
> -- 
> 2.51.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|