Re: [PATCH v3 5/5] dt-bindings: watchdog: renesas,wdt: add SWDT exception for V3H

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hi Geert,

thanks for the reviews!

> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: renesas,r8a77980-swdt
> > +    then:
> > +      properties:
> > +        resets: false
> > +    else:
> > +      required:
> > +        - resets
> > +
> 
> Instead, I would just make the resets property optional (i.e. not
> required) for renesas,r8a77980-wdt.

Oh, I like that idea! Because you are right the IP core is the same.

> Of course, I wouldn't be surprised if the MSSR does have a reset bit to
> control SWDT on R-Car V3H.  But it may be a bit hard to flip the
> suspected bit on a system with remote access, as it requires modifying
> firmware permissions?

Well, in the docs *every* SoC except V3H has it expressed. So, I
consider it officially unsupported. And I don't feel like digging out
why.

I'll implement your suggestion.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]