All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Russ Weight" <russ.weight@linux.dev>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
	"Waiman Long" <longman@redhat.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Jan Kara" <jack@suse.cz>, "Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-block@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v17 09/11] rust: remove spurious `use core::fmt::Debug`
Date: Wed, 15 Oct 2025 19:33:01 +0000	[thread overview]
Message-ID: <aO_27dG0j3zbnBCX@google.com> (raw)
In-Reply-To: <20251015-cstr-core-v17-9-dc5e7aec870d@gmail.com>

On Wed, Oct 15, 2025 at 03:24:39PM -0400, Tamir Duberstein wrote:
> We want folks to use `kernel::fmt` but this is only used for `derive` so
> can be removed entirely.
> 
> This backslid in commit ea60cea07d8c ("rust: add `Alignment` type").
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

  reply	other threads:[~2025-10-15 19:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 19:24 [PATCH v17 00/11] rust: replace kernel::str::CStr w/ core::ffi::CStr Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 01/11] samples: rust: platform: remove trailing commas Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 02/11] rust_binder: remove trailing comma Tamir Duberstein
2025-10-15 19:30   ` Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 03/11] rust_binder: use `kernel::fmt` Tamir Duberstein
2025-10-15 19:31   ` Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 04/11] rust_binder: use `core::ffi::CStr` method names Tamir Duberstein
2025-10-15 19:31   ` Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 05/11] rnull: use `kernel::fmt` Tamir Duberstein
2025-10-16  8:42   ` Andreas Hindborg
2025-10-15 19:24 ` [PATCH v17 06/11] rust: alloc: " Tamir Duberstein
2025-10-15 19:29   ` Tamir Duberstein
2025-10-15 19:31   ` Alice Ryhl
2025-10-15 19:47   ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 07/11] rust: debugfs: " Tamir Duberstein
2025-10-15 19:39   ` Matthew Maurer
2025-10-15 19:45   ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 08/11] rust: pci: " Tamir Duberstein
2025-10-15 19:46   ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 09/11] rust: remove spurious `use core::fmt::Debug` Tamir Duberstein
2025-10-15 19:33   ` Alice Ryhl [this message]
2025-10-15 19:24 ` [PATCH v17 10/11] rust: support formatting of foreign types Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 11/11] rust: replace `CStr` with `core::ffi::CStr` Tamir Duberstein
2025-10-18 17:02 ` [PATCH v17 00/11] rust: replace kernel::str::CStr w/ core::ffi::CStr Alice Ryhl
2025-10-18 17:09   ` Alice Ryhl
2025-10-20 12:00     ` Tamir Duberstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aO_27dG0j3zbnBCX@google.com \
    --to=aliceryhl@google.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=arve@android.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=joelagnelf@nvidia.com \
    --cc=justinstitt@google.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=longman@redhat.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lossin@kernel.org \
    --cc=maco@android.com \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=tamird@gmail.com \
    --cc=tkjos@android.com \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.