From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, oleksii.kurochko@gmail.com,
Anthony PERARD <anthony.perard@vates.tech>,
Juergen Gross <jgross@suse.com>,
Michal Orzel <michal.orzel@amd.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH for-4.21 0/6] tools/{lib,}xl: Coverity falllout from the json-c switch
Date: Wed, 15 Oct 2025 18:50:58 +0200 [thread overview]
Message-ID: <aO_Q8n6_fgRFgaQN@Mac.lan> (raw)
In-Reply-To: <87f5c526-8491-433c-bf64-027d5635b13f@citrix.com>
On Wed, Oct 15, 2025 at 04:04:06PM +0100, Andrew Cooper wrote:
> On 15/10/2025 2:40 pm, Roger Pau Monne wrote:
> > Hello,
> >
> > The following series contains fixes for Coverity reported issues after
> > the switch from YAJL to json-c. Those reports are from the internal
> > XenServer Coverity instance, as the project one hasn't been switched to
> > use json-c yet, last patch in the series switches thegithub triggered
> > Coverity build to use json-c.
> >
> > All should be considered for 4.21.
> >
> > Thanks, Roger.
> >
> > Roger Pau Monne (6):
> > tools/{lib,}xl: fix usage of error return from
> > json_tokener_parse_verbose()
> > tools/libxl: avoid freeing stack rubble in
> > libxl__json_object_to_json()
> > tools/xl: check return of json_object_object_add()
> > tools/xl: check return value of printf_info_one_json() in
> > list_domains_details()
> > tools/xl: fix possible uninitialized usage in printf_info()
> > github/coverity: switch to building with json-c instead of yajl
>
> Other than my query on patch 1, everything else LGTM.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks, if no one else expresses an opinion by tomorrow I will apply
your comment and commit.
Roger.
prev parent reply other threads:[~2025-10-15 16:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 13:40 [PATCH for-4.21 0/6] tools/{lib,}xl: Coverity falllout from the json-c switch Roger Pau Monne
2025-10-15 13:40 ` [PATCH for-4.21 1/6] tools/{lib,}xl: fix usage of error return from json_tokener_parse_verbose() Roger Pau Monne
2025-10-15 13:59 ` Andrew Cooper
2025-10-15 14:25 ` Roger Pau Monné
2025-10-15 13:40 ` [PATCH for-4.21 2/6] tools/libxl: avoid freeing stack rubble in libxl__json_object_to_json() Roger Pau Monne
2025-10-15 18:50 ` Jason Andryuk
2025-10-15 13:40 ` [PATCH for-4.21 3/6] tools/xl: check return of json_object_object_add() Roger Pau Monne
2025-10-15 18:51 ` Jason Andryuk
2025-10-15 13:40 ` [PATCH for-4.21 4/6] tools/xl: check return value of printf_info_one_json() in list_domains_details() Roger Pau Monne
2025-10-15 18:52 ` Jason Andryuk
2025-10-15 13:40 ` [PATCH for-4.21 5/6] tools/xl: fix possible uninitialized usage in printf_info() Roger Pau Monne
2025-10-15 18:53 ` Jason Andryuk
2025-10-15 13:40 ` [PATCH for-4.21 6/6] github/coverity: switch to building with json-c instead of yajl Roger Pau Monne
2025-10-15 18:53 ` Jason Andryuk
2025-10-15 15:00 ` [PATCH for-4.21 0/6] tools/{lib,}xl: Coverity falllout from the json-c switch Oleksii Kurochko
2025-10-15 15:04 ` Andrew Cooper
2025-10-15 16:50 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO_Q8n6_fgRFgaQN@Mac.lan \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.