Re: [PATCH 3/3] mm/swap: remove unneeded swap_active_head

[Baoquan He <bhe@redhat.com>]

On 10/08/25 at 08:26pm, Andrew Morton wrote:
> On Wed,  1 Oct 2025 12:34:36 +0800 Baoquan He <bhe@redhat.com> wrote:
> 
> > There's no user of swap_active_head, remove it now.
> > 
> > ...
> >
> > @@ -2553,8 +2545,6 @@ static void _enable_swap_info(struct swap_info_struct *si)
> >  
> >  	assert_spin_locked(&swap_lock);
> >  
> > -	plist_add(&si->list, &swap_active_head);
> > -
> 
> There's a large comment in _enable_swap_info() which needs to be
> removed or updated?

This patchset depends on below patchset:
[PATCH v3 0/2] mm/swapfile.c: select the swap device with default priority round robin

That large comment in _enable_swap_info() has been removed in
"[PATCH v3 0/2] mm/swapfile.c: select the swap device with default
priority round robin"
> 
> >  	/* Add back to available list */
> >  	add_to_avail_list(si, true);
> >  }
> 
> I fixed the rejects and my swapfile.c still has a couple of references
> to swap_active_head.  Can we please have a redo&resend against mm-new?

not sure if it's caused by the dependency on "[PATCH v3 0/2] mm/swapfile.c:
select the swap device with default priority round robin". I will rebase
it on mm-new to see.

By the way, Chris worried the plist swap_active_head could be reused by
the ongoing swap-tier work and suggested to hold off this patchset till
swap-tier work is clear. Now seems it won't impact swap-tier, I will
send a v2 against mm-new.

Thanks a lot.