All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Chris Mason <clm@meta.com>, Steven Rostedt <rostedt@goodmis.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"Bird, Tim" <Tim.Bird@sony.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"ksummit@lists.linux.dev" <ksummit@lists.linux.dev>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools
Date: Thu, 9 Oct 2025 14:47:54 -0300	[thread overview]
Message-ID: <aOf1Sv0vWddGAn_J@x1> (raw)
In-Reply-To: <CAADnVQJjqgrfLo3pcFYDXJ9x6ieDoeJEroWRCSG1cVahH8AMnw@mail.gmail.com>

On Thu, Oct 09, 2025 at 10:31:10AM -0700, Alexei Starovoitov wrote:
> On Thu, Oct 9, 2025 at 10:24 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > On Thu, Oct 09, 2025 at 02:19:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > > On Thu, Oct 09, 2025 at 12:31:48PM -0400, Chris Mason wrote:
> > > > On 10/9/25 10:30 AM, Steven Rostedt wrote:
> > > > > One way I see this working is to attach it to patchwork. Sending a patch to
> > > > > the BPF mailing list has their patchwork trigger a bunch of tests and it
> > > > > will tell you if it passed or failed. I'm assuming if it failed, it doesn't
> > > > > add it to patchwork and the maintainers will ignore it.

> > > > > Attaching AI to patchwork could be useful as well. But this would run on
> > > > > some server that someone will have to pay for. But it will not be the
> > > > > submitter.

> > > > Just to clarify, that's what already happens with BPF today.

> > > > Ex: https://github.com/kernel-patches/bpf/pull/9962 are all from the
> > > > review prompts.

> > > This almost relieves me from the guilt not to have reviewed that series
> > > from Alan ;-\

> > But this goes back to "developers should run these tools before
> > submitting upstream", which would provide them with reviewing comments
> > that would improve the quality of their pull requests by using all the
> > money that is being dreamed into AI and would saved all of us from
> > looking at github, etc, before AI is satisfied with the quality of the
> > submitters work?

> > Its all about what should distract maintainers (humans?), no?
 
> Our next step is to send them as plain text emails, so that reviews

Great!

> will blend in into natural kernel development process:
> submitter send patches, AI and/or human replies, submitter replies
> and insists that their code is correct and AI/human is wrong,
> or admits the bug and fixes it in the next respin. And so on.

Right, the thing I see making lots of people not trying to see AI as a
helping hand is that they do some one-off attempt while crossing their
hands wishing not to get a good answer. When they get a good answer they
think they are "cheating".

This is a knee-jerk reaction, focus on how you can get rid of mundane
work.
 
> Chris did a tremendous job in reducing false positives.

I have not tested it, but people in my team have and gave me great
feedback, we're on it!

> These reviews were proven to be quite accurate and spotted
> bugs that maintainers didn't. In a few cases the maintainer
> found a bug and pointed it out, but AI explained the bug better.

I'm a believer, there is help to be obtained from all this, lets reap
it.

- Arnaldo

  reply	other threads:[~2025-10-09 17:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 17:04 [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Chris Mason
2025-10-08 17:20 ` Konstantin Ryabitsev
2025-10-08 18:11   ` Sasha Levin
2025-10-08 18:35   ` Chris Mason
2025-10-08 17:57 ` Bart Van Assche
2025-10-08 18:04   ` Chris Mason
2025-10-08 18:14     ` Bart Van Assche
2025-10-08 18:42       ` Chris Mason
2025-10-08 21:08     ` Kees Cook
2025-10-09  1:37       ` Chris Mason
2025-10-08 18:33 ` Sasha Levin
2025-10-09  1:43   ` Chris Mason
2025-10-09 14:49     ` Paul E. McKenney
2025-10-08 19:08 ` Andrew Lunn
2025-10-08 19:28   ` Arnaldo Carvalho de Melo
2025-10-08 19:33     ` Laurent Pinchart
2025-10-08 19:39       ` Arnaldo Carvalho de Melo
2025-10-08 20:29         ` Andrew Lunn
2025-10-08 20:53           ` Mark Brown
2025-10-09  9:37         ` Laurent Pinchart
2025-10-09 12:48           ` Arnaldo Carvalho de Melo
2025-10-08 19:29   ` Laurent Pinchart
2025-10-08 19:50     ` Bird, Tim
2025-10-08 20:30       ` Sasha Levin
2025-10-09 12:32         ` Arnaldo Carvalho de Melo
2025-10-08 20:30       ` James Bottomley
2025-10-08 20:38         ` Bird, Tim
2025-10-08 22:21           ` Jiri Kosina
2025-10-09  9:14           ` Laurent Pinchart
2025-10-09 10:03             ` Chris Mason
2025-10-10  7:54               ` Laurent Pinchart
2025-10-10 11:40                 ` James Bottomley
2025-10-10 11:53                   ` Laurent Pinchart
2025-10-10 14:21                     ` Steven Rostedt
2025-10-10 14:35                   ` Bird, Tim
2025-10-09 14:30             ` Steven Rostedt
2025-10-09 14:51               ` Andrew Lunn
2025-10-09 15:05                 ` Steven Rostedt
2025-10-10  7:59                 ` Laurent Pinchart
2025-10-10 14:15                   ` Bird, Tim
2025-10-10 15:07                     ` Joe Perches
2025-10-10 16:01                       ` checkpatch encouragement improvements (was RE: [MAINTAINERS / KERNEL SUMMIT] AI patch review tools) Bird, Tim
2025-10-10 17:11                         ` Rob Herring
2025-10-10 17:33                           ` Arnaldo Carvalho de Melo
2025-10-10 19:21                           ` Joe Perches
2025-10-10 16:11                       ` [MAINTAINERS / KERNEL SUMMIT] AI patch review tools Steven Rostedt
2025-10-10 16:47                         ` Joe Perches
2025-10-10 17:42                           ` Steven Rostedt
2025-10-11 10:28                         ` Mark Brown
2025-10-09 16:31               ` Chris Mason
2025-10-09 17:19                 ` Arnaldo Carvalho de Melo
2025-10-09 17:24                   ` Arnaldo Carvalho de Melo
2025-10-09 17:31                     ` Alexei Starovoitov
2025-10-09 17:47                       ` Arnaldo Carvalho de Melo [this message]
2025-10-09 18:42                     ` Chris Mason
2025-10-09 18:56                       ` Linus Torvalds
2025-10-10 15:52                         ` Mauro Carvalho Chehab
2025-10-09 14:47             ` Bird, Tim
2025-10-09 15:11               ` Andrew Lunn
2025-10-09 17:58               ` Mark Brown
2025-10-09  1:15         ` Chris Mason
2025-10-08 20:37     ` Andrew Lunn
2025-10-09 12:40       ` Arnaldo Carvalho de Melo
2025-10-09 14:52 ` Paul E. McKenney
2025-10-10  3:08 ` Krzysztof Kozlowski
2025-10-10 14:12   ` Chris Mason
2025-10-31 16:51   ` Stephen Hemminger
2025-10-14  7:16 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOf1Sv0vWddGAn_J@x1 \
    --to=acme@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Tim.Bird@sony.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=clm@meta.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.