Re: [PATCH v4 05/12] aio: remove aio_context_use_g_source()

[Kevin Wolf <kwolf@redhat.com>]

Am 09.10.2025 um 17:46 hat Kevin Wolf geschrieben:
> Am 10.09.2025 um 19:56 hat Stefan Hajnoczi geschrieben:
> > There is no need for aio_context_use_g_source() now that epoll(7) and
> > io_uring(7) file descriptor monitoring works with the glib event loop.
> > AioContext doesn't need to be notified that GSource is being used.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> We should probably mention in the commit message that this causes the
> default fdmon on Linux to change from poll to io_uring. It's a small
> code change, but it makes QEMU use a completely different code path by
> default.

Just to make sure, I ran 'make check' after this patch and it's failing
for me:

 10/401 qemu:qtest+qtest-x86_64 / qtest-x86_64/ahci-test                    TIMEOUT        150.02s   killed by signal 15 SIGTERM
133/401 qemu:unit / test-aio                                                TIMEOUT         30.01s   killed by signal 15 SIGTERM
137/401 qemu:unit / test-bdrv-drain                                         TIMEOUT         30.01s   killed by signal 15 SIGTERM
142/401 qemu:unit / test-block-iothread                                     TIMEOUT         30.01s   killed by signal 15 SIGTERM
192/401 qemu:doc+rust / rust-bql-rs-doctests                                FAIL             0.84s   exit status 101
311/401 qemu:block / io-qcow2-267                                           ERROR            3.20s   exit status 1
321/401 qemu:block / io-qcow2-copy-before-write                             TIMEOUT        180.01s   killed by signal 15 SIGTERM

Some of them look unrelated, but I have confirmed that the three unit
tests still pass before this patch (and still hang after the complete
series).

Kevin