All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Emil Tsalapatis <emil@etsalapatis.com>
Cc: Emil Tsalapatis <etsal@meta.com>,
	tj@kernel.org, void@manifault.com, changwoo@igalia.com,
	sched-ext@lists.linux.dev, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] sched_ext: defer queue_balance_callback() until after ops.dispatch
Date: Thu, 9 Oct 2025 23:57:58 +0200	[thread overview]
Message-ID: <aOgv5h8NGh_IrzDB@gpd4> (raw)
In-Reply-To: <CABFh=a5bjhVNbaKE42OYCVoMDV_FQiaWOq8J2Fm8HBC97JVsvg@mail.gmail.com>

On Thu, Oct 09, 2025 at 05:53:41PM -0400, Emil Tsalapatis wrote:
...
> How about the following to avoid nesting:
> 
> if (!(rq->scx.flags & SCX_RQ_BAL_CB_PENDING))
>     return;
> 
> queue_balance_callback(rq, &rq->scx.deferred_bal_cb, deferred_bal_cb_workfn);
> rq->scx.flags &= ~SCX_RQ_BAL_CB_PENDING;
> 

Looks good. With all the fixes you can add my:

Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks,
-Andrea

      reply	other threads:[~2025-10-09 21:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 17:36 [PATCH] sched_ext: defer queue_balance_callback() until after ops.dispatch Emil Tsalapatis
2025-10-09 19:36 ` Andrea Righi
2025-10-09 21:53   ` Emil Tsalapatis
2025-10-09 21:57     ` Andrea Righi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOgv5h8NGh_IrzDB@gpd4 \
    --to=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=etsal@meta.com \
    --cc=kuba@kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.