Re: [PATCH v4 24/27] qapi/accel: Allow to query mshv capabilities

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Oct 10, 2025 at 04:33:12PM +0000, Wei Liu wrote:
> On Fri, Oct 10, 2025 at 04:10:43PM +0200, Paolo Bonzini wrote:
> > On 10/10/25 16:02, Markus Armbruster wrote:
> > > > +{ 'command': 'query-mshv', 'returns': 'MshvInfo' }
> > > 
> > > Mirrors query-kvm.  Okay apart from the Since: issues Daniel pointed
> > > out.
> > 
> > Which I swore I had fixed, but didn't.
> > 
> > > Should we have a generic query-accelerator instead of one query-FOO for
> > > every accelerator FOO?
> > If we want it, it should be query-accelerators with return value {"enabled":
> > "Accelerator", "present": ["Accelerator"]}.
> > 
> > The patch is already merged, but it is pretty self-contained so I have no
> > objection to reverting just this one.
> > 
> 
> Using a generic query-accelerator API should be fine.
> 
> As I understand it, We need this to query MSHV support in libvirt, so we
> need to get this correct before the libvirt patches are merged.
> 
> Just let us know how to proceed.

On the libvirt side, we're happy to deal with either query-mshv/kvm/etc
or a generator query-accelerator.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|