From: Yao Zi <ziyao@disroot.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>,
Kongyang Liu <seashell11234455@gmail.com>
Subject: Re: [PATCH] clk: sophgo: Fix a warning about void returns value
Date: Sat, 11 Oct 2025 03:09:01 +0000 [thread overview]
Message-ID: <aOnKTWV0O2p1y5lW@pie> (raw)
In-Reply-To: <20251001203057.2828531-1-trini@konsulko.com>
On Wed, Oct 01, 2025 at 02:30:57PM -0600, Tom Rini wrote:
> The cv1800b_clk_setfield function returns void, but was doing "return
> writel(...);" and while seemingly having a void function return a void
> function is not a warning, when readl is a macro this problem is shown.
> Correct the code to instead simply call writel.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Yao Zi <ziyao@disroot.org>
milkv_duo_defconfig builds fine with this patch.
Regards,
Yao Zi
prev parent reply other threads:[~2025-10-11 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 20:30 [PATCH] clk: sophgo: Fix a warning about void returns value Tom Rini
2025-10-11 3:09 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOnKTWV0O2p1y5lW@pie \
--to=ziyao@disroot.org \
--cc=lukma@denx.de \
--cc=seanga2@gmail.com \
--cc=seashell11234455@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.