Re: [PATCH] usb: Implement proper subclass protocol translation

[ShiHao <i.shihao.999@gmail.com>]

On Fri, Oct 10, 2025 at 11:07:03AM -0400, Alan Stern wrote:
> The spacing in this text is strange -- double spaces in random places, 
> no space following the first '.' in the last paragraph, and an extra 
> space before the second '.'.  Also, strange capitalization of the word 
> "It" in two places.
>
Hi Alan,

thanks for the review  and suggestions .  I have updated  the commit 
message body removed double spaces and over cappitalization of i

> > -		/* FIXME: we must do the protocol translation here */
> > +		/* Protocol translation per scsi opcode group */
> 
> This comment should be different.  The "per scsi opcode group" will be 
> mentioned in another comment a few lines later; it's not needed here as 
> well.
 
also added new comment for the protocol translation 
as you said to make it different from earlier as per op
code comment.

> >  		if (us->subclass == USB_SC_RBC || us->subclass == USB_SC_SCSI ||
> > -				us->subclass == USB_SC_CYP_ATACB)
> > -			srb->cmd_len = 6;
> > -		else
> > +		    us->subclass == USB_SC_CYP_ATACB) {
> 
> Please don't change the existing indentation.

I changed the pervious indentaion as  greg k-h told me to
do so he said to check checkpatch.pl script errors which said 
alignment should match open parenthesis  thats why i placed it
under the open parenthesis and it does not have any  checkpatch.pl 
error so far . I have checked it with the argument --strict too .
Changing the line from open parenthesis triggers checkpatch.pl 
error.

> > +			else
> > +				srb->cmd_len = 6;
> > +		} else {
> 
> And you could add a comment here explaining that the other protocols use 
> a fixed value for the command length.
> 
> >  			srb->cmd_len = 12;
> > +		}

Thanks for the suggestion of this new comment i have added it 
in the second version please check the above changes in the updated 
version and if there is anything wrong please let me know i am ready 
to make any further changes and  again thanks for you review and suggestions 
on this matter . Thanks for giving your precious time to this matter . Thank you 
so much.