From: Ryan Chung <seokwoo.chung130@gmail.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
shuah@kernel.org, hca@linux.ibm.com, corbet@lwn.net,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/5] docs: tracing: fprobe: document list filters and :entry/:exit
Date: Sun, 12 Oct 2025 23:40:21 +0900 [thread overview]
Message-ID: <aOu91W3GegRiK8Pg@gmail.com> (raw)
In-Reply-To: <20251008100611.6fb5f0b9d49c9d0c403e2670@kernel.org>
On Wed, Oct 08, 2025 at 10:06:11AM +0900, Masami Hiramatsu wrote:
> On Sun, 5 Oct 2025 08:46:55 +0900
> Ryan Chung <seokwoo.chung130@gmail.com> wrote:
>
> > Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
> > ---
> > Documentation/trace/fprobetrace.rst | 27 +++++++++++++++++++++------
> > 1 file changed, 21 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/trace/fprobetrace.rst b/Documentation/trace/fprobetrace.rst
> > index b4c2ca3d02c1..629e2d7402bd 100644
> > --- a/Documentation/trace/fprobetrace.rst
> > +++ b/Documentation/trace/fprobetrace.rst
> > @@ -25,21 +25,36 @@ Synopsis of fprobe-events
> > -------------------------
> > ::
> >
> > - f[:[GRP1/][EVENT1]] SYM [FETCHARGS] : Probe on function entry
> > - f[MAXACTIVE][:[GRP1/][EVENT1]] SYM%return [FETCHARGS] : Probe on function exit
> > - t[:[GRP2/][EVENT2]] TRACEPOINT [FETCHARGS] : Probe on tracepoint
> > + # fprobe (function entry/exit)
> > + f[:[GRP1/][EVENT1]] SYM_OR_LIST[:entry|:exit] [FETCHARGS]
> > +
> > + # legacy single-symbol exit
> > + f[MAXACTIVE][:[GRP1/][EVENT1]] SYM%return [FETCHARGS]
> > +
> > + # Probe on tracepoint
> > + t[:[GRP2/][EVENT2]] TRACEPOINT [FETCHARGS]
> >
> > GRP1 : Group name for fprobe. If omitted, use "fprobes" for it.
> > GRP2 : Group name for tprobe. If omitted, use "tracepoints" for it.
> > - EVENT1 : Event name for fprobe. If omitted, the event name is
> > - "SYM__entry" or "SYM__exit".
> > + EVENT1 : Event name for fprobe. If omitted,
> > + - For a single literal symbol, the event name is
> > + "SYM__entry" or "SYM__exit".
> > + - For a *list or any wildcard*, an explicit [GRP1/][EVENT1]
> > + is required; otherwise the parser rejects it.
> > EVENT2 : Event name for tprobe. If omitted, the event name is
> > the same as "TRACEPOINT", but if the "TRACEPOINT" starts
> > with a digit character, "_TRACEPOINT" is used.
> > MAXACTIVE : Maximum number of instances of the specified function that
> > can be probed simultaneously, or 0 for the default value
> > as defined in Documentation/trace/fprobe.rst
> > -
> > + SYM_OR_LIST : Either a single symbol, or a comma-separated list of
> > + include/exclude patterns:
> > + - Tokens are matched as symbols; wildcards may be used.
> > + - Tokens prefixed with '!' are exclusions.
> > + - Examples:
> > + foo # single literal (entry)
> > + foo:exit # single literal exit
> > + foo%return # legacy single-symbol exit
>
> So you can explain it in syntax formats:
>
> Single function (including wildcard):
>
> f[:[GRP1/][EVENT1]] SYM[%return] [FETCHARGS]
>
> Multiple functions:
>
> f[:[GRP1/]EVENT3 SYM[,[!]SYM[,...]][:entry|:exit] [FETCHARGS]
>
> Where,
> - SYM prefixed with '!' are exclusions.
> - ":entry" suffix means it probes entry of given symbols. (default)
> - ":exit" suffix means it probes exit of given symbols.
> - "%return" suffix means it probes exit of SYM (single symbol).
>
> Thank you,
>
>
> > FETCHARGS : Arguments. Each probe can have up to 128 args.
> > ARG : Fetch "ARG" function argument using BTF (only for function
> > entry or tracepoint.) (\*1)
> > --
> > 2.43.0
> >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>o
Hi Masami. Thank you for your coments. I will fold this into v4 and make
sure examples and naming rules match the behavior. Thanks for the
guidance.
Best regards,
Ryan Chung
next prev parent reply other threads:[~2025-10-12 14:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 23:46 [PATCH v3 0/5] tracing: fprobe: list-style filters, Ryan Chung
2025-10-04 23:46 ` [PATCH v3 1/5] docs: tracing: fprobe: document list filters and :entry/:exit Ryan Chung
2025-10-08 1:06 ` Masami Hiramatsu
2025-10-12 14:40 ` Ryan Chung [this message]
2025-10-04 23:46 ` [PATCH v3 2/5] tracing: fprobe: require explicit [GROUP/]EVENT for list/wildcard Ryan Chung
2025-10-08 0:53 ` Masami Hiramatsu
2025-10-12 14:32 ` Ryan Chung
2025-10-04 23:46 ` [PATCH v3 3/5] tracing: fprobe: support comma-separated symbols and :entry/:exit Ryan Chung
2025-10-08 10:09 ` Masami Hiramatsu
2025-10-12 14:19 ` Ryan Chung
2025-10-10 15:10 ` kernel test robot
2025-10-10 15:52 ` kernel test robot
2025-10-04 23:46 ` [PATCH v3 4/5] selftests/ftrace: dynevent: add reject cases for list/:entry/:exit Ryan Chung
2025-10-04 23:46 ` [PATCH v3 5/5] selftests/ftrace: dynevent: add reject cases Ryan Chung
2025-10-08 0:51 ` [PATCH v3 0/5] tracing: fprobe: list-style filters, Masami Hiramatsu
2025-10-12 1:49 ` Ryan Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOu91W3GegRiK8Pg@gmail.com \
--to=seokwoo.chung130@gmail.com \
--cc=corbet@lwn.net \
--cc=hca@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.