From: Niklas Cassel <cassel@kernel.org>
To: Markus Probst <markus.probst@posteo.de>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] scsi: sd: Add manage_restart device attribute to scsi_disk
Date: Mon, 13 Oct 2025 09:45:48 +0200 [thread overview]
Message-ID: <aOyuLCEDJxJS76nN@ryzen> (raw)
In-Reply-To: <20251010223817.729490-2-markus.probst@posteo.de>
On Fri, Oct 10, 2025 at 10:38:34PM +0000, Markus Probst wrote:
> In addition to the already existing manage_shutdown,
> manage_system_start_stop and manage_runtime_start_stop device
> scsi_disk attributes, add manage_restart, which allows the high-level
> device driver (sd) to manage the device power state for SYSTEM_RESTART if set to 1.
The commit message explains what is done, but does not answer the question:
"why?"
I can read patch 2/2 and understand why, but considering that this is a patch
for SCSI and not ATA, I think that you need to provide some context here, so
that someone doing a git log drivers/scsi/ will actually have any idea of why
this was done.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-10-13 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 22:38 [PATCH v3 0/2] Support power resources defined in acpi on ata Markus Probst
2025-10-10 22:38 ` [PATCH v3 1/2] scsi: sd: Add manage_restart device attribute to scsi_disk Markus Probst
2025-10-13 7:45 ` Niklas Cassel [this message]
2025-10-10 22:38 ` [PATCH v3 2/2] ata: Use ACPI methods to power on disks Markus Probst
2025-10-13 8:20 ` Niklas Cassel
2025-10-13 12:29 ` Markus Probst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOyuLCEDJxJS76nN@ryzen \
--to=cassel@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.