From: Niklas Cassel <cassel@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ntb@lists.linux.dev, imx@lists.linux.dev
Subject: Re: [PATCH v5 2/4] PCI: endpoint: Add helper function pci_epf_get_bar_required_size()
Date: Mon, 13 Oct 2025 11:04:43 +0200 [thread overview]
Message-ID: <aOzAqwFysJ0d5zMr@ryzen> (raw)
In-Reply-To: <20251009-vntb_msi_doorbell-v5-2-4cfb7b6c4be1@nxp.com>
On Thu, Oct 09, 2025 at 04:54:36PM -0400, Frank Li wrote:
> Introduce pci_epf_get_bar_required_size() to retrieve the required BAR
> size and memory size. Prepare for adding support to set an MMIO address to
> a specific BAR.
>
> Use two variables 'size' and 'aligned_mem_size' to avoid confuse.
Nit: I still think this is wrong. Probably:
Use two parameters 'bar_size' and 'aligned_mem_size' to avoid confusion.
>
> No functional changes.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-10-13 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 20:54 [PATCH v5 0/4] pci: endpoint: vntb: add MSI doorbell support Frank Li
2025-10-09 20:54 ` [PATCH v5 1/4] PCI: endpoint: Rename aligned_size to mem_size Frank Li
2025-10-13 9:01 ` Niklas Cassel
2025-10-09 20:54 ` [PATCH v5 2/4] PCI: endpoint: Add helper function pci_epf_get_bar_required_size() Frank Li
2025-10-13 9:04 ` Niklas Cassel [this message]
2025-10-09 20:54 ` [PATCH v5 3/4] PCI: endpoint: Add API pci_epf_assign_bar_space() Frank Li
2025-10-09 20:54 ` [PATCH v5 4/4] PCI: endpoint: pci-epf-vntb: Add MSI doorbell support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOzAqwFysJ0d5zMr@ryzen \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.