All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: eugene.loh@oracle.com
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH v2] Bump up the version to 2.0.4
Date: Mon, 27 Oct 2025 14:36:25 -0400	[thread overview]
Message-ID: <aP+7qVE1WHjnSrmp@oracle.com> (raw)
In-Reply-To: <20251027022737.23921-1-eugene.loh@oracle.com>

On Sun, Oct 26, 2025 at 10:27:37PM -0400, eugene.loh@oracle.com wrote:
> From: Eugene Loh <eugene.loh@oracle.com>
> 
> Note that test/unittest/preprocessor/tst.predefined.sh checks that the
> __SUNW_D_VERSION preprocessor symbol is consistent with the "dtrace -vV"
> message, and both of them simply use the last entry of versions.list and
> therefore will be consistent for in-tree builds.
> 
> When RPM packages are built from the .spec file, however, _DT_VERSION,
> used for the "dtrace -vV" "This is" message, comes from the .spec file.
> 
> Append a 2.0.4 entry to versions.list.
> 
> Remove the VERSION=%{version} from dtrace.spec build's make line, so
> that the version of the implementation is defined by the source code
> itself.  The version in the spec file should be only the version of the
> packaging.
>
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  dtrace.spec             | 3 +--
>  libdtrace/versions.list | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/dtrace.spec b/dtrace.spec
> index a4f3ed774..e94025472 100644
> --- a/dtrace.spec
> +++ b/dtrace.spec
> @@ -131,8 +131,7 @@ it always tests the installed DTrace.
>  %setup -q
>  
>  %build
> -make -j $(getconf _NPROCESSORS_ONLN) VERSION=%{version} \
> -	%{bpfc} %{maybe_use_fuse2}
> +make -j $(getconf _NPROCESSORS_ONLN) %{bpfc} %{maybe_use_fuse2}
>  
>  # Force off debuginfo splitting.  We have no debuginfo in dtrace proper,
>  # and the testsuite requires debuginfo for proper operation.
> diff --git a/libdtrace/versions.list b/libdtrace/versions.list
> index 8986d2007..8d858f0bd 100644
> --- a/libdtrace/versions.list
> +++ b/libdtrace/versions.list
> @@ -65,3 +65,4 @@
>  2.0.1	D API 2.0.1 Linux (BPF)
>  2.0.2	D API 2.0.2 Linux (BPF)
>  2.0.3	D API 2.0.3 Linux (BPF)
> +2.0.4	D API 2.0.4 Linux (BPF)
> -- 
> 2.47.3
> 

  reply	other threads:[~2025-10-27 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  2:27 [PATCH v2] Bump up the version to 2.0.4 eugene.loh
2025-10-27 18:36 ` Kris Van Hees [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-27 18:25 [PATCH v2] Add more Orabugs to dtrace.spec eugene.loh
2025-10-27 18:25 ` [PATCH v2] Bump up the version to 2.0.4 eugene.loh
2025-10-27 18:29   ` Eugene Loh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aP+7qVE1WHjnSrmp@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.