From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 277F8CCF9EE for ; Mon, 27 Oct 2025 18:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Owj5CCn3c5rCvXqGyRhngx9bYmf6UT3ZnFEy1LJWf9I=; b=A4T1ZTghE/XMvFGKQj1bBKjW+K BqPAOwWdTWz8QwuuHtidTpft6+wWPlbXFrC+npXzCBvnoLTPC4yJuH0v2zgPTIXrd1OaRymanhaEX a++pCbyqUHCSY6lCfQOU+OrzYu8tDog7dKOiHIKsafhj49zZpbLGNOJNUTN6zaM4JU1fnZQotwM9z fLMEiMq8jRDd+9+niQ7VNWjsNENmh+pZTc6xX2Ce3dqrvFPRoE6Yemy9lAWdQdgXEw32tX0vqs7Ot bFDJFGgD34L8nLU7DEeoqqgxgnUmWXjZsIx9C+KwBVvdNm34X9gra8e+Lxmyx8vrOnrEOBAH8BvO9 zvnuV3ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDRgH-0000000EWIu-3UmW; Mon, 27 Oct 2025 18:10:57 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDRgD-0000000EWH0-1izQ for kvm-riscv@lists.infradead.org; Mon, 27 Oct 2025 18:10:56 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-33d8970ae47so4450847a91.1 for ; Mon, 27 Oct 2025 11:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761588652; x=1762193452; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=1Og0Ub/H7o2Birmhj8bbqS/728j3jMYI0HMQFkTpgNnPYKOONW3q/lbNJt5iNz4tl7 J2hsqtBUOBSUvWfiXThaG/UIVP6XDFQeslR1ZmrVBPOp7h7Dg/uE3Sl/8vxFU+vE6sWe iP2ssH1fHNxNsoNLKiNa6/X5Nr0ptoNLOvZmlL90BMcZqzBHMUunYixFohGUWovR2e5X o5KUCO1N3wxwbxPYDG/qZNF4TBvnzHjN/9kawGmCRGZq6kfoeugPQmTSLGODWKbsi54m WHvUNsWUKFgFca7E43zTmG8ERYnTc4Cv825ZxnHZjih+ct43aT+/dpENQ8jBDnZDWp2U tXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761588652; x=1762193452; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=i5n3XipuxlPDUKBn7EbOmF1GF+ButquboBMzrQ9r92NSDQB4xSq4S0AdKQGm9B/++6 O0ISyLPtHle1xO/2uiOTyntRVc0buP3kgAE+t/g6ZSP+L8CcDWTvB/XduMFh1EC2Gv1h S7iSpmlRNj2AgSg80iJgQLvDFMMIUO9xeUixeXfj+gR0zqB3Iio2CeriISFNdb6HgfS9 6foQdNi4gJ/gdRgp7oK37X7OCjvuB9YO6zFoDegN38ktFV3RoUCc+yebxlhoYpt85Y6r /ew7DmXMKoEUEsu0Nq8WUUXKkYq8EeyEzyTlmpADgWdOIZqPIK0cYpV6xFzmFClyq/+8 +eaQ== X-Forwarded-Encrypted: i=1; AJvYcCVB8l9WCBfjMzXy9bjc5J4oQ1aBZ8Fh70N/H6XSkrlbxZFWRtWrPV5NzDMaRsxeRiIUy+fNjPiwR9A=@lists.infradead.org X-Gm-Message-State: AOJu0Yw7da6VewdkUJmTr77vdVFwn00g0jMiVIASaTBBFh0kNQ7sMmfR M0g38EVIiuRCQfySapdfsu6Vc06rwolDcRiDsim5XXCipaVTQAGFWbjM06ViWqG9qVnBwZd4jtT 6Jl+tPA== X-Google-Smtp-Source: AGHT+IFYM0pQ56UGeUzsOnJj3+Ow3Uhx6HMXZ6WjKUcRvfRsyB3bsUItowqHfr7m0JixZWoiV89rDaaCMlA= X-Received: from pjbrs15.prod.google.com ([2002:a17:90b:2b8f:b0:33b:51fe:1a73]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4f81:b0:32e:52aa:3973 with SMTP id 98e67ed59e1d1-340279e5fc5mr862252a91.8.1761588651707; Mon, 27 Oct 2025 11:10:51 -0700 (PDT) Date: Mon, 27 Oct 2025 11:10:50 -0700 In-Reply-To: <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Rick P Edgecombe Cc: Yan Y Zhao , "borntraeger@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "michael.roth@amd.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "x86@kernel.org" , "chenhuacai@kernel.org" , "aou@eecs.berkeley.edu" , Vishal Annapurve , "binbin.wu@linux.intel.com" , "maddy@linux.ibm.com" , "maobibo@loongson.cn" , "maz@kernel.org" , "linux-coco@lists.linux.dev" , "anup@brainfault.org" , Kai Huang , "frankja@linux.ibm.com" , "pjw@kernel.org" , "zhaotianrui@loongson.cn" , "ackerleytng@google.com" , "linux-arm-kernel@lists.infradead.org" , Ira Weiny , "loongarch@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kas@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_111053_459478_62F9330D X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMjcsIDIwMjUsIFJpY2sgUCBFZGdlY29tYmUgd3JvdGU6Cj4gT24gTW9uLCAy MDI1LTEwLTI3IGF0IDE3OjI2ICswODAwLCBZYW4gWmhhbyB3cm90ZToKPiA+ID4gVWdoLCBJJ2Qg cmF0aGVyIG5vdD/CoCBSZWZyZXNoIG1lLCB3aGF0J3MgdGhlIHN0b3J5IHdpdGggInYxIj/CoCBB cmUgd2Ugbm93IG9uCj4gPiA+IHYyPwo+ID4gTm8uLi4gV2UgYXJlIG5vdyBvbiB2MS4KPiA+IEFz IGluIFsxXSwgSSBmb3VuZCB0aGF0IFREWCBtb2R1bGUgY2hhbmdlZCBTRUFNQ0FMTCBUREhfVlBf SU5JVCBiZWhhdmlvciB0bwo+ID4gcmVxdWlyZSBleGNsdXNpdmUgbG9jayBvbiByZXNvdXJjZSBU RFIgd2hlbiBsZWFmX29wY29kZS52ZXJzaW9uID4gMC4KPiA+IAo+ID4gVGhlcmVmb3JlLCB3ZSBt b3ZlZCBLVk1fVERYX0lOSVRfVkNQVSB0byB0ZHhfdmNwdV91bmxvY2tlZF9pb2N0bCgpIGluIHBh dGNoCj4gPiAyMi4KPiA+IAo+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC9hTGEz NFFDSkNYR0xrJTJGZmxAeXpoYW81Ni1kZXNrLnNoLmludGVsLmNvbS8KPiAKPiBMb29raW5nIGF0 IHRoZSBQREYgZG9jcywgVERSIGV4Y2x1c2l2ZSBsb2NraW5nIGluIHZlcnNpb24gPT0gMSBpcyBj YWxsZWQgb3V0IGF0Cj4gbGVhc3QgYmFjayB0byB0aGUgb2xkZXN0IEFCSSBkb2NzIEkgaGF2ZSAo TWFyY2ggMjAyNCkuIE5vdCBzdXJlIGFib3V0IHRoZQo+IGFzc2VydGlvbiB0aGF0IHRoZSBiZWhh dmlvciBjaGFuZ2VkLCBidXQgaWYgaW5kZWVkIHRoaXMgd2FzIGRvY3VtZW50ZWQsIGl0J3MgYQo+ IGxpdHRsZSBiaXQgb3VyIGJhZC4gV2UgbWlnaHQgY29uc2lkZXIgYmVpbmcgZmxleGlibGUgYXJv dW5kIGNhbGxpbmcgaXQgYSBURFggQUJJCj4gYnJlYWs/Cj4gCj4gU2VhbiwgY2FuIHlvdSBlbGFi b3JhdGUgd2h5IHRha2luZyBtbXVfbG9jayBpcyBvYmplY3Rpb25hYmxlIGhlcmUsIHRob3VnaD8K Ckl0J3Mgbm90LCBJIHdhcyBqdXN0IGhvcGluZyB3ZSBjb3VsZCBhdm9pZCB5ZXQgbW9yZSBjb21w bGV4aXR5LgoKQXNzdW1pbmcgd2UgZG8gaW5kZWVkIG5lZWQgdG8gdGFrZSBtbXVfbG9jaywgY2Fu IHlvdSBzZW5kIGEgcGF0Y2ggdGhhdCBhcHBsaWVzCm9uIHRvcD8gIEknbSBub3QgcGxhbm5pbmcg b24gc2VuZGluZyBhbnkgb2YgdGhpcyB0byBzdGFibGVALCBzbyBJIGRvbid0IHNlZSBhbnkKcmVh c29uIHRvIHRyeSBhbmQganVnZ2xlIHBhdGNoZXMgYXJvdW5kLgoKPiBOb3RlLCBteXNlbGYgKGFu ZCBJIHRoaW5rIFlhbj8pIGRldGVybWluZWQgdGhlIGxvY2tpbmcgYnkgZXhhbWluaW5nIFREWCBt b2R1bGUKPiBzb3VyY2UuIEZvciBteXNlbGYsIGl0J3MgcG9zc2libGUgSSBtaXNyZWFkIHRoZSBs b2NraW5nIG9yaWdpbmFsbHkuCj4gCj4gQWxzbywgSSdtIG5vdCBzdXJlIGFib3V0IHN3aXRjaGlu ZyBnZWFycyBhdCB0aGlzIHBvaW50LCBidXQgaXQgbWFrZXMgbWUgd29uZGVyCj4gYWJvdXQgdGhl IHByZXZpb3VzbHkgZGlzY3Vzc2VkIG9wdGlvbiBvZiB0cnlpbmcgdG8ganVzdCBkdXBsaWNhdGUg dGhlIFREWCBsb2Nrcwo+IG9uIHRoZSBrZXJuZWwgc2lkZS4KClBsZWFzZSBuby4gIEF0IGJlc3Qg dGhhdCB3aWxsIHlpZWxkIGEgcGlsZSBvZiBlZmZlY3RpdmVseSB1c2VsZXNzIGNvZGUuICBBdCB3 b3JzdCwKaXQgd2lsbCBtYWtlIHVzIGxhenkgYW5kIGxlYWQgdG8gcmVhbCBidWdzIGJlY2F1c2Ug d2UgZG9uJ3QgcHJvcGVyeSBndWFyZCB0aGUgKktWTSoKZmxvd3MgdGhhdCBuZWVkIGV4Y2x1c2l2 aXR5IHJlbGF0aXZlIHRvIHdoYXQgaXMgZ29pbmcgb24gaW4gdGhlIFREWC1Nb2R1bGUuCgo+IE9y IHBlcmhhcHMgbWFrZSBzb21lIGtpbmQgb2YgZGVidWcgdGltZSBsb2NrZGVwIHR5cGUgdGhpbmcg dG8gZG9jdW1lbnQvY2hlY2sKPiB0aGUgYXNzdW1wdGlvbnMgaW4gdGhlIGtlcm5lbC4gU29tZXRo aW5nIGFsb25nIHRoZSBsaW5lcyBvZiB0aGlzIHBhdGNoLCBidXQKPiB0byBtYXAgdGhlIFREWCBs b2NrcyB0byBLVk0gbG9ja3Mgb3Igc29tZXRoaW5nLiBBcyB3ZSBhZGQgbW9yZSB0aGluZ3MgKERQ QU1ULAo+IGV0YyksIGl0IGRvZXNuJ3Qgc2VlbSBsaWtlIHRoZSBURFggbG9ja2luZyBpcyBnZXR0 aW5nIHRhbWVyLi4uCgpIbW0sIEkgbGlrZSB0aGUgaWRlYSwgYnV0IGFjdHVhbGx5IGdldHRpbmcg bWVhbmluZ2Z1bCBjb3ZlcmFnZSBjb3VsZCBiZSBxdWl0ZQpkaWZmaWN1bHQuCgotLSAKa3ZtLXJp c2N2IG1haWxpbmcgbGlzdAprdm0tcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2t2bS1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7983D31960D for ; Mon, 27 Oct 2025 18:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588654; cv=none; b=Erxm42Jr5ZJ5Ixkb3D555Gv7PaOpRfFF2EsDzVP7OpqAyqZ/WGLsQ18RbwyL149scY8+XOumjFEUqGz2l0Pvh56po6ckRd1PSu5jceNTz3PHiC3wU7Yavk+6PUWirFvCOOxTFHSZ+8CUIR/+D3B/4f3O/qwX3glKuLUsaL5SpVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588654; c=relaxed/simple; bh=qWDqTHSGtqyDCU4AAlHRJ9mq1s1hvPRErQWu8I/AXzI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=besXoQUZaBo8GS3xm2VXQhcCfANbS6INj1lQk0ZunNDFX8ODKQOsofRFao5xdz+z18ZozcuyMpC6JknBfkbaeB8vLTh70lgQ5b5/QzNJ/Kngod0z6llQPRqNzkoby3gtnC6jcBe3BzwMxz5SVExPEUxhYrfW+y3+hmjsqYQ0gXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HuCGleei; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HuCGleei" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-33d8970ae47so4450843a91.1 for ; Mon, 27 Oct 2025 11:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761588652; x=1762193452; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=HuCGleeiQ5Vxy5Vm6iVJmpzhZDeJqlXsJ4ydurVEc9/ZGzkVMS4db2w0kFx5bkp/U8 3gR7DX2O+HFR0p19vdYCebpHLNlkyGiR4JU01K6YP5KmrV4ULoCZui6X30jTohAs1pR5 S8y1o315i2d1AHoziPTQ6hNOKr1UWSBVZDUaedQC+XAfG9WiRhHrACSpjtwPAbYpGjod rh7auUeEvfA/zOpnenjrJy0niGuH+NNaqewEcSB4YsA4uUOqvI8d9v6LFzMBHXzqXWtb 8ugXSA423oiRRcjmHFyCZb8qhHiMaEzygqYmtwBbfTI0I9CEYpBbWUCvEKDuQt4wzijK 9iyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761588652; x=1762193452; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=uX7FOpMNsjfHI2U1qUx2LzlTXlspR1FhDp80Q0/4/4Yg3W5wiVik2RjnEAgNPCuGm8 kE2Qv8N6II9FAxfDqQMXxgu3y24IuJo0srRY+eSPeB609wQqHUQOQU+pLoOezvX3lcB9 53c2w8eSIZ7D7RKXhoNNTki3zfQzlPZwke9/nxQuPo+Pu6qTvocS5TXf2ikDoUnlbzNi aKkr3ZcLE9eMVpouxBArSJaQPo4DQOUsnfzg+U3SBYm9v80/yjsShALn+quuVbvHiWyV St6Pjb1WCUdGNIrbbUO7RAKOXH4ed0MQwBb569IAlmwCOhNq44SnnvV3qAYavcMi2GMk 5YZw== X-Forwarded-Encrypted: i=1; AJvYcCWsmy3rVcHpst3ZEVPsShFFFiol1DxFeFbqhXY4CYYCiWeauxopmaFWGC3JRKUoipFFzo4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu1khu90idWsi/eK9IY4NKFSxOnGBnCyRDuALFD2kBRxHCFVMi QU7w46IJa+U9/vzd3HMxRcCprvkNMAeWI3pQ2UbGRAw48gFZ4HcuOSkPKdzxPqVZPnT5N+Q2XUx kY3RzXg== X-Google-Smtp-Source: AGHT+IFYM0pQ56UGeUzsOnJj3+Ow3Uhx6HMXZ6WjKUcRvfRsyB3bsUItowqHfr7m0JixZWoiV89rDaaCMlA= X-Received: from pjbrs15.prod.google.com ([2002:a17:90b:2b8f:b0:33b:51fe:1a73]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4f81:b0:32e:52aa:3973 with SMTP id 98e67ed59e1d1-340279e5fc5mr862252a91.8.1761588651707; Mon, 27 Oct 2025 11:10:51 -0700 (PDT) Date: Mon, 27 Oct 2025 11:10:50 -0700 In-Reply-To: <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Rick P Edgecombe Cc: Yan Y Zhao , "borntraeger@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "michael.roth@amd.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "x86@kernel.org" , "chenhuacai@kernel.org" , "aou@eecs.berkeley.edu" , Vishal Annapurve , "binbin.wu@linux.intel.com" , "maddy@linux.ibm.com" , "maobibo@loongson.cn" , "maz@kernel.org" , "linux-coco@lists.linux.dev" , "anup@brainfault.org" , Kai Huang , "frankja@linux.ibm.com" , "pjw@kernel.org" , "zhaotianrui@loongson.cn" , "ackerleytng@google.com" , "linux-arm-kernel@lists.infradead.org" , Ira Weiny , "loongarch@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kas@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 27, 2025, Rick P Edgecombe wrote: > On Mon, 2025-10-27 at 17:26 +0800, Yan Zhao wrote: > > > Ugh, I'd rather not?=C2=A0 Refresh me, what's the story with "v1"?=C2= =A0 Are we now on > > > v2? > > No... We are now on v1. > > As in [1], I found that TDX module changed SEAMCALL TDH_VP_INIT behavio= r to > > require exclusive lock on resource TDR when leaf_opcode.version > 0. > >=20 > > Therefore, we moved KVM_TDX_INIT_VCPU to tdx_vcpu_unlocked_ioctl() in p= atch > > 22. > >=20 > > [1] https://lore.kernel.org/all/aLa34QCJCXGLk%2Ffl@yzhao56-desk.sh.inte= l.com/ >=20 > Looking at the PDF docs, TDR exclusive locking in version =3D=3D 1 is cal= led out at > least back to the oldest ABI docs I have (March 2024). Not sure about the > assertion that the behavior changed, but if indeed this was documented, i= t's a > little bit our bad. We might consider being flexible around calling it a = TDX ABI > break? >=20 > Sean, can you elaborate why taking mmu_lock is objectionable here, though= ? It's not, I was just hoping we could avoid yet more complexity. Assuming we do indeed need to take mmu_lock, can you send a patch that appl= ies on top? I'm not planning on sending any of this to stable@, so I don't see= any reason to try and juggle patches around. > Note, myself (and I think Yan?) determined the locking by examining TDX m= odule > source. For myself, it's possible I misread the locking originally. >=20 > Also, I'm not sure about switching gears at this point, but it makes me w= onder > about the previously discussed option of trying to just duplicate the TDX= locks > on the kernel side. Please no. At best that will yield a pile of effectively useless code. At= worst, it will make us lazy and lead to real bugs because we don't propery guard t= he *KVM* flows that need exclusivity relative to what is going on in the TDX-Module. > Or perhaps make some kind of debug time lockdep type thing to document/ch= eck > the assumptions in the kernel. Something along the lines of this patch, b= ut > to map the TDX locks to KVM locks or something. As we add more things (DP= AMT, > etc), it doesn't seem like the TDX locking is getting tamer... Hmm, I like the idea, but actually getting meaningful coverage could be qui= te difficult. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6410ACCF9E5 for ; Mon, 27 Oct 2025 18:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i5a5igvFbyELYEbsoIaDvmeruLuZhYgrk31i74yDci0=; b=ftsNFiDPGDOtBSsc8dUHO3f437 joH8K3V6T4QTeYAKtB3CshLxxbSNewDBV0oGxxltOX0Wx84KKT0Yq4koisYvIxy9RU60rShR5WB2s /OZ6t6W6qJ1CV8a92orZwjE+kTzSBE8Wqwp5JtTDUzipD5UzoSf/nxG9tFqlck8GjhZjVGQQL22kH u23Z4AapedbPLoRx6athv3VNPvSSBK6xZPTbXVKAPqGF/tl7AXQPmoXRpd9zjzjW0hia8k16vliT/ Bn+rxFLSib41+KP6KwwJdyEAzEWT1J4DiyqmkeMVhTtIvBOp+68w1LOWUXIJyJqWQiSvE6JjYC5VV b9I6MCBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDRgF-0000000EWIP-2DSE; Mon, 27 Oct 2025 18:10:55 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDRgD-0000000EWH1-0OzU for linux-riscv@lists.infradead.org; Mon, 27 Oct 2025 18:10:54 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-33be01bcda8so4745981a91.2 for ; Mon, 27 Oct 2025 11:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761588652; x=1762193452; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=1Og0Ub/H7o2Birmhj8bbqS/728j3jMYI0HMQFkTpgNnPYKOONW3q/lbNJt5iNz4tl7 J2hsqtBUOBSUvWfiXThaG/UIVP6XDFQeslR1ZmrVBPOp7h7Dg/uE3Sl/8vxFU+vE6sWe iP2ssH1fHNxNsoNLKiNa6/X5Nr0ptoNLOvZmlL90BMcZqzBHMUunYixFohGUWovR2e5X o5KUCO1N3wxwbxPYDG/qZNF4TBvnzHjN/9kawGmCRGZq6kfoeugPQmTSLGODWKbsi54m WHvUNsWUKFgFca7E43zTmG8ERYnTc4Cv825ZxnHZjih+ct43aT+/dpENQ8jBDnZDWp2U tXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761588652; x=1762193452; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bO0HNahSQ0zli7kg4xL2kKu/rPaiGOzpKxwGHDcn9b4=; b=K0a436q2JZ8p5BFJBY34Qqk5MNItlLs1sko12YwEH1JPRGkA1vOBvmIj8JPf2GTCsE EZk1jwCt7Qqs0PYjwPgQ/LW/t2Z2l91NS4tOoXSxiEJF6fF9dIlUx8xpMIUsL20j/6kZ Pic6CuiZ3YS6t9HuhE7DV9H6O4NLwRs7XU4n87IxSTj8X4Szws4d4clEQXvpV28qLL+W lS0gwrGKhzLpliaKyCDLC2GKmCGEjzh5hzTPjCSeuSh9AFYGbSEQSISh52To07+iWzvr fvJbkG2v8Y9V+6VlnCJYpTL8tu7iAT8gdBKhUpxf5OBk3sfw7sbxZo4qBA/8ma55qXze +ANQ== X-Forwarded-Encrypted: i=1; AJvYcCUhCXHbBKwDTNfPibwqJdRaRSCzIG+4eYVP+AC0r+y5XY0bZDyoQ5+J3tdOztjG48JJw/y2XpoDNOzQgA==@lists.infradead.org X-Gm-Message-State: AOJu0YxGW11wXIpeAOB/UKG5fspiWslMMYG1svfjNdkCrBwoh6671cKz pn08mas/mnjyG9AGiqaJNgVzfXaC/YP80oF9AOKVZmYyzPh/HyMbzIiXCwLNL6tR9tDp1n9z5QX zZWSGeA== X-Google-Smtp-Source: AGHT+IFYM0pQ56UGeUzsOnJj3+Ow3Uhx6HMXZ6WjKUcRvfRsyB3bsUItowqHfr7m0JixZWoiV89rDaaCMlA= X-Received: from pjbrs15.prod.google.com ([2002:a17:90b:2b8f:b0:33b:51fe:1a73]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4f81:b0:32e:52aa:3973 with SMTP id 98e67ed59e1d1-340279e5fc5mr862252a91.8.1761588651707; Mon, 27 Oct 2025 11:10:51 -0700 (PDT) Date: Mon, 27 Oct 2025 11:10:50 -0700 In-Reply-To: <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> <20251017003244.186495-25-seanjc@google.com> <77d8a0d9541ce3fc2b2c76b58add50d152b52e39.camel@intel.com> Message-ID: Subject: Re: [PATCH v3 24/25] KVM: TDX: Guard VM state transitions with "all" the locks From: Sean Christopherson To: Rick P Edgecombe Cc: Yan Y Zhao , "borntraeger@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "michael.roth@amd.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "x86@kernel.org" , "chenhuacai@kernel.org" , "aou@eecs.berkeley.edu" , Vishal Annapurve , "binbin.wu@linux.intel.com" , "maddy@linux.ibm.com" , "maobibo@loongson.cn" , "maz@kernel.org" , "linux-coco@lists.linux.dev" , "anup@brainfault.org" , Kai Huang , "frankja@linux.ibm.com" , "pjw@kernel.org" , "zhaotianrui@loongson.cn" , "ackerleytng@google.com" , "linux-arm-kernel@lists.infradead.org" , Ira Weiny , "loongarch@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kas@kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_111053_175854_E3242287 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMjcsIDIwMjUsIFJpY2sgUCBFZGdlY29tYmUgd3JvdGU6Cj4gT24gTW9uLCAy MDI1LTEwLTI3IGF0IDE3OjI2ICswODAwLCBZYW4gWmhhbyB3cm90ZToKPiA+ID4gVWdoLCBJJ2Qg cmF0aGVyIG5vdD/CoCBSZWZyZXNoIG1lLCB3aGF0J3MgdGhlIHN0b3J5IHdpdGggInYxIj/CoCBB cmUgd2Ugbm93IG9uCj4gPiA+IHYyPwo+ID4gTm8uLi4gV2UgYXJlIG5vdyBvbiB2MS4KPiA+IEFz IGluIFsxXSwgSSBmb3VuZCB0aGF0IFREWCBtb2R1bGUgY2hhbmdlZCBTRUFNQ0FMTCBUREhfVlBf SU5JVCBiZWhhdmlvciB0bwo+ID4gcmVxdWlyZSBleGNsdXNpdmUgbG9jayBvbiByZXNvdXJjZSBU RFIgd2hlbiBsZWFmX29wY29kZS52ZXJzaW9uID4gMC4KPiA+IAo+ID4gVGhlcmVmb3JlLCB3ZSBt b3ZlZCBLVk1fVERYX0lOSVRfVkNQVSB0byB0ZHhfdmNwdV91bmxvY2tlZF9pb2N0bCgpIGluIHBh dGNoCj4gPiAyMi4KPiA+IAo+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC9hTGEz NFFDSkNYR0xrJTJGZmxAeXpoYW81Ni1kZXNrLnNoLmludGVsLmNvbS8KPiAKPiBMb29raW5nIGF0 IHRoZSBQREYgZG9jcywgVERSIGV4Y2x1c2l2ZSBsb2NraW5nIGluIHZlcnNpb24gPT0gMSBpcyBj YWxsZWQgb3V0IGF0Cj4gbGVhc3QgYmFjayB0byB0aGUgb2xkZXN0IEFCSSBkb2NzIEkgaGF2ZSAo TWFyY2ggMjAyNCkuIE5vdCBzdXJlIGFib3V0IHRoZQo+IGFzc2VydGlvbiB0aGF0IHRoZSBiZWhh dmlvciBjaGFuZ2VkLCBidXQgaWYgaW5kZWVkIHRoaXMgd2FzIGRvY3VtZW50ZWQsIGl0J3MgYQo+ IGxpdHRsZSBiaXQgb3VyIGJhZC4gV2UgbWlnaHQgY29uc2lkZXIgYmVpbmcgZmxleGlibGUgYXJv dW5kIGNhbGxpbmcgaXQgYSBURFggQUJJCj4gYnJlYWs/Cj4gCj4gU2VhbiwgY2FuIHlvdSBlbGFi b3JhdGUgd2h5IHRha2luZyBtbXVfbG9jayBpcyBvYmplY3Rpb25hYmxlIGhlcmUsIHRob3VnaD8K Ckl0J3Mgbm90LCBJIHdhcyBqdXN0IGhvcGluZyB3ZSBjb3VsZCBhdm9pZCB5ZXQgbW9yZSBjb21w bGV4aXR5LgoKQXNzdW1pbmcgd2UgZG8gaW5kZWVkIG5lZWQgdG8gdGFrZSBtbXVfbG9jaywgY2Fu IHlvdSBzZW5kIGEgcGF0Y2ggdGhhdCBhcHBsaWVzCm9uIHRvcD8gIEknbSBub3QgcGxhbm5pbmcg b24gc2VuZGluZyBhbnkgb2YgdGhpcyB0byBzdGFibGVALCBzbyBJIGRvbid0IHNlZSBhbnkKcmVh c29uIHRvIHRyeSBhbmQganVnZ2xlIHBhdGNoZXMgYXJvdW5kLgoKPiBOb3RlLCBteXNlbGYgKGFu ZCBJIHRoaW5rIFlhbj8pIGRldGVybWluZWQgdGhlIGxvY2tpbmcgYnkgZXhhbWluaW5nIFREWCBt b2R1bGUKPiBzb3VyY2UuIEZvciBteXNlbGYsIGl0J3MgcG9zc2libGUgSSBtaXNyZWFkIHRoZSBs b2NraW5nIG9yaWdpbmFsbHkuCj4gCj4gQWxzbywgSSdtIG5vdCBzdXJlIGFib3V0IHN3aXRjaGlu ZyBnZWFycyBhdCB0aGlzIHBvaW50LCBidXQgaXQgbWFrZXMgbWUgd29uZGVyCj4gYWJvdXQgdGhl IHByZXZpb3VzbHkgZGlzY3Vzc2VkIG9wdGlvbiBvZiB0cnlpbmcgdG8ganVzdCBkdXBsaWNhdGUg dGhlIFREWCBsb2Nrcwo+IG9uIHRoZSBrZXJuZWwgc2lkZS4KClBsZWFzZSBuby4gIEF0IGJlc3Qg dGhhdCB3aWxsIHlpZWxkIGEgcGlsZSBvZiBlZmZlY3RpdmVseSB1c2VsZXNzIGNvZGUuICBBdCB3 b3JzdCwKaXQgd2lsbCBtYWtlIHVzIGxhenkgYW5kIGxlYWQgdG8gcmVhbCBidWdzIGJlY2F1c2Ug d2UgZG9uJ3QgcHJvcGVyeSBndWFyZCB0aGUgKktWTSoKZmxvd3MgdGhhdCBuZWVkIGV4Y2x1c2l2 aXR5IHJlbGF0aXZlIHRvIHdoYXQgaXMgZ29pbmcgb24gaW4gdGhlIFREWC1Nb2R1bGUuCgo+IE9y IHBlcmhhcHMgbWFrZSBzb21lIGtpbmQgb2YgZGVidWcgdGltZSBsb2NrZGVwIHR5cGUgdGhpbmcg dG8gZG9jdW1lbnQvY2hlY2sKPiB0aGUgYXNzdW1wdGlvbnMgaW4gdGhlIGtlcm5lbC4gU29tZXRo aW5nIGFsb25nIHRoZSBsaW5lcyBvZiB0aGlzIHBhdGNoLCBidXQKPiB0byBtYXAgdGhlIFREWCBs b2NrcyB0byBLVk0gbG9ja3Mgb3Igc29tZXRoaW5nLiBBcyB3ZSBhZGQgbW9yZSB0aGluZ3MgKERQ QU1ULAo+IGV0YyksIGl0IGRvZXNuJ3Qgc2VlbSBsaWtlIHRoZSBURFggbG9ja2luZyBpcyBnZXR0 aW5nIHRhbWVyLi4uCgpIbW0sIEkgbGlrZSB0aGUgaWRlYSwgYnV0IGFjdHVhbGx5IGdldHRpbmcg bWVhbmluZ2Z1bCBjb3ZlcmFnZSBjb3VsZCBiZSBxdWl0ZQpkaWZmaWN1bHQuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5n IGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==