All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: Bjorn Andersson <andersson@kernel.org>, Andrew Davis <afd@ti.com>,
	Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] remoteproc: core: misc update
Date: Mon, 27 Oct 2025 09:31:06 -0600	[thread overview]
Message-ID: <aP-QOnTuiEcx9nQK@p14s> (raw)
In-Reply-To: <20251016-rproc-cleanup-v3-v3-0-774083716e8a@nxp.com>

On Thu, Oct 16, 2025 at 07:47:57PM +0800, Peng Fan wrote:
> This patchset is a misc update of remoteproc_core.c.
> Patch 1: Drop a pointless initialization to variable ret
> Patch 2-3: Cleanup the included headers
> Patch 4: Remove export of rproc_va_to_pa
> 
> I am also reviewing the rproc->lock usage and thinking whether we
> need to add a lockdep_assert_held for some functions that should have
> lock held. But not sure.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in v3:
> - Drop patch 4: Use cleanup API. Because there is a deadlock issue
>   reported, need review the lock usage before the cleanup.
> - Drop patch 6 & 7: Use bitfield for bool
> - Add A-b from Andrew
> 
> Changes in v2:
> - Add patch 6 "remoteproc: stm32: Avoid directly taking address of auto_boot"
>   to address stm32_rproc.c build issue
> - Link to v1: https://lore.kernel.org/r/20251005-remoteproc-cleanup-v1-0-09a9fdea0063@nxp.com
> 
> ---
> Peng Fan (4):
>       remoteproc: core: Drop redundant initialization of 'ret' in rproc_shutdown()
>       remoteproc: core: Sort header includes
>       remoteproc: core: Removed unused headers
>       remoteproc: core: Remove unused export of rproc_va_to_pa
>

I have applied this set.

Thanks,
Mathieu
 
>  drivers/remoteproc/remoteproc_core.c | 31 +++++++++++++------------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
> ---
> base-commit: 1fdbb3ff1233e204e26f9f6821ae9c125a055229
> change-id: 20251016-rproc-cleanup-v3-330464eee32e
> 
> Best regards,
> -- 
> Peng Fan <peng.fan@nxp.com>
> 

      parent reply	other threads:[~2025-10-27 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 11:47 [PATCH v3 0/4] remoteproc: core: misc update Peng Fan
2025-10-16 11:47 ` [PATCH v3 1/4] remoteproc: core: Drop redundant initialization of 'ret' in rproc_shutdown() Peng Fan
2025-10-16 11:47 ` [PATCH v3 2/4] remoteproc: core: Sort header includes Peng Fan
2025-10-16 11:48 ` [PATCH v3 3/4] remoteproc: core: Removed unused headers Peng Fan
2025-10-16 11:48 ` [PATCH v3 4/4] remoteproc: core: Remove unused export of rproc_va_to_pa Peng Fan
2025-10-27 15:31 ` Mathieu Poirier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aP-QOnTuiEcx9nQK@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=afd@ti.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andersson@kernel.org \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=daniel.baluta@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=peng.fan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.