From: Shawn Guo <shawnguo2@yeah.net>
To: jan.petrous@oss.nxp.com
Cc: Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
NXP S32 Linux Team <s32@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: freescale: Add GMAC Ethernet for S32G2 EVB and RDB2 and S32G3 RDB3
Date: Mon, 27 Oct 2025 13:36:14 +0800 [thread overview]
Message-ID: <aP8Ezk_zjo-NZCD4@dragon> (raw)
In-Reply-To: <20251006-nxp-s32g-boards-v1-1-f70a57b8087f@oss.nxp.com>
On Mon, Oct 06, 2025 at 06:31:28PM +0200, Jan Petrous via B4 Relay wrote:
> From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
>
> Add support for the Ethernet connection over GMAC controller connected to
> the Micrel KSZ9031 Ethernet RGMII PHY located on the boards.
>
> The mentioned GMAC controller is one of two network controllers
> embedded on the NXP Automotive SoCs S32G2 and S32G3.
>
> The supported boards:
> * EVB: S32G-VNP-EVB with S32G2 SoC
> * RDB2: S32G-VNP-RDB2
> * RDB3: S32G-VNP-RDB3
>
> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
> ---
> arch/arm64/boot/dts/freescale/s32g2.dtsi | 50 ++++++++++++++++++++++++-
> arch/arm64/boot/dts/freescale/s32g274a-evb.dts | 21 ++++++++++-
> arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts | 19 ++++++++++
> arch/arm64/boot/dts/freescale/s32g3.dtsi | 50 ++++++++++++++++++++++++-
> arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts | 21 ++++++++++-
> 5 files changed, 157 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
> index d167624d1f0c..d06103e9564e 100644
> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi
> @@ -3,7 +3,7 @@
> * NXP S32G2 SoC family
> *
> * Copyright (c) 2021 SUSE LLC
> - * Copyright 2017-2021, 2024 NXP
> + * Copyright 2017-2021, 2024-2025 NXP
> */
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> @@ -738,5 +738,53 @@ gic: interrupt-controller@50800000 {
> interrupt-controller;
> #interrupt-cells = <3>;
> };
> +
> + gmac0: ethernet@4033c000 {
Please sort devices in order of unit-address.
> + compatible = "nxp,s32g2-dwmac";
> + reg = <0x4033c000 0x2000>, /* gmac IP */
> + <0x4007c004 0x4>; /* GMAC_0_CTRL_STS */
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq";
> + snps,mtl-rx-config = <&mtl_rx_setup>;
> + snps,mtl-tx-config = <&mtl_tx_setup>;
> + status = "disabled";
> +
> + mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <5>;
> +
> + queue0 {
> + };
We usually have newline between nodes.
> + queue1 {
> + };
> + queue2 {
> + };
> + queue3 {
> + };
> + queue4 {
> + };
> + };
> +
> + mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <5>;
> +
> + queue0 {
> + };
> + queue1 {
> + };
> + queue2 {
> + };
> + queue3 {
> + };
> + queue4 {
> + };
> + };
> +
> + gmac0mdio: mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + };
> + };
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
> index c4a195dd67bf..f020da03979a 100644
> --- a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
> +++ b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> /*
> * Copyright (c) 2021 SUSE LLC
> - * Copyright 2019-2021, 2024 NXP
> + * Copyright 2019-2021, 2024-2025 NXP
> */
>
> /dts-v1/;
> @@ -15,6 +15,7 @@ / {
>
> aliases {
> serial0 = &uart0;
> + ethernet0 = &gmac0;
Sort aliases in alphabetical order.
Shawn
> };
>
> chosen {
> @@ -43,3 +44,21 @@ &usdhc0 {
> no-1-8-v;
> status = "okay";
> };
> +
> +&gmac0 {
> + clocks = <&clks 24>, <&clks 19>, <&clks 18>, <&clks 15>;
> + clock-names = "stmmaceth", "tx", "rx", "ptp_ref";
> + phy-mode = "rgmii-id";
> + phy-handle = <&rgmiiaphy4>;
> + status = "okay";
> +};
> +
> +&gmac0mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* KSZ 9031 on RGMII */
> + rgmiiaphy4: ethernet-phy@4 {
> + reg = <4>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
> index 4f58be68c818..b9c2f964b3f7 100644
> --- a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
> +++ b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
> @@ -16,6 +16,7 @@ / {
> aliases {
> serial0 = &uart0;
> serial1 = &uart1;
> + ethernet0 = &gmac0;
> };
>
> chosen {
> @@ -77,3 +78,21 @@ &usdhc0 {
> no-1-8-v;
> status = "okay";
> };
> +
> +&gmac0 {
> + clocks = <&clks 24>, <&clks 19>, <&clks 18>, <&clks 15>;
> + clock-names = "stmmaceth", "tx", "rx", "ptp_ref";
> + phy-mode = "rgmii-id";
> + phy-handle = <&rgmiiaphy1>;
> + status = "okay";
> +};
> +
> +&gmac0mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* KSZ 9031 on RGMII */
> + rgmiiaphy1: ethernet-phy@1 {
> + reg = <1>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> index be3a582ebc1b..e31184847371 100644
> --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> /*
> - * Copyright 2021-2024 NXP
> + * Copyright 2021-2025 NXP
> *
> * Authors: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
> * Ciprian Costea <ciprianmarian.costea@nxp.com>
> @@ -883,6 +883,54 @@ gic: interrupt-controller@50800000 {
> <0x50420000 0x2000>;
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + gmac0: ethernet@4033c000 {
> + compatible = "nxp,s32g2-dwmac";
> + reg = <0x4033c000 0x2000>, /* gmac IP */
> + <0x4007c004 0x4>; /* GMAC_0_CTRL_STS */
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq";
> + snps,mtl-rx-config = <&mtl_rx_setup>;
> + snps,mtl-tx-config = <&mtl_tx_setup>;
> + status = "disabled";
> +
> + mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <5>;
> +
> + queue0 {
> + };
> + queue1 {
> + };
> + queue2 {
> + };
> + queue3 {
> + };
> + queue4 {
> + };
> + };
> +
> + mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <5>;
> +
> + queue0 {
> + };
> + queue1 {
> + };
> + queue2 {
> + };
> + queue3 {
> + };
> + queue4 {
> + };
> + };
> +
> + gmac0mdio: mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + };
> + };
> };
>
> timer {
> diff --git a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> index e94f70ad82d9..4a74923789ae 100644
> --- a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> +++ b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> /*
> - * Copyright 2021-2024 NXP
> + * Copyright 2021-2025 NXP
> *
> * NXP S32G3 Reference Design Board 3 (S32G-VNP-RDB3)
> */
> @@ -18,6 +18,7 @@ aliases {
> mmc0 = &usdhc0;
> serial0 = &uart0;
> serial1 = &uart1;
> + ethernet0 = &gmac0;
> };
>
> chosen {
> @@ -93,3 +94,21 @@ &usdhc0 {
> disable-wp;
> status = "okay";
> };
> +
> +&gmac0 {
> + clocks = <&clks 24>, <&clks 19>, <&clks 18>, <&clks 15>;
> + clock-names = "stmmaceth", "tx", "rx", "ptp_ref";
> + phy-mode = "rgmii-id";
> + phy-handle = <&rgmiiaphy1>;
> + status = "okay";
> +};
> +
> +&gmac0mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* KSZ 9031 on RGMII */
> + rgmiiaphy1: ethernet-phy@1 {
> + reg = <1>;
> + };
> +};
>
> ---
> base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
> change-id: 20251006-nxp-s32g-boards-2d156255b592
>
> Best regards,
> --
> Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
>
>
next prev parent reply other threads:[~2025-10-27 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 16:31 [PATCH] arm64: dts: freescale: Add GMAC Ethernet for S32G2 EVB and RDB2 and S32G3 RDB3 Jan Petrous (OSS)
2025-10-06 16:31 ` Jan Petrous via B4 Relay
2025-10-15 8:12 ` Enric Balletbo i Serra
2025-10-27 5:36 ` Shawn Guo [this message]
2025-10-31 14:04 ` Jan Petrous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aP8Ezk_zjo-NZCD4@dragon \
--to=shawnguo2@yeah.net \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jan.petrous@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.