From: Ido Schimmel <idosch@idosch.org>
To: "Johannes Wiesböck" <johannes.wiesboeck@aisec.fraunhofer.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Xiao Liang" <shaw.leon@gmail.com>,
"Vlad Yasevich" <vyasevic@redhat.com>,
"Jitendra Kalsaria" <jitendra.kalsaria@qlogic.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gyroidos@aisec.fraunhofer.de, sw@simonwunderlich.de,
"Michael Weiß" <michael.weiss@aisec.fraunhofer.de>,
"Harshal Gohel" <hg@simonwunderlich.de>
Subject: Re: [PATCH net v2] rtnetlink: Allow deleting FDB entries in user namespace
Date: Thu, 16 Oct 2025 10:59:44 +0300 [thread overview]
Message-ID: <aPCl8EO8xkRVzaQi@shredder> (raw)
In-Reply-To: <20251015201548.319871-1-johannes.wiesboeck@aisec.fraunhofer.de>
On Wed, Oct 15, 2025 at 10:15:43PM +0200, Johannes Wiesböck wrote:
> Creating FDB entries is possible from a non-initial user namespace when
> having CAP_NET_ADMIN, yet, when deleting FDB entries, processes receive
> an EPERM because the capability is always checked against the initial
> user namespace. This restricts the FDB management from unprivileged
> containers.
>
> Drop the netlink_capable check in rtnl_fdb_del as it was originally
> dropped in c5c351088ae7 and reintroduced in 1690be63a27b without
> intention.
>
> This patch was tested using a container on GyroidOS, where it was
> possible to delete FDB entries from an unprivileged user namespace and
> private network namespace.
>
> Fixes: 1690be63a27b ("bridge: Add vlan support to static neighbors")
> Reviewed-by: Michael Weiß <michael.weiss@aisec.fraunhofer.de>
> Tested-by: Harshal Gohel <hg@simonwunderlich.de>
> Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-10-16 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 20:15 [PATCH net v2] rtnetlink: Allow deleting FDB entries in user namespace Johannes Wiesböck
2025-10-16 7:59 ` Ido Schimmel [this message]
2025-10-16 11:45 ` Nikolay Aleksandrov
2025-10-16 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPCl8EO8xkRVzaQi@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gyroidos@aisec.fraunhofer.de \
--cc=hg@simonwunderlich.de \
--cc=horms@kernel.org \
--cc=jitendra.kalsaria@qlogic.com \
--cc=johannes.wiesboeck@aisec.fraunhofer.de \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.weiss@aisec.fraunhofer.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shaw.leon@gmail.com \
--cc=sw@simonwunderlich.de \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.