All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Tomas Mudrunka <tomas.mudrunka@gmail.com>, corbet@lwn.net
Cc: cengiz@kernel.wtf, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	mail@anselmschueler.com
Subject: Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters
Date: Thu, 16 Oct 2025 17:47:03 +0700	[thread overview]
Message-ID: <aPDNJ3f1H_65infk@archie.me> (raw)
In-Reply-To: <20251016101758.1441349-1-tomas.mudrunka@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

On Thu, Oct 16, 2025 at 12:17:58PM +0200, Tomas Mudrunka wrote:
> Hi. I am author of that sentence and this is NACK from me.

Oops, I didn't see your review when I send v2 [1].

[1]: https://lore.kernel.org/linux-doc/20251016103609.33897-2-bagasdotme@gmail.com/

> 
> > I'm not sure this is right - there is a warning here that additional
> > characters may acquire a meaning in the future, so one should not
> > develop the habit of writing them now.
> 
> As you've said... I don't see anything confusing about that.
> The warning was added for a reason, because there was discussion
> about some people writing extra characters in there, which might
> cause issues down the line if we refactor the code in future.

Any pointers to these discussions? Or do you have any idea on better
description on /proc/sysrq-trigger itself?

Confused...

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-10-16 10:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 11:24 [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters Bagas Sanjaya
2025-10-09  2:18 ` Randy Dunlap
2025-10-14 14:55 ` Jonathan Corbet
2025-10-14 17:57   ` Randy Dunlap
2025-10-15  0:11     ` Bagas Sanjaya
2025-10-15  6:18       ` Jiri Slaby
2025-10-15  9:39         ` Bagas Sanjaya
2025-10-16 10:17   ` Tomas Mudrunka
2025-10-16 10:47     ` Bagas Sanjaya [this message]
2025-10-16 18:51     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPDNJ3f1H_65infk@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=cengiz@kernel.wtf \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mail@anselmschueler.com \
    --cc=tomas.mudrunka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.