From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux@ew.tq-group.com
Subject: Re: [PATCH] serial: imx: allow CRTSCTS with RTS/CTS GPIOs
Date: Thu, 16 Oct 2025 16:21:15 +0100 [thread overview]
Message-ID: <aPENa90OS4ZZA5Rc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251016113730.245341-1-matthias.schiffer@ew.tq-group.com>
On Thu, Oct 16, 2025 at 01:37:30PM +0200, Matthias Schiffer wrote:
> - if (!sport->have_rtscts)
> + if (!sport->have_rtscts && !sport->have_rtsgpio)
This is fine...
> - } else if (termios->c_cflag & CRTSCTS) {
> + } else if ((termios->c_cflag & CRTSCTS) && sport->have_rtscts) {
This adds extra parens that do nothing to aid readability. Too many
parens actually hurt readability.
> - if (termios->c_cflag & CRTSCTS)
> + if ((termios->c_cflag & CRTSCTS) && sport->have_rtscts)
Same here.
Maybe change these to:
if (sport->have_rtscts && termios->c_cflag & CRTSCTS)
?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-10-16 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 11:37 [PATCH] serial: imx: allow CRTSCTS with RTS/CTS GPIOs Matthias Schiffer
2025-10-16 15:08 ` Frank Li
2025-10-16 15:21 ` Russell King (Oracle) [this message]
2025-10-17 15:01 ` Uwe Kleine-König
2025-10-20 8:09 ` Matthias Schiffer
2025-10-21 8:59 ` Uwe Kleine-König
2025-10-21 9:37 ` Matthias Schiffer
2025-10-22 13:36 ` Matthias Schiffer
2025-10-23 6:55 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPENa90OS4ZZA5Rc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.