Re: [PATCH v5 6/7] liveupdate: kho: move to kernel/liveupdate

[Mike Rapoport <rppt@kernel.org>]

On Wed, Oct 15, 2025 at 07:50:59AM -0400, Pasha Tatashin wrote:
> On Wed, Oct 15, 2025 at 4:09 AM Mike Rapoport <rppt@kernel.org> wrote:
> >
> > On Tue, Oct 07, 2025 at 03:30:59AM +0000, Pasha Tatashin wrote:
> > > Move KHO to kernel/liveupdate/ in preparation of placing all Live Update
> > > core kernel related files to the same place.
> > >
> > > Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> > > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> >
> > Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> 
> Thank you.
> 
> >
> > One comment below.
> >
> > > ---
> > >  Documentation/core-api/kho/concepts.rst       |  2 +-
> > >  MAINTAINERS                                   |  2 +-
> > >  init/Kconfig                                  |  2 ++
> > >  kernel/Kconfig.kexec                          | 25 ----------------
> > >  kernel/Makefile                               |  3 +-
> > >  kernel/liveupdate/Kconfig                     | 30 +++++++++++++++++++
> > >  kernel/liveupdate/Makefile                    |  4 +++
> > >  kernel/{ => liveupdate}/kexec_handover.c      |  6 ++--
> > >  .../{ => liveupdate}/kexec_handover_debug.c   |  0
> > >  .../kexec_handover_internal.h                 |  0
> > >  10 files changed, 42 insertions(+), 32 deletions(-)
> > >  create mode 100644 kernel/liveupdate/Kconfig
> > >  create mode 100644 kernel/liveupdate/Makefile
> > >  rename kernel/{ => liveupdate}/kexec_handover.c (99%)
> > >  rename kernel/{ => liveupdate}/kexec_handover_debug.c (100%)
> > >  rename kernel/{ => liveupdate}/kexec_handover_internal.h (100%)
> > >
> > > diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
> > > new file mode 100644
> > > index 000000000000..522b9f74d605
> > > --- /dev/null
> > > +++ b/kernel/liveupdate/Kconfig
> > > @@ -0,0 +1,30 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +
> > > +menu "Live Update"
> >
> > KHO can be used without Live Update, let's make this "Kexec HandOver and
> > Live Update"
> 
> IMO the current menu name is OK, as it is an option presented only to
> users configuring the kernel, my rational for that thinking is that
> KHO is an independent module, but it should be enabled as a dependency
> by other kernel features that require it.

I think that we should allow enabling KHO on its own. For example, preserving
tracing data in reserve_mem usecase does not have a strict dependency on
KHO and it surely does not drive it. 

-- 
Sincerely yours,
Mike.