From: Dan Carpenter <dan.carpenter@linaro.org>
To: Emre Cecanpunar <emreleno@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro
Date: Thu, 16 Oct 2025 20:53:57 +0300 [thread overview]
Message-ID: <aPExNS9yUUkBJSjq@stanley.mountain> (raw)
In-Reply-To: <20251016145324.13537-1-emreleno@gmail.com>
On Thu, Oct 16, 2025 at 05:53:24PM +0300, Emre Cecanpunar wrote:
> @@ -70,18 +62,15 @@ static int nvec_ps2_notifier(struct notifier_block *nb,
> case NVEC_PS2_EVT:
> for (i = 0; i < msg[1]; i++)
> serio_interrupt(ps2_dev.ser_dev, msg[2 + i], 0);
> - NVEC_PHD("ps/2 mouse event: ", &msg[2], msg[1]);
> return NOTIFY_STOP;
>
> case NVEC_PS2:
> if (msg[2] == 1) {
> for (i = 0; i < (msg[1] - 2); i++)
> serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
> - NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
> }
>
> else if (msg[1] != 2) /* !ack */
> - NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);
This will introduce a bug.
regards,
dan carpenter
> return NOTIFY_STOP;
> }
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-10-16 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 14:53 [PATCH] staging: nvec: remove NVEC_PS2_DEBUG and dead debug macro Emre Cecanpunar
2025-10-16 17:53 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-18 10:01 Emre Cecanpunar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPExNS9yUUkBJSjq@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=emreleno@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.